[{"id":3834,"web_url":"https://patchwork.libcamera.org/comment/3834/","msgid":"<20200222102718.GB4846@pendragon.ideasonboard.com>","date":"2020-02-22T10:27:18","subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: utils: Add a C++\n\tdirname implementation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 21, 2020 at 04:31:25PM +0000, Kieran Bingham wrote:\n> Provide a std::string based implementation which conforms to the\n> behaviour of the dirname() fucntion defined by POSIX.\n> \n> Tests are added to cover expected corner cases of the implementation.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/include/utils.h | 1 +\n> src/libcamera/utils.cpp | 48 +++++++++++++++++++++++++++++++\n> test/utils.cpp | 54 +++++++++++++++++++++++++++++++++++\n> 3 files changed, 103 insertions(+)\n> \n> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> index 080ea6614de0..940597760ee2 100644\n> --- a/src/libcamera/include/utils.h\n> +++ b/src/libcamera/include/utils.h\n> @@ -33,6 +33,7 @@ namespace utils {\n> const char *basename(const char *path);\n> \n> char *secure_getenv(const char *name);\n> +std::string dirname(const std::string &path);\n> \n> template\n> unsigned int set_overlap(InputIt1 first1, InputIt1 last1,\n> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> index 453e3b3b5995..f566e88cec5b 100644\n> --- a/src/libcamera/utils.cpp\n> +++ b/src/libcamera/utils.cpp\n> @@ -70,6 +70,54 @@ char *secure_getenv(const char *name)\n> #endif\n> }\n> \n> +/**\n> + * \\brief Identify the dirname portion of a path\n> + * \\param[in] path The full path to parse\n> + *\n> + * This function conforms with the behaviour of the %dirname() function as\n> + * defined by POSIX.\n> + *\n> + * \\return A string of the directory component of the path\n> + */\n> +std::string dirname(const std::string &path)\n> +{\n> +\tif (path.empty())\n> +\t\treturn \".\";\n> +\n> +\t/*\n> +\t * Skip all trailing slashes. If the path is only made of slashes,\n> +\t * return \"/\".\n> +\t */\n> +\tsize_t pos = path.size() - 1;\n> +\twhile (path[pos] == '/') {\n> +\t\tif (!pos)\n> +\t\t\treturn \"/\";\n> +\t\tpos--;\n> +\t}\n> +\n> +\t/*\n> +\t * Find the previous slash. If the path contains no non-trailing slash,\n> +\t * return \".\".\n> +\t */\n> +\twhile (path[pos] != '/') {\n> +\t\tif (!pos)\n> +\t\t\treturn \".\";\n> +\t\tpos--;\n> +\t}\n> +\n> +\t/*\n> +\t * Return the directory name up to (but not including) any trailing\n> +\t * slash. If this would result in an empty string, return \"/\".\n> +\t */\n> +\twhile (path[pos] == '/') {\n> +\t\tif (!pos)\n> +\t\t\treturn \"/\";\n> +\t\tpos--;\n> +\t}\n> +\n> +\treturn path.substr(0, pos + 1);\n> +}\n> +\n> /**\n> * \\fn libcamera::utils::set_overlap(InputIt1 first1, InputIt1 last1,\n> *\t\t\t\t InputIt2 first2, InputIt2 last2)\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index db1fbdde847d..e4184e39ce32 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -19,6 +19,56 @@ using namespace libcamera;\n> class UtilsTest : public Test\n> {\n> protected:\n> +\tint testDirname()\n> +\t{\n> +\t\tstd::vector paths = {\n\nYou can make this const.\n\n> +\t\t\t\"\",\n> +\t\t\t\"///\",\n> +\t\t\t\"/bin\",\n> +\t\t\t\"/usr/bin\",\n> +\t\t\t\"//etc////\",\n> +\t\t\t\"//tmp//d//\",\n> +\t\t\t\"current_file\",\n> +\t\t\t\"./current_file\",\n> +\t\t\t\"./current_dir/\",\n> +\t\t\t\"current_dir/\",\n> +\t\t};\n> +\n> +\t\tstd::vector expected = {\n\nAnd this too.\n\n> +\t\t\t\".\",\n> +\t\t\t\"/\",\n> +\t\t\t\"/\",\n> +\t\t\t\"/usr\",\n> +\t\t\t\"/\",\n> +\t\t\t\"//tmp\",\n> +\t\t\t\".\",\n> +\t\t\t\".\",\n> +\t\t\t\".\",\n> +\t\t\t\".\",\n> +\t\t};\n\nI was going to propose using the libc-provided dirname() function to\ncheck for correctness instead of hardcoding the results, but that would\ncreate a dependency on the libc implementation conforming with POSIX,\nwhich may not be guaranteed on non-glibc platforms. Let's thus keep it\nas-is.\n\n> +\n> +\t\tstd::vector results;\n> +\n> +\t\tfor (const auto &path : paths)\n> +\t\t\tresults.push_back(utils::dirname(path));\n> +\n> +\t\tif (results != expected) {\n> +\t\t\tcerr << \"utils::dirname() tests failed\" << endl;\n> +\n> +\t\t\tcerr << \"expected: \" << endl;\n> +\t\t\tfor (const auto &path : expected)\n> +\t\t\t\tcerr << \" \" << path << endl;\n\n\"\\t\" instead of \" \" for additional clarity ?\n\n> +\n> +\t\t\tcerr << \"results: \" << endl;\n> +\t\t\tfor (const auto &path : results)\n> +\t\t\t\tcerr << \" \" << path << endl;\n\nHere too ?\n\n> +\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\treturn 0;\n\n\t\treturn TestPass;\n\n> +\t}\n> +\n> \tint run()\n> \t{\n> \t\t/* utils::hex() test. */\n> @@ -71,6 +121,10 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/* utils::dirname() tests. */\n> +\t\tif (testDirname())\n\n\t\tif (testDirname() != TestPass)\n\n?\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\treturn TestFail;\n> +\n> \t\treturn TestPass;\n> \t}\n> };","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 893A860430\n\tfor ;\n\tSat, 22 Feb 2020 11:27:39 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D33A033E;\n\tSat, 22 Feb 2020 11:27:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582367259;\n\tbh=4wcUnqwnSBCxt5gpDaZUYQMZmpVDSSSvML110YOBOyI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hep7SQ2WFBA7cqNA79ShKYB6Y3t8WF6t0sQPauIlcVXPHZ50tpD7fPUNqME9Nhdxo\n\tiGKZSoyRB44SUEi3IJXsMfPji04TXDNSOXsYpKOcJArEHmPYdVDWvCwSb0jTH9FMC2\n\t19GLQqtTeJerCh2N3NK2X226FOaE00at37yKPIA8=","Date":"Sat, 22 Feb 2020 12:27:18 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200222102718.GB4846@pendragon.ideasonboard.com>","References":"<20200221163130.4791-1-kieran.bingham@ideasonboard.com>\n\t<20200221163130.4791-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200221163130.4791-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: utils: Add a C++\n\tdirname implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 22 Feb 2020 10:27:39 -0000"}},{"id":3837,"web_url":"https://patchwork.libcamera.org/comment/3837/","msgid":"<61bc236e-ae96-2cca-965e-a12196cff6d2@ideasonboard.com>","date":"2020-02-24T09:36:11","subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: utils: Add a C++\n\tdirname implementation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/02/2020 10:27, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Feb 21, 2020 at 04:31:25PM +0000, Kieran Bingham wrote:\n>> Provide a std::string based implementation which conforms to the\n>> behaviour of the dirname() fucntion defined by POSIX.\n>>\n>> Tests are added to cover expected corner cases of the implementation.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/include/utils.h | 1 +\n>> src/libcamera/utils.cpp | 48 +++++++++++++++++++++++++++++++\n>> test/utils.cpp | 54 +++++++++++++++++++++++++++++++++++\n>> 3 files changed, 103 insertions(+)\n>>\n>> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n>> index 080ea6614de0..940597760ee2 100644\n>> --- a/src/libcamera/include/utils.h\n>> +++ b/src/libcamera/include/utils.h\n>> @@ -33,6 +33,7 @@ namespace utils {\n>> const char *basename(const char *path);\n>> \n>> char *secure_getenv(const char *name);\n>> +std::string dirname(const std::string &path);\n>> \n>> template\n>> unsigned int set_overlap(InputIt1 first1, InputIt1 last1,\n>> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n>> index 453e3b3b5995..f566e88cec5b 100644\n>> --- a/src/libcamera/utils.cpp\n>> +++ b/src/libcamera/utils.cpp\n>> @@ -70,6 +70,54 @@ char *secure_getenv(const char *name)\n>> #endif\n>> }\n>> \n>> +/**\n>> + * \\brief Identify the dirname portion of a path\n>> + * \\param[in] path The full path to parse\n>> + *\n>> + * This function conforms with the behaviour of the %dirname() function as\n>> + * defined by POSIX.\n>> + *\n>> + * \\return A string of the directory component of the path\n>> + */\n>> +std::string dirname(const std::string &path)\n>> +{\n>> +\tif (path.empty())\n>> +\t\treturn \".\";\n>> +\n>> +\t/*\n>> +\t * Skip all trailing slashes. If the path is only made of slashes,\n>> +\t * return \"/\".\n>> +\t */\n>> +\tsize_t pos = path.size() - 1;\n>> +\twhile (path[pos] == '/') {\n>> +\t\tif (!pos)\n>> +\t\t\treturn \"/\";\n>> +\t\tpos--;\n>> +\t}\n>> +\n>> +\t/*\n>> +\t * Find the previous slash. If the path contains no non-trailing slash,\n>> +\t * return \".\".\n>> +\t */\n>> +\twhile (path[pos] != '/') {\n>> +\t\tif (!pos)\n>> +\t\t\treturn \".\";\n>> +\t\tpos--;\n>> +\t}\n>> +\n>> +\t/*\n>> +\t * Return the directory name up to (but not including) any trailing\n>> +\t * slash. If this would result in an empty string, return \"/\".\n>> +\t */\n>> +\twhile (path[pos] == '/') {\n>> +\t\tif (!pos)\n>> +\t\t\treturn \"/\";\n>> +\t\tpos--;\n>> +\t}\n>> +\n>> +\treturn path.substr(0, pos + 1);\n>> +}\n>> +\n>> /**\n>> * \\fn libcamera::utils::set_overlap(InputIt1 first1, InputIt1 last1,\n>> *\t\t\t\t InputIt2 first2, InputIt2 last2)\n>> diff --git a/test/utils.cpp b/test/utils.cpp\n>> index db1fbdde847d..e4184e39ce32 100644\n>> --- a/test/utils.cpp\n>> +++ b/test/utils.cpp\n>> @@ -19,6 +19,56 @@ using namespace libcamera;\n>> class UtilsTest : public Test\n>> {\n>> protected:\n>> +\tint testDirname()\n>> +\t{\n>> +\t\tstd::vector paths = {\n> \n> You can make this const.\n\nAh yes\n\n> \n>> +\t\t\t\"\",\n>> +\t\t\t\"///\",\n>> +\t\t\t\"/bin\",\n>> +\t\t\t\"/usr/bin\",\n>> +\t\t\t\"//etc////\",\n>> +\t\t\t\"//tmp//d//\",\n>> +\t\t\t\"current_file\",\n>> +\t\t\t\"./current_file\",\n>> +\t\t\t\"./current_dir/\",\n>> +\t\t\t\"current_dir/\",\n>> +\t\t};\n>> +\n>> +\t\tstd::vector expected = {\n> \n> And this too.\n> \n>> +\t\t\t\".\",\n>> +\t\t\t\"/\",\n>> +\t\t\t\"/\",\n>> +\t\t\t\"/usr\",\n>> +\t\t\t\"/\",\n>> +\t\t\t\"//tmp\",\n>> +\t\t\t\".\",\n>> +\t\t\t\".\",\n>> +\t\t\t\".\",\n>> +\t\t\t\".\",\n>> +\t\t};\n> \n> I was going to propose using the libc-provided dirname() function to\n> check for correctness instead of hardcoding the results, but that would\n> create a dependency on the libc implementation conforming with POSIX,\n> which may not be guaranteed on non-glibc platforms. Let's thus keep it\n> as-is.\n\nIndeed, I wanted direct expected results hardcoded for validation.\n\nI also liked your utils::split test implementation, and I was tempted to\nmake this a vector of struct { char * path, char * expected } , but I\njust went with this for speed, and because it's nice to show the whole\nresults in the event of a failure.\n\n\n>> +\n>> +\t\tstd::vector results;\n>> +\n>> +\t\tfor (const auto &path : paths)\n>> +\t\t\tresults.push_back(utils::dirname(path));\n>> +\n>> +\t\tif (results != expected) {\n>> +\t\t\tcerr << \"utils::dirname() tests failed\" << endl;\n>> +\n>> +\t\t\tcerr << \"expected: \" << endl;\n>> +\t\t\tfor (const auto &path : expected)\n>> +\t\t\t\tcerr << \" \" << path << endl;\n> \n> \"\\t\" instead of \" \" for additional clarity ?\n\nSure, Mostly this code came in useful while I was fixing the\nimplementation so I /hope/ it will never be broken, and thus this code\nshouldn't ever print (unless someone extends the tss?)\n\n> \n>> +\n>> +\t\t\tcerr << \"results: \" << endl;\n>> +\t\t\tfor (const auto &path : results)\n>> +\t\t\t\tcerr << \" \" << path << endl;\n> \n> Here too ?\n> \n>> +\n>> +\t\t\treturn TestFail;\n>> +\t\t}\n>> +\n>> +\t\treturn 0;\n> \n> \t\treturn TestPass;\n> \n>> +\t}\n>> +\n>> \tint run()\n>> \t{\n>> \t\t/* utils::hex() test. */\n>> @@ -71,6 +121,10 @@ protected:\n>> \t\t\treturn TestFail;\n>> \t\t}\n>> \n>> +\t\t/* utils::dirname() tests. */\n>> +\t\tif (testDirname())\n> \n> \t\tif (testDirname() != TestPass)\n> \n> ?\n\n\nYes, that would be better in case the TestPass/TestFail values ever gets\nchanged underneath...\n\n> \n> Reviewed-by: Laurent Pinchart \n\n\nThanks, fixups applied.\n\n\n> \n>> +\t\t\treturn TestFail;\n>> +\n>> \t\treturn TestPass;\n>> \t}\n>> };\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AB0C6042E\n\tfor ;\n\tMon, 24 Feb 2020 10:36:16 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C2DD33E;\n\tMon, 24 Feb 2020 10:36:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582536975;\n\tbh=mau8r4sGb/gOERIyo0C6hMUdAJFBvcxHM2JimBMENtg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=MvFzb3hYI8Yr8LG1YUq00kJIB7LLG713k5nx6pDxkHAKbU58G3/IBtgaI3CVNKjZt\n\t+ZcwmKTGiB23dDs4AIwEFHFikbbFJM4vbGWZlYHTaB1zYZyclyJnEyJcm64HU6/ipc\n\t8k5N1zOUXpijLCKTnAe8WS4sdNlZ+P88zoSZWndI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200221163130.4791-1-kieran.bingham@ideasonboard.com>\n\t<20200221163130.4791-2-kieran.bingham@ideasonboard.com>\n\t<20200222102718.GB4846@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<61bc236e-ae96-2cca-965e-a12196cff6d2@ideasonboard.com>","Date":"Mon, 24 Feb 2020 09:36:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200222102718.GB4846@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: utils: Add a C++\n\tdirname implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 24 Feb 2020 09:36:16 -0000"}}]