[{"id":3825,"web_url":"https://patchwork.libcamera.org/comment/3825/","msgid":"<20200220212654.GP4998@pendragon.ideasonboard.com>","date":"2020-02-20T21:26:54","subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 20, 2020 at 04:57:04PM +0000, Kieran Bingham wrote:\n> The tests declare a hard-coded LIBCAMERA_IPA_MODULE_PATH to allow tests\n> to run from the test-suite.\n> \n> This requires tests to be run only from the root of the build directory,\n> otherwise (for example, by running in their local directory) they will\n> not be able to correctly locate the IPA modules.\n> \n> Now that the build path for the IPA manager is determined at runtime we\n> can remove the redundant setting of the LIBCAMERA_IPA_MODULE_PATH for\n> tests.\n\n\\o/\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Kieran Bingham \n> ---\n> test/libtest/test.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\n> index 333d2160e276..6cd3fbe6df06 100644\n> --- a/test/libtest/test.cpp\n> +++ b/test/libtest/test.cpp\n> @@ -21,10 +21,6 @@ int Test::execute()\n> {\n> \tint ret;\n> \n> -\tret = setenv(\"LIBCAMERA_IPA_MODULE_PATH\", \"src/ipa\", 1);\n> -\tif (ret)\n> -\t\treturn errno;\n> -\n> \tret = setenv(\"LIBCAMERA_IPA_PROXY_PATH\", \"src/libcamera/proxy/worker\", 1);\n> \tif (ret)\n> \t\treturn errno;\n\nWill we need to do the same for the proxy path ? :-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6975A60434\n\tfor ;\n\tThu, 20 Feb 2020 22:27:14 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE955563;\n\tThu, 20 Feb 2020 22:27:13 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582234034;\n\tbh=3rZ7Enk61b3k7lk4I2Zj6yPHHPULC5wk1htK+0mblRU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=umEiLOa08eSVmNw0qUb5CKyuBfZqlrd5jRFsxs0mt2ipM0cl08r32UCVmuA+gmLYC\n\t6BHjZE2jLnrmndq3xOhtxp7/TOrpcFUhO7bPdliVR9EL/2U83O+QMD4ZeH/hrIhl1D\n\tcjPoCQnVStJYsGRbcGxaIrC89C0kzcBSFCXKR1nE=","Date":"Thu, 20 Feb 2020 23:26:54 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200220212654.GP4998@pendragon.ideasonboard.com>","References":"<20200220165704.23600-1-kieran.bingham@ideasonboard.com>\n\t<20200220165704.23600-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200220165704.23600-7-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 20 Feb 2020 21:27:14 -0000"}},{"id":3829,"web_url":"https://patchwork.libcamera.org/comment/3829/","msgid":"<487e619a-d5b4-6b12-7b25-ad5effb22a81@ideasonboard.com>","date":"2020-02-21T12:40:12","subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 20/02/2020 21:26, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 20, 2020 at 04:57:04PM +0000, Kieran Bingham wrote:\n>> The tests declare a hard-coded LIBCAMERA_IPA_MODULE_PATH to allow tests\n>> to run from the test-suite.\n>>\n>> This requires tests to be run only from the root of the build directory,\n>> otherwise (for example, by running in their local directory) they will\n>> not be able to correctly locate the IPA modules.\n>>\n>> Now that the build path for the IPA manager is determined at runtime we\n>> can remove the redundant setting of the LIBCAMERA_IPA_MODULE_PATH for\n>> tests.\n> \n> \\o/\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> Signed-off-by: Kieran Bingham \n>> ---\n>> test/libtest/test.cpp | 4 ----\n>> 1 file changed, 4 deletions(-)\n>>\n>> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\n>> index 333d2160e276..6cd3fbe6df06 100644\n>> --- a/test/libtest/test.cpp\n>> +++ b/test/libtest/test.cpp\n>> @@ -21,10 +21,6 @@ int Test::execute()\n>> {\n>> \tint ret;\n>> \n>> -\tret = setenv(\"LIBCAMERA_IPA_MODULE_PATH\", \"src/ipa\", 1);\n>> -\tif (ret)\n>> -\t\treturn errno;\n>> -\n>> \tret = setenv(\"LIBCAMERA_IPA_PROXY_PATH\", \"src/libcamera/proxy/worker\", 1);\n>> \tif (ret)\n>> \t\treturn errno;\n> \n> Will we need to do the same for the proxy path ? :-)\n\n\nYes, but I haven't touched that yet until we can get the 'method' done\nright.\n\nI had considered leaving this as a task for any new comer or workshop\ntoo ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAE5460438\n\tfor ;\n\tFri, 21 Feb 2020 13:40:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12561563;\n\tFri, 21 Feb 2020 13:40:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582288817;\n\tbh=6U6D2LirJ0UUZMtCDAWStNP2ptKGLSHbAcilWajgu40=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=dEyIU8znHkRkS7+/KUIDUWYuTS0wgj22QcufuNT8uxPu+3rnOAx2ClQQswkIWezAW\n\t2gtoyU4bk9sNVoAbj9Z9oE/8iHwtbOxq+ZLQkGcKLrTroauVaafKzt6cpbAo8l3ivv\n\tpeu5cLcfc/5tU/v1nen0LOYC8MXluBH0CooYDW3Q=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200220165704.23600-1-kieran.bingham@ideasonboard.com>\n\t<20200220165704.23600-7-kieran.bingham@ideasonboard.com>\n\t<20200220212654.GP4998@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<487e619a-d5b4-6b12-7b25-ad5effb22a81@ideasonboard.com>","Date":"Fri, 21 Feb 2020 12:40:12 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200220212654.GP4998@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Feb 2020 12:40:17 -0000"}},{"id":3832,"web_url":"https://patchwork.libcamera.org/comment/3832/","msgid":"<20200221130408.GC4955@pendragon.ideasonboard.com>","date":"2020-02-21T13:04:08","subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Feb 21, 2020 at 12:40:12PM +0000, Kieran Bingham wrote:\n> On 20/02/2020 21:26, Laurent Pinchart wrote:\n> > On Thu, Feb 20, 2020 at 04:57:04PM +0000, Kieran Bingham wrote:\n> >> The tests declare a hard-coded LIBCAMERA_IPA_MODULE_PATH to allow tests\n> >> to run from the test-suite.\n> >>\n> >> This requires tests to be run only from the root of the build directory,\n> >> otherwise (for example, by running in their local directory) they will\n> >> not be able to correctly locate the IPA modules.\n> >>\n> >> Now that the build path for the IPA manager is determined at runtime we\n> >> can remove the redundant setting of the LIBCAMERA_IPA_MODULE_PATH for\n> >> tests.\n> > \n> > \\o/\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> test/libtest/test.cpp | 4 ----\n> >> 1 file changed, 4 deletions(-)\n> >>\n> >> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\n> >> index 333d2160e276..6cd3fbe6df06 100644\n> >> --- a/test/libtest/test.cpp\n> >> +++ b/test/libtest/test.cpp\n> >> @@ -21,10 +21,6 @@ int Test::execute()\n> >> {\n> >> \tint ret;\n> >> \n> >> -\tret = setenv(\"LIBCAMERA_IPA_MODULE_PATH\", \"src/ipa\", 1);\n> >> -\tif (ret)\n> >> -\t\treturn errno;\n> >> -\n> >> \tret = setenv(\"LIBCAMERA_IPA_PROXY_PATH\", \"src/libcamera/proxy/worker\", 1);\n> >> \tif (ret)\n> >> \t\treturn errno;\n> > \n> > Will we need to do the same for the proxy path ? :-)\n> \n> Yes, but I haven't touched that yet until we can get the 'method' done\n> right.\n> \n> I had considered leaving this as a task for any new comer or workshop\n> too ...\n\nWorks for me. Please just make sure to record it.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42EF460438\n\tfor ;\n\tFri, 21 Feb 2020 14:04:29 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC818563;\n\tFri, 21 Feb 2020 14:04:28 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582290269;\n\tbh=NzZBeIjCDpP1sKugTPtzsnOLn1O+6XuNMi3VsSU+YSs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o5mB2BQbhU9h4AKQhjYnjPWxE0Xn82Xz89CyxkywLwaIyHyNF1bofdiUj2HjaIy8w\n\tNx4HrEZT2d996g064/TcrVve3rilzaAYNyKS1P/gWeXCgJ4jAqZKGrcWGfr6YiRHkW\n\toS2srGaztJ+7BSL7Z/9HOjrCiXSR2jSxEv4z9Ou8=","Date":"Fri, 21 Feb 2020 15:04:08 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200221130408.GC4955@pendragon.ideasonboard.com>","References":"<20200220165704.23600-1-kieran.bingham@ideasonboard.com>\n\t<20200220165704.23600-7-kieran.bingham@ideasonboard.com>\n\t<20200220212654.GP4998@pendragon.ideasonboard.com>\n\t<487e619a-d5b4-6b12-7b25-ad5effb22a81@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<487e619a-d5b4-6b12-7b25-ad5effb22a81@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Feb 2020 13:04:29 -0000"}}]