{"id":2855,"url":"https://patchwork.libcamera.org/api/patches/2855/?format=json","web_url":"https://patchwork.libcamera.org/patch/2855/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200218112752.3910410-7-jacopo@jmondi.org>","date":"2020-02-18T11:27:51","name":"[libcamera-devel,v3,6/7] libcamera: sensor: ov5670: Register pixel array properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"cbbd9abe98316d2ce5b260e260045a5956a52909","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/2855/mbox/","series":[{"id":685,"url":"https://patchwork.libcamera.org/api/series/685/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=685","date":"2020-02-18T11:27:45","name":"Camera sensor factory","version":3,"mbox":"https://patchwork.libcamera.org/series/685/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2855/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2855/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 362B861F57\n\tfor ;\n\tTue, 18 Feb 2020 12:25:18 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D737860002;\n\tTue, 18 Feb 2020 11:25:17 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 18 Feb 2020 12:27:51 +0100","Message-Id":"<20200218112752.3910410-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.25.0","In-Reply-To":"<20200218112752.3910410-1-jacopo@jmondi.org>","References":"<20200218112752.3910410-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 6/7] libcamera: sensor: ov5670:\n\tRegister pixel array properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 11:25:18 -0000"},"content":"Implement sensor specific pixel array properties initialization for the\nOV5670 sensor driver by overriding CameraSensor::initProperties()\nmethod.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/sensor/ov5670.cpp | 39 +++++++++++++++++++++++++++++++++\n 1 file changed, 39 insertions(+)","diff":"diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\nindex 407a0d2967ae..c5fdffda7412 100644\n--- a/src/libcamera/sensor/ov5670.cpp\n+++ b/src/libcamera/sensor/ov5670.cpp\n@@ -5,6 +5,11 @@\n * ov5670.cpp - OV5670 camera sensor\n */\n \n+#include \n+\n+#include \n+#include \n+\n #include \"camera_sensor.h\"\n \n /**\n@@ -18,6 +23,7 @@ class OV5670 final : public CameraSensor\n {\n public:\n \tOV5670(const MediaEntity *entity);\n+\tint initProperties();\n };\n \n /**\n@@ -34,6 +40,39 @@ OV5670::OV5670(const MediaEntity *entity)\n {\n }\n \n+/**\n+ * \\brief Initialize Camera properties with ov5670 specific values\n+ * \\return 0 on success, a negative error code otherwise\n+ */\n+int OV5670::initProperties()\n+{\n+\t/* Pixel Array Properties. */\n+\tstd::array pixelArraySize = { 2.9457f, 2.214f };\n+\tproperties_.set(properties::PixelArraySize,\n+\t\t\tSpan{ pixelArraySize });\n+\n+\tstd::array pixelArrayBounds = { 2592, 1944 };\n+\tproperties_.set(properties::PixelArrayBounds,\n+\t\t\tSpan{ pixelArrayBounds });\n+\n+\tstd::array pixelArrays = { 2592, 1944 };\n+\tproperties_.set(properties::PixelArrays,\n+\t\t\tSpan{ pixelArrays });\n+\n+\tstd::array activeAreaSize = { 16, 6, 2560, 1920 };\n+\tproperties_.set(properties::ActiveAreaSize,\n+\t\t\tSpan{ activeAreaSize });\n+\n+\tint32_t bayerFilter = properties::BayerFilterGRBG;\n+\tproperties_.set(properties::BayerFilterArrangement, bayerFilter);\n+\n+\tstd::array isoSensitivities = { 50, 800 };\n+\tproperties_.set(properties::ISOSensitivityRange,\n+\t\t\tSpan{ isoSensitivities });\n+\n+\treturn CameraSensor::initProperties();\n+}\n+\n REGISTER_CAMERA_SENSOR(OV5670, \"ov5670\");\n \n }; /* namespace libcamera */\n","prefixes":["libcamera-devel","v3","6/7"]}