[{"id":3817,"web_url":"https://patchwork.libcamera.org/comment/3817/","msgid":"<20200218213544.GH1016123@oden.dyn.berto.se>","date":"2020-02-18T21:35:44","subject":"Re: [libcamera-devel] [PATCH v3 4/7] libcamera: sensor: Add OV5670\n\tcamera sensor","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-02-18 12:27:49 +0100, Jacopo Mondi wrote:\n> Add OV5670CameraSensor class to handle Omnivision OV5670 image sensor\n> and register it to the camera sensor factory.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/meson.build | 1 +\n> src/libcamera/sensor/meson.build | 3 +++\n> src/libcamera/sensor/ov5670.cpp | 39 ++++++++++++++++++++++++++++++++\n> 3 files changed, 43 insertions(+)\n> create mode 100644 src/libcamera/sensor/meson.build\n> create mode 100644 src/libcamera/sensor/ov5670.cpp\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index ecc5b5fe4023..7dd7358b174e 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -58,6 +58,7 @@ includes = [\n> \n> subdir('pipeline')\n> subdir('proxy')\n> +subdir('sensor')\n> \n> libudev = dependency('libudev', required : false)\n> \n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> new file mode 100644\n> index 000000000000..7af70370cf5c\n> --- /dev/null\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -0,0 +1,3 @@\n> +libcamera_sources += files([\n> + 'ov5670.cpp',\n> +])\n> diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\n> new file mode 100644\n> index 000000000000..407a0d2967ae\n> --- /dev/null\n> +++ b/src/libcamera/sensor/ov5670.cpp\n> @@ -0,0 +1,39 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * ov5670.cpp - OV5670 camera sensor\n> + */\n> +\n> +#include \"camera_sensor.h\"\n> +\n> +/**\n> + * \\file ov5670.cpp\n> + * \\brief Omnivision OV5670 image sensor\n> + */\n> +\n> +namespace libcamera {\n> +\n> +class OV5670 final : public CameraSensor\n> +{\n> +public:\n> +\tOV5670(const MediaEntity *entity);\n> +};\n> +\n> +/**\n> + * \\class OV5670\n> + * \\brief Camera sensor class for Omnivision OV5670 image sensor\n> + */\n> +\n> +/**\n> + * \\brief Construct the ov5670 sensor class\n> + * \\param[in] entity The media entity representing the sensor\n> + */\n\nOut of curiosity, do you think we shall mandate this type of \ndocumentation for sensor drivers or shall we treat them like the \npipeline handlers where documentation is more optional? At least for \nnow.\n\nWith or with out this addressed for this change,\n\nReviewed-by: Niklas Söderlund \n\n> +OV5670::OV5670(const MediaEntity *entity)\n> +\t: CameraSensor(entity)\n> +{\n> +}\n> +\n> +REGISTER_CAMERA_SENSOR(OV5670, \"ov5670\");\n> +\n> +}; /* namespace libcamera */\n> -- \n> 2.25.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A664F61F64\n\tfor ;\n\tTue, 18 Feb 2020 22:35:46 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id r14so15647838lfm.5\n\tfor ;\n\tTue, 18 Feb 2020 13:35:46 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tw1sm2837193lfe.96.2020.02.18.13.35.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Feb 2020 13:35:45 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=9K5t318xx7xrgwhw8PEFfwNjOXSxtZ6UQPLFbUZZxhA=;\n\tb=TyaFNx86khsb+AaSbWhWudmphTMWuHRN5SZd7g2eSbFXUw7P8TWE8mdJx9TAba2aMN\n\ttMkBBusOnmiP6RqEHWIq4+ZpGy/N/wQqUNwwW200s3AThT93ekQm1Ul7e1EDxwge8ENq\n\t8YTzn/b4KirngAaU/xsziZVMUcJ4kGharuIIJL9H/HtyJS3iY5frfNWO1n1fuauvNHJx\n\t/AjtphmnnDmYOEmxDIJPz1d34+uBLAvviPIWwQnyPMted/xp+R2x0RwKKxo1c2PKqTAo\n\tjw7M5WrS9hrFmWcDk6mI3Can3gYsmXtZcisnkXII6oVeTRzjhcwZnFREAa9CeHALUrpc\n\tG7Og==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=9K5t318xx7xrgwhw8PEFfwNjOXSxtZ6UQPLFbUZZxhA=;\n\tb=SoT2AfrOTYdNNa3EILy25wrAabIDAMk37D+TYafoosDlq9SFnNPKO/+Bv2KqgsjXa6\n\thAoparjReJjvyna0f1xDQKKW5ZQyhK75i1L3viD9nKWVBfGNHYCL9qvaHnXci9Bgmfqj\n\t405We9YHnXzE5x9MeItPTNZ0fI6aw0h+9aWRx4MDZ47F+ri9kC/bpS2hP0rNBlqZkxgu\n\tTZYExKvKrFKs8XzYMRkf5Zx4hciR7XSd90IvgTC+/OVaASSUwjTtfnmO97IgpaYBRkLr\n\tT8mswL1Nv23vRe68lbd8HBdDqIHQTG0axIKjJ8ZGUCNy0BWFUGff8ZSv0cjODA5xQmp6\n\tj5OQ==","X-Gm-Message-State":"APjAAAXjDQ4Ye/LEvMTTmBTx/RJB66I8ZOXULWTrdPwO3R+JYgxO9icZ\n\tOlIgOgc9K0iBawuS+AOqmkMY4Q==","X-Google-Smtp-Source":"APXvYqwZLeiGHJlM/JM+0CNRc0yIT3yY0r0+A757Wr6Z73VbWJ9xn4c/uw0Ms7t4slKaKMjVEdxD1w==","X-Received":"by 2002:ac2:58c2:: with SMTP id\n\tu2mr11357202lfo.206.1582061746027; \n\tTue, 18 Feb 2020 13:35:46 -0800 (PST)","Date":"Tue, 18 Feb 2020 22:35:44 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200218213544.GH1016123@oden.dyn.berto.se>","References":"<20200218112752.3910410-1-jacopo@jmondi.org>\n\t<20200218112752.3910410-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200218112752.3910410-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 4/7] libcamera: sensor: Add OV5670\n\tcamera sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 21:35:46 -0000"}}]