[{"id":3816,"web_url":"https://patchwork.libcamera.org/comment/3816/","msgid":"<20200218211449.GG1016123@oden.dyn.berto.se>","date":"2020-02-18T21:14:49","subject":"Re: [libcamera-devel] [PATCH v3 2/7] libcamera: properties: Define\n\t'lens' properties","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-02-18 12:27:47 +0100, Jacopo Mondi wrote:\n> Define properties that describe the optical characteristics of the image\n> sensor.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++\n> 1 file changed, 34 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 2ffe4d803c0f..4746c3744594 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -563,4 +563,38 @@ controls:\n> The range of supported ISO sensitivities, as documented by the\n> ISO 12232:2006 standard\n> \n> + - LensApertures:\n> + type: float\n> + compound: true\n> + description: |\n> + The available lens apertures, expressed as f numbers (the ratio between\n> + the lens focal distance and the diameter of the pupil aperture).\n> +\n> + If the camera module has a fixed aperture, the property transports a\n> + single value.\n> +\n> + - LensFocalLength:\n\nShould this be renamed LensFocalLengths to indicate ti can carry more \nthen one focal length similar to LensApertures?\n\n> + type: float\n> + compound: true\n> + description: |\n> + The available lens focal lengths, expressed in millimeters.\n> +\n> + If the camera module supports multiple focal lengths this property\n> + reports the focal lengths associated with each discrete step. For\n> + camera modules with a single focal length, a single value should be\n> + instead reported.\n\ns/value should be instead reported/value is reported/\n\n> +\n> + - LensHyperfocalDistance:\n\nLensHyperfocalDistances to indicate it's a compound control ?\n\n> + type: float\n> + compound: true\n> + description: |\n> + The hyperfocal distance of the camera module. The property is\n> + particularly meaningful for modules with a single focal length.\n\nIs not the hyperfocal distance calculated using among other things the \nfocal length and lens apertures? Is there an relationship between the \ndata reported by the three controls?\n\nMy optics are not what they where when I left school so many years ago, \nsorry if I'm confused.\n\n> +\n> + - LensMinimumFocusDistance:\n> + type: float\n> + description: |\n> + The shortest distance in millimeters at which an object could be brought\n> + into sharp focus.\n> +\n> ...\n> -- \n> 2.25.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50CFE61F64\n\tfor ;\n\tTue, 18 Feb 2020 22:14:51 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id l18so15647468lfc.1\n\tfor ;\n\tTue, 18 Feb 2020 13:14:51 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tu19sm2856581lfu.68.2020.02.18.13.14.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Feb 2020 13:14:50 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=J2DSyS3djKDQGHdfTGkkxZE8guiAJW8ew6iennMdOyE=;\n\tb=Ml1nBhJ6NCVe9mphVJPdpwCX+PFOfxiIcDqEO15OVuTUPiDvn7nfQ3dx4lnDDeQpPA\n\t5UMk4Vnp+t8ZAl26e0Er5FmTWlPeZTYzeQXPTBnjITOCoxWBKWzQgJ9GyNsbT82oXmq2\n\tRgMRkrFc5+gR+YhgGUNQN3C2FLavCtFCyKj+QftWVqN29Q0eTWtfWTVkEeKkk4zEMb4w\n\tD09JsZMUvUaXQJvBBOAN9idypusEQfobValezlWHdukMsDpvAVuXWfpc2Z+Wwge35af6\n\tvh9jsLzoMjcbjwFTkvdCyYw2HSoHGG/pRfQ5Rpn3jnLIOtR5JOaH5MMJaqc5o8HXRvIV\n\tP8hA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=J2DSyS3djKDQGHdfTGkkxZE8guiAJW8ew6iennMdOyE=;\n\tb=In+hTG9U+gx72VwlYQTTEhWNzLey/eMdelbRdSnFHq7qxHcyySjeVVz370rt8sdFHt\n\t9n7bMWNDoUI88JZinPEMNwGoR8Yif+RsljtdTdUwTDvWJAtm1xCBvyeWUXIYuN+f8OhT\n\tN678e/ACchJXDiy7FFPDjs3d1kWUDYcUa4h4DZIOy7uFM3l8/zPK/YPa25VqMTEcO7yr\n\to353HqQt0iuoe/OzmkvCyaTpRCi4sh98sRaumgjtOg9kQW6/XfWxvgHS/JCL6kPVrlv7\n\tvISw9oVgs0xuGSJBQuWt0CHziVKA6uqOeO73ydw+Vd1nFK8+D7ImMZXguaAElPEq3Wtd\n\tQdrA==","X-Gm-Message-State":"APjAAAVQKmZDna+k3SAZRNXlZ3G43U+TE4TxjScpKz03QX7MyqP458oS\n\t5qzZvLQ2UAM5ByNmNvLfko7i7K88+FU=","X-Google-Smtp-Source":"APXvYqzYGeWqOsgYq7IHnBg/t9saWcKkcXIwF1VL7lt7u1fKKVodF+DVJAmL3HqXYZwAepM4y6CFgw==","X-Received":"by 2002:ac2:52a2:: with SMTP id r2mr11296766lfm.33.1582060490646;\n\tTue, 18 Feb 2020 13:14:50 -0800 (PST)","Date":"Tue, 18 Feb 2020 22:14:49 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200218211449.GG1016123@oden.dyn.berto.se>","References":"<20200218112752.3910410-1-jacopo@jmondi.org>\n\t<20200218112752.3910410-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200218112752.3910410-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 2/7] libcamera: properties: Define\n\t'lens' properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 21:14:51 -0000"}},{"id":4014,"web_url":"https://patchwork.libcamera.org/comment/4014/","msgid":"<20200309174056.mgtdj6wb6o7dj4bq@uno.localdomain>","date":"2020-03-09T17:40:56","subject":"Re: [libcamera-devel] [PATCH v3 2/7] libcamera: properties: Define\n\t'lens' properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Feb 18, 2020 at 10:14:49PM +0100, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-02-18 12:27:47 +0100, Jacopo Mondi wrote:\n> > Define properties that describe the optical characteristics of the image\n> > sensor.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++\n> > 1 file changed, 34 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 2ffe4d803c0f..4746c3744594 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -563,4 +563,38 @@ controls:\n> > The range of supported ISO sensitivities, as documented by the\n> > ISO 12232:2006 standard\n> >\n> > + - LensApertures:\n> > + type: float\n> > + compound: true\n> > + description: |\n> > + The available lens apertures, expressed as f numbers (the ratio between\n> > + the lens focal distance and the diameter of the pupil aperture).\n> > +\n> > + If the camera module has a fixed aperture, the property transports a\n> > + single value.\n> > +\n> > + - LensFocalLength:\n>\n> Should this be renamed LensFocalLengths to indicate ti can carry more\n> then one focal length similar to LensApertures?\n>\n\nack\n\n> > + type: float\n> > + compound: true\n> > + description: |\n> > + The available lens focal lengths, expressed in millimeters.\n> > +\n> > + If the camera module supports multiple focal lengths this property\n> > + reports the focal lengths associated with each discrete step. For\n> > + camera modules with a single focal length, a single value should be\n> > + instead reported.\n>\n> s/value should be instead reported/value is reported/\n>\n\nAck\n\n> > +\n> > + - LensHyperfocalDistance:\n>\n> LensHyperfocalDistances to indicate it's a compound control ?\n>\n> > + type: float\n> > + compound: true\n> > + description: |\n> > + The hyperfocal distance of the camera module. The property is\n> > + particularly meaningful for modules with a single focal length.\n>\n> Is not the hyperfocal distance calculated using among other things the\n> focal length and lens apertures? Is there an relationship between the\n> data reported by the three controls?\n>\n\nI'm not sure, but I won't document here dependencies between phyisical\nproperties.\n\nThanks\n j\n> My optics are not what they where when I left school so many years ago,\n> sorry if I'm confused.\n>\n> > +\n> > + - LensMinimumFocusDistance:\n> > + type: float\n> > + description: |\n> > + The shortest distance in millimeters at which an object could be brought\n> > + into sharp focus.\n> > +\n> > ...\n> > --\n> > 2.25.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2A32628BD\n\tfor ;\n\tMon, 9 Mar 2020 18:38:05 +0100 (CET)","from uno.localdomain (93-34-114-233.ip49.fastwebnet.it\n\t[93.34.114.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 34F81E0007;\n\tMon, 9 Mar 2020 17:38:04 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","Date":"Mon, 9 Mar 2020 18:40:56 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200309174056.mgtdj6wb6o7dj4bq@uno.localdomain>","References":"<20200218112752.3910410-1-jacopo@jmondi.org>\n\t<20200218112752.3910410-3-jacopo@jmondi.org>\n\t<20200218211449.GG1016123@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20200218211449.GG1016123@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v3 2/7] libcamera: properties: Define\n\t'lens' properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 09 Mar 2020 17:38:05 -0000"}}]