[{"id":3813,"web_url":"https://patchwork.libcamera.org/comment/3813/","msgid":"<20200218201811.GD1016123@oden.dyn.berto.se>","date":"2020-02-18T20:18:11","subject":"Re: [libcamera-devel] [PATCH] qcam: Fix compilation errors with\n\tclang-10","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-02-18 02:14:05 +0200, Laurent Pinchart wrote:\n> clang-10 has introduced the same deprecated-copy warning that appeared\n> in gcc-9 and caused build issues with Qt header files. However, the\n> clang version seems more sensitive, and detects issues that are not\n> fixed in Qt 5.13, unlike gcc-9.\n> \n> Extend the logic that disables the warning for gcc-9 and Qt < 5.13 to\n> cover clang-10 and all Qt versions.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/qcam/meson.build | 13 ++++++-------\n>  1 file changed, 6 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 5b877a84da85..5150631b55c8 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -25,13 +25,12 @@ if qt5_dep.found()\n>      qt5_cpp_args = [ '-DQT_NO_KEYWORDS' ]\n>  \n>      # gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> -    # Qt 5.13. Disable it manually.\n> -    if cc.get_id() == 'gcc'\n> -        gcc_version = cc.version().split('.')\n> -        qt5_version = qt5_dep.version().split('.')\n> -        if qt5_version[1].to_int() < 13 and gcc_version[0].to_int() >= 9\n> -            qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n> -        endif\n> +    # Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> +    # that are not fixed in Qt yet. Disable the warning manually in both cases.\n> +    if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> +         qt5_dep.version().version_compare('<5.13')) or\n> +        (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> +        qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n>      endif\n>  \n>      resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECF0261F5F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Feb 2020 21:18:12 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id d10so24494004ljl.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Feb 2020 12:18:12 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tk25sm3038290lji.42.2020.02.18.12.18.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Feb 2020 12:18:11 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=NGu6cQ1KVLEtX1sUr22nhVMBT1FzaE5OvEuDCVP5g1k=;\n\tb=DVwPUX40ToWxAtWurDHaNNBcSyNP2lwImoSkR3uQoPbGPpusC2O1HXIMULeKzwCNjC\n\tlZQ2loOFxqqra/hmCwwM7sR429PiEMyEp0WRFpkEkcgDRqjclCRLr+qE2W463G2ARxwU\n\tZ/EIaow8j1QSwTI6oNyB3g/mAVCee5AExUt3+DtEfKEWYiptcLcJVtLrao6pPlbMxV5s\n\t0ifTTZU4D9+kldw4n6tVbombv8FY7fx3C3KeI64r0OcC+TosSavstb5k/0a7N4RpWEw5\n\t83d+Iagt54HCDCkTvmyJqQhryhgXoxz49LjP3rutJlLoPxUvoaVcjkUTom3QpDKRfBHW\n\t+imw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=NGu6cQ1KVLEtX1sUr22nhVMBT1FzaE5OvEuDCVP5g1k=;\n\tb=DyMLLOvFbCHzY4Pg/eWB2X+udUjRZozs7HqDK1D8Mk0wHsOr401SPB7yXcHZiOd4vq\n\tj8vP4U0Pt6d0TQQyDBVDSts2xdlV2SfEdUjhboFHFrdwE3/65Khxc29SntJPdyplQ5Em\n\tPGWY7e6yqgWKMGXflNBPwciUALMBnI15V8bZZrV4N2UpLnoU0rTDMZfgLSme7ZU/E/di\n\tKONXBxNUYyzIbuHIbeZBAi+aJoXkPPOXgg5vsT20ni2jiVHbZR8UI6PufZFyKIhNKBKs\n\t1Q5trDkXjCxCWpGQPuNqV6Fz7bLpj+faKudJNqMGIcZZ3uoWmoxLLwzlT6vWjxA9kBXZ\n\tRouA==","X-Gm-Message-State":"APjAAAW613ze0vn1b5VxhsrMpGORYfTj/Ruvuvs2u3q6TJHQyNU3YQqP\n\tZlS9eTbD4+2F+YMLEVNcvYSyQA==","X-Google-Smtp-Source":"APXvYqwi2XM+cW5N7wav0Z1sjVreRhWLVO8ixVPtlaKOOeIgfh0MyQUL0GbAsmk1TeF+zT7H1+/pNA==","X-Received":"by 2002:a2e:3c05:: with SMTP id\n\tj5mr12987855lja.131.1582057092266; \n\tTue, 18 Feb 2020 12:18:12 -0800 (PST)","Date":"Tue, 18 Feb 2020 21:18:11 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200218201811.GD1016123@oden.dyn.berto.se>","References":"<20200218001405.18232-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200218001405.18232-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Fix compilation errors with\n\tclang-10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 18 Feb 2020 20:18:13 -0000"}},{"id":3819,"web_url":"https://patchwork.libcamera.org/comment/3819/","msgid":"<c2efd875-1319-4066-e6d2-ad18d7b36057@ideasonboard.com>","date":"2020-02-19T13:22:29","subject":"Re: [libcamera-devel] [PATCH] qcam: Fix compilation errors with\n\tclang-10","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/02/2020 00:14, Laurent Pinchart wrote:\n> clang-10 has introduced the same deprecated-copy warning that appeared\n> in gcc-9 and caused build issues with Qt header files. However, the\n> clang version seems more sensitive, and detects issues that are not\n> fixed in Qt 5.13, unlike gcc-9.\n> \n> Extend the logic that disables the warning for gcc-9 and Qt < 5.13 to\n> cover clang-10 and all Qt versions.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nPesky compilers... :-D\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/qcam/meson.build | 13 ++++++-------\n>  1 file changed, 6 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 5b877a84da85..5150631b55c8 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -25,13 +25,12 @@ if qt5_dep.found()\n>      qt5_cpp_args = [ '-DQT_NO_KEYWORDS' ]\n>  \n>      # gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n> -    # Qt 5.13. Disable it manually.\n> -    if cc.get_id() == 'gcc'\n> -        gcc_version = cc.version().split('.')\n> -        qt5_version = qt5_dep.version().split('.')\n> -        if qt5_version[1].to_int() < 13 and gcc_version[0].to_int() >= 9\n> -            qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n> -        endif\n> +    # Qt 5.13. clang 10 introduced the same warning, but detects more issues\n> +    # that are not fixed in Qt yet. Disable the warning manually in both cases.\n> +    if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> +         qt5_dep.version().version_compare('<5.13')) or\n> +        (cc.get_id() == 'clang' and cc.version().version_compare('>=10.0')))\n> +        qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n>      endif\n>  \n>      resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F1BF6193C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Feb 2020 14:22:37 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7B4E2F9;\n\tWed, 19 Feb 2020 14:22:36 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582118556;\n\tbh=+x0Qmob9g6eqd59BsKJX4YjXcrU8aov2fKXyhfw3LTc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=oJ+80jAy3PmA4Wck54wsdsTORhDNVc0ZdqkeleprJwBiCU5U/9Zo08J2rAglbyElo\n\tD6Q+O2+iXF6vkyawCNvshbcj5zWSmyZ3ABvQAoSs28CXhlz4qhjlCmh3Vs1TE7XR3z\n\tFInK3e1uYMao61bq8bvK1KXRWYsKU+S4qKFGllLY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200218001405.18232-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<c2efd875-1319-4066-e6d2-ad18d7b36057@ideasonboard.com>","Date":"Wed, 19 Feb 2020 13:22:29 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200218001405.18232-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Fix compilation errors with\n\tclang-10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 19 Feb 2020 13:22:37 -0000"}}]