[{"id":3791,"web_url":"https://patchwork.libcamera.org/comment/3791/","msgid":"<039e1601-f10d-b116-9484-f35f0f6bb5cf@ideasonboard.com>","date":"2020-02-18T00:02:11","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 17/02/2020 23:48, Kieran Bingham wrote:\n> Extend MediaDevice to inherit from the Loggable interface to support a\n> logPrefix which presents the device node path, and the driver name.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n\nTo clarify the change made by this patch:\n\nThis patch changes the output from:\n\n> [57:36:02.635288057] [17731] DEBUG MediaDevice media_device.cpp:793 Debayer A[1] -> Scaler[0]: 0\n> [57:36:02.635365812] [17731] DEBUG MediaDevice media_device.cpp:793 Debayer B[1] -> Scaler[0]: 0\n> [57:36:02.635402682] [17731] DEBUG MediaDevice media_device.cpp:793 RGB/YUV Input[0] -> Scaler[0]: 0\n> [57:36:02.635454420] [17731] DEBUG MediaDevice media_device.cpp:793 Debayer B[1] -> Scaler[0]: 1\n\nto\n\n> [57:34:39.915968711] [17239] WARN VIMC vimc.cpp:372 no matching IPA found\n> [57:34:39.916110489] [17239] DEBUG MediaDevice media_device.cpp:798 /dev/media3[vimc]: Debayer A[1] -> Scaler[0]: 0\n> [57:34:39.916156966] [17239] DEBUG MediaDevice media_device.cpp:798 /dev/media3[vimc]: Debayer B[1] -> Scaler[0]: 0\n> [57:34:39.916184364] [17239] DEBUG MediaDevice media_device.cpp:798 /dev/media3[vimc]: RGB/YUV Input[0] -> Scaler[0]: 0\n> [57:34:39.916226427] [17239] DEBUG MediaDevice media_device.cpp:798 /dev/media3[vimc]: Debayer B[1] -> Scaler[0]: 1\n\n--\nKieran\n\n> src/libcamera/include/media_device.h | 6 +++++-\n> src/libcamera/media_device.cpp | 5 +++++\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\n> index 7b88e2875d59..44a59e70139e 100644\n> --- a/src/libcamera/include/media_device.h\n> +++ b/src/libcamera/include/media_device.h\n> @@ -16,11 +16,12 @@\n> \n> #include \n> \n> +#include \"log.h\"\n> #include \"media_object.h\"\n> \n> namespace libcamera {\n> \n> -class MediaDevice\n> +class MediaDevice : protected Loggable\n> {\n> public:\n> \tMediaDevice(const std::string &deviceNode);\n> @@ -52,6 +53,9 @@ public:\n> \n> \tSignal disconnected;\n> \n> +protected:\n> +\tstd::string logPrefix() const;\n> +\n> private:\n> \tstd::string driver_;\n> \tstd::string deviceNode_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index e1ae34f88455..fad475b9ac76 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -74,6 +74,11 @@ MediaDevice::~MediaDevice()\n> \tclear();\n> }\n> \n> +std::string MediaDevice::logPrefix() const\n> +{\n> +\treturn deviceNode() + \"[\" + driver() + \"]\";\n> +}\n> +\n> /**\n> * \\brief Claim a device for exclusive use\n> *\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33B3A60438\n\tfor ;\n\tTue, 18 Feb 2020 01:02:15 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C8791220;\n\tTue, 18 Feb 2020 01:02:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581984134;\n\tbh=IMfhdvOPiAurIUBW9SGA1F0eFh1sVnkbq8259tp0l48=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bZED7MbNuF/NJEkNtzKRSPBcXKkzefGagiRrKuKOXmLJwemLG+oQZ1Cc/F36vrGYC\n\tMDw3SSDqgHRUnBJrv9zEKqmLPWxSeK5QCbfNzh0Jz3z742clsu9eQkmXWCLAR/4pk3\n\trjcSxyokw5rWNSUH97qVjiqTuJhuCPkmgkSLWx34=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Kieran Bingham ,\n\tLibCamera Devel ","References":"<20200217234841.16390-1-kieran.bingham@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<039e1601-f10d-b116-9484-f35f0f6bb5cf@ideasonboard.com>","Date":"Tue, 18 Feb 2020 00:02:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200217234841.16390-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 00:02:15 -0000"}},{"id":3792,"web_url":"https://patchwork.libcamera.org/comment/3792/","msgid":"<20200218000751.GI4830@pendragon.ideasonboard.com>","date":"2020-02-18T00:07:51","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Feb 17, 2020 at 11:48:41PM +0000, Kieran Bingham wrote:\n> Extend MediaDevice to inherit from the Loggable interface to support a\n> logPrefix which presents the device node path, and the driver name.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/include/media_device.h | 6 +++++-\n> src/libcamera/media_device.cpp | 5 +++++\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\n> index 7b88e2875d59..44a59e70139e 100644\n> --- a/src/libcamera/include/media_device.h\n> +++ b/src/libcamera/include/media_device.h\n> @@ -16,11 +16,12 @@\n> \n> #include \n> \n> +#include \"log.h\"\n> #include \"media_object.h\"\n> \n> namespace libcamera {\n> \n> -class MediaDevice\n> +class MediaDevice : protected Loggable\n> {\n> public:\n> \tMediaDevice(const std::string &deviceNode);\n> @@ -52,6 +53,9 @@ public:\n> \n> \tSignal disconnected;\n> \n> +protected:\n> +\tstd::string logPrefix() const;\n> +\n> private:\n> \tstd::string driver_;\n> \tstd::string deviceNode_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index e1ae34f88455..fad475b9ac76 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -74,6 +74,11 @@ MediaDevice::~MediaDevice()\n> \tclear();\n> }\n> \n> +std::string MediaDevice::logPrefix() const\n> +{\n> +\treturn deviceNode() + \"[\" + driver() + \"]\";\n\nBefore MediaDevice::populate is called, this will print \"/dev/mediaX[]\".\nI suppose that's not a problem.\n\nReviewed-by: Laurent Pinchart \n\n> +}\n> +\n> /**\n> * \\brief Claim a device for exclusive use\n> *","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4694060438\n\tfor ;\n\tTue, 18 Feb 2020 01:08:10 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B2C421220;\n\tTue, 18 Feb 2020 01:08:09 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581984489;\n\tbh=gDmiO61LD2Nb3RMWLiGmpvrR/ccUMAp6eKdcnUCZ8KM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XStQplhfeGM11WTGn+p5haRVVeQ/AoGSHChgZj4s8doriQJczw89mBPsA7UGopnAR\n\tK9g7gJBYOGccmR+LR3Gq0KkuMnku11TgUv1CrNO3X8S9XH9QG3u7kH/SYcHKEp6Flb\n\tPzV2qAvZ73BwzU1dyO/fYnolS4IJwZBvyw3zugdU=","Date":"Tue, 18 Feb 2020 02:07:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200218000751.GI4830@pendragon.ideasonboard.com>","References":"<20200217234841.16390-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200217234841.16390-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 00:08:10 -0000"}},{"id":3812,"web_url":"https://patchwork.libcamera.org/comment/3812/","msgid":"<20200218201541.GC1016123@oden.dyn.berto.se>","date":"2020-02-18T20:15:41","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-02-18 02:07:51 +0200, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Feb 17, 2020 at 11:48:41PM +0000, Kieran Bingham wrote:\n> > Extend MediaDevice to inherit from the Loggable interface to support a\n> > logPrefix which presents the device node path, and the driver name.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/include/media_device.h | 6 +++++-\n> > src/libcamera/media_device.cpp | 5 +++++\n> > 2 files changed, 10 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\n> > index 7b88e2875d59..44a59e70139e 100644\n> > --- a/src/libcamera/include/media_device.h\n> > +++ b/src/libcamera/include/media_device.h\n> > @@ -16,11 +16,12 @@\n> > \n> > #include \n> > \n> > +#include \"log.h\"\n> > #include \"media_object.h\"\n> > \n> > namespace libcamera {\n> > \n> > -class MediaDevice\n> > +class MediaDevice : protected Loggable\n> > {\n> > public:\n> > \tMediaDevice(const std::string &deviceNode);\n> > @@ -52,6 +53,9 @@ public:\n> > \n> > \tSignal disconnected;\n> > \n> > +protected:\n> > +\tstd::string logPrefix() const;\n> > +\n> > private:\n> > \tstd::string driver_;\n> > \tstd::string deviceNode_;\n> > diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> > index e1ae34f88455..fad475b9ac76 100644\n> > --- a/src/libcamera/media_device.cpp\n> > +++ b/src/libcamera/media_device.cpp\n> > @@ -74,6 +74,11 @@ MediaDevice::~MediaDevice()\n> > \tclear();\n> > }\n> > \n> > +std::string MediaDevice::logPrefix() const\n> > +{\n> > +\treturn deviceNode() + \"[\" + driver() + \"]\";\n> \n> Before MediaDevice::populate is called, this will print \"/dev/mediaX[]\".\n> I suppose that's not a problem.\n> \n> Reviewed-by: Laurent Pinchart \n\nI think it's not a problem and I like the added information added to \nlogs from this change.\n\nReviewed-by: Niklas Söderlund \n\n> \n> > +}\n> > +\n> > /**\n> > * \\brief Claim a device for exclusive use\n> > *\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA35961F5F\n\tfor ;\n\tTue, 18 Feb 2020 21:15:43 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id q23so8397473ljm.4\n\tfor ;\n\tTue, 18 Feb 2020 12:15:43 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tm83sm2830186lfa.5.2020.02.18.12.15.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Feb 2020 12:15:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=MCZ+HzdyppiIFoKMCgPQ9d/b2Ca41A/4fiArBcBSGkY=;\n\tb=I8bcwgD9kA7930tRpdAKG8jfZN6tXeL0Kc3ZO/f0Ymoc2FrYGTQHTKg1leOr8hZlIx\n\tcXMRyA8VErby2SWRXDfL1abZYgCpsaFyMs6j2vbI9w9ftBr8iZKp1RHe4paBkvkZ5oK0\n\t9kpHMO9b8Rvm9gF6DnUqppWLlX+BEt3ygZINHZ8QNXb7+ASudqoCxaCxu1yzQJeJDXtm\n\tz63TWrnYjb/OkMXsTTu5PV+bpstUHRu2zzpr1wjTYtEwYYIgAgGgZ1u5t4oq1bhPE1GD\n\tBZ3gQwl3v5b9nhR7NGaoHeyO4vvtf1r7gUGLpmJmXXSWkGI4o1QzV3v9jITmhhjgTCyF\n\taqww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=MCZ+HzdyppiIFoKMCgPQ9d/b2Ca41A/4fiArBcBSGkY=;\n\tb=KUZXGK3oxdLawIaMXFt+AAoqkxpPGYIJvihh5d6Q1jmV3MuMdHJvnSFBSmcKU+bzx+\n\tq2OmwlQON8NmjQBKYp5yiqi9HR0Bye2maEMkDgVCghWCzfvTtZxm+zsnLQtDIcfYuMMK\n\tnPbgW6eKkvkGAxVo8eJwhqj/hl0VV16Jgkob2puDEXrYvMS1Z2NSK+ApSN1QOdz93atn\n\t8+gWpXcmRB7Zy+QDVH3ZKvYYFsjmNOo0yWEz8ndrYVT3BigNZIWdI7n8IubOmTIziDZC\n\tZQ+h9bsoDY14SpV1sBD90P8/0AL78OYBZIScW1pzwsxhSsWqnxmzRvyWfb1sGOfRR7Ag\n\tu/eg==","X-Gm-Message-State":"APjAAAVWyOyDoclyyH0MiELcbN9tkPqqha+mlXAx1x3NWA9tBgsALHOP\n\t/oGnbTcWR4lXDX0tzetYyXL756mqNyI=","X-Google-Smtp-Source":"APXvYqy8UI9JuvcgxGtkV9i7YV0x1+2b8bw9o5lIv8rhn9lAjQy3eXzjtJzAfDd1gyrR2OUoYzsIsQ==","X-Received":"by 2002:a2e:2e11:: with SMTP id\n\tu17mr13542452lju.117.1582056943005; \n\tTue, 18 Feb 2020 12:15:43 -0800 (PST)","Date":"Tue, 18 Feb 2020 21:15:41 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"Kieran Bingham ,\n\tlibcamera devel ","Message-ID":"<20200218201541.GC1016123@oden.dyn.berto.se>","References":"<20200217234841.16390-1-kieran.bingham@ideasonboard.com>\n\t<20200218000751.GI4830@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200218000751.GI4830@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Use Loggable\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 20:15:43 -0000"}}]