[{"id":3797,"web_url":"https://patchwork.libcamera.org/comment/3797/","msgid":"<20200218010556.GO4830@pendragon.ideasonboard.com>","date":"2020-02-18T01:05:57","subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Feb 17, 2020 at 03:39:41PM +0000, Kieran Bingham wrote:\n> Utilise the QStandardPaths::PicturesLocation as a starting point for\n> saving images from qcam.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/main_window.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 29eaba8454f8..09e4bfc11300 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -17,6 +17,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n> void MainWindow::saveImageAs()\n> {\n> \tQImage image = viewfinder_->getCurrentImage();\n> +\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n\nQStandardPaths::standardLocations() sorts the result from high to low\npriority, shouldn't we thus pick the first entry ? How about using\nQStandardPaths::writableLocation() instead ?\n\n> \n> -\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n> +\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n> \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n> \n> \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DE2A61A44\n\tfor ;\n\tTue, 18 Feb 2020 02:06:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 065B2504;\n\tTue, 18 Feb 2020 02:06:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581987975;\n\tbh=LO8VNkkExpVxBgE9652juoaO1tYYemytEHNXm4tf1Pg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l3Va/xLJJOkD6Vpk06ld6RAbji0+m8UDvkTT18bS2cG/nyNyM8ZdO4FoU2gKWKTiU\n\tVgn+fAX9vTZE0uAUv4hPo45lNxBxkxj8L4I5XQryGTvOiZ91NkiP2hLsC1m7LfYmCS\n\tDiqXqmY1SBF9A0NiAt02GPaeikAdIgJjqWrvANxg=","Date":"Tue, 18 Feb 2020 03:05:57 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200218010556.GO4830@pendragon.ideasonboard.com>","References":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 01:06:15 -0000"}},{"id":3798,"web_url":"https://patchwork.libcamera.org/comment/3798/","msgid":"","date":"2020-02-18T09:02:18","subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/02/2020 01:05, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Feb 17, 2020 at 03:39:41PM +0000, Kieran Bingham wrote:\n>> Utilise the QStandardPaths::PicturesLocation as a starting point for\n>> saving images from qcam.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/qcam/main_window.cpp | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 29eaba8454f8..09e4bfc11300 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -17,6 +17,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>> @@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n>> void MainWindow::saveImageAs()\n>> {\n>> \tQImage image = viewfinder_->getCurrentImage();\n>> +\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n> \n> QStandardPaths::standardLocations() sorts the result from high to low\n> priority, shouldn't we thus pick the first entry ? How about using\n> QStandardPaths::writableLocation() instead ?\n\n\nOk, indeed I see it returns arrays like the following on Linux:\n\n> FontsLocation\t\"~/.fonts\", \"~/.local/share/fonts\", \"/usr/local/share/fonts\", \"/usr/share/fonts\"\n> ApplicationsLocation\t\"~/.local/share/applications\", \"/usr/local/share/applications\", \"/usr/share/applications\"\n> MusicLocation\t\"~/Music\"\n> MoviesLocation\t\"~/Videos\"\n> PicturesLocation\t\"~/Pictures\"\n\n\nSo for PicturesLocation first() == last() anyway :-)\n\nBut I'm fine with QStandardPaths::writableLocation(), and that reduces\nthe line length.\n\n\n> \n>> \n>> -\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n>> +\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n>> \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n>> \n>> \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BBDC61D61\n\tfor ;\n\tTue, 18 Feb 2020 10:02:22 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88E042F9;\n\tTue, 18 Feb 2020 10:02:21 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582016541;\n\tbh=JEGWJhZS9stDWIkXksv0ydHOIcnLvMXi0k8i+RsxKes=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=sZllx8tLWMlCMYxlNiNDqvWpd2XyKNqQYJfAm+lDnuepQZOnsjFHGVFGcneLbJp7y\n\tbiyOKJcwBvs+vcDikzBvbFIvu5+iiEE8NLV6ofLd67fdDhtRFMqRU+A7TmJQhVAvDc\n\tlLKzqdl6vdc6pb6exm10/9WtlGkrAgXxlnQVaA+I=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>\n\t<20200218010556.GO4830@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 18 Feb 2020 09:02:18 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200218010556.GO4830@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 09:02:22 -0000"}},{"id":3800,"web_url":"https://patchwork.libcamera.org/comment/3800/","msgid":"<20200218092054.GA4828@pendragon.ideasonboard.com>","date":"2020-02-18T09:20:54","subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Feb 18, 2020 at 09:02:18AM +0000, Kieran Bingham wrote:\n> On 18/02/2020 01:05, Laurent Pinchart wrote:\n> > On Mon, Feb 17, 2020 at 03:39:41PM +0000, Kieran Bingham wrote:\n> >> Utilise the QStandardPaths::PicturesLocation as a starting point for\n> >> saving images from qcam.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/qcam/main_window.cpp | 4 +++-\n> >> 1 file changed, 3 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> >> index 29eaba8454f8..09e4bfc11300 100644\n> >> --- a/src/qcam/main_window.cpp\n> >> +++ b/src/qcam/main_window.cpp\n> >> @@ -17,6 +17,7 @@\n> >> #include \n> >> #include \n> >> #include \n> >> +#include \n> >> #include \n> >> #include \n> >> #include \n> >> @@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n> >> void MainWindow::saveImageAs()\n> >> {\n> >> \tQImage image = viewfinder_->getCurrentImage();\n> >> +\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n> > \n> > QStandardPaths::standardLocations() sorts the result from high to low\n> > priority, shouldn't we thus pick the first entry ? How about using\n> > QStandardPaths::writableLocation() instead ?\n> \n> Ok, indeed I see it returns arrays like the following on Linux:\n> \n> > FontsLocation\t\"~/.fonts\", \"~/.local/share/fonts\", \"/usr/local/share/fonts\", \"/usr/share/fonts\"\n> > ApplicationsLocation\t\"~/.local/share/applications\", \"/usr/local/share/applications\", \"/usr/share/applications\"\n> > MusicLocation\t\"~/Music\"\n> > MoviesLocation\t\"~/Videos\"\n> > PicturesLocation\t\"~/Pictures\"\n> \n> So for PicturesLocation first() == last() anyway :-)\n> \n> But I'm fine with QStandardPaths::writableLocation(), and that reduces\n> the line length.\n\nWith that change,\n\nReviewed-by: Laurent Pinchart \n\n> >> \n> >> -\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n> >> +\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n> >> \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n> >> \n> >> \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1913461D61\n\tfor ;\n\tTue, 18 Feb 2020 10:21:13 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99B6A2F9;\n\tTue, 18 Feb 2020 10:21:12 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582017672;\n\tbh=OVGWQX2O8YZR6dHS1ikv6Ed3ZAtTIYX1ml72oKKNBhw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OcWT1BK1EVqbucfbSAynz0fK+5P+oAP3kReugjgBrAnqbXeVzgzlQ4+IyG/L0Hzqm\n\tzU86XTaIXxYKpMNCUG5MimuKLGWiQyb9EldMcRi2xMwBcb0JwsHB9fMXc2WSN3VQyP\n\tFVTBLfLKAP1K9BffPRnAFOJ+NO/5NNtX+7ZhnvGw=","Date":"Tue, 18 Feb 2020 11:20:54 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200218092054.GA4828@pendragon.ideasonboard.com>","References":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>\n\t<20200218010556.GO4830@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 09:21:13 -0000"}},{"id":3814,"web_url":"https://patchwork.libcamera.org/comment/3814/","msgid":"<20200218202530.GE1016123@oden.dyn.berto.se>","date":"2020-02-18T20:25:30","subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your patch.\n\nOn 2020-02-17 15:39:41 +0000, Kieran Bingham wrote:\n> Utilise the QStandardPaths::PicturesLocation as a starting point for\n> saving images from qcam.\n\nI feel applications that use these default locations for file types are \nannoying and anti the *NIX way of working, which to me is to default all \ninteractions to the current working directory.\n\nI don't feel strongly about this so I won't block this change just want \nto voice that ;-)\n\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/main_window.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 29eaba8454f8..09e4bfc11300 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -17,6 +17,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n> void MainWindow::saveImageAs()\n> {\n> \tQImage image = viewfinder_->getCurrentImage();\n> +\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n> \n> -\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n> +\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n> \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n> \n> \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3213B61F5F\n\tfor ;\n\tTue, 18 Feb 2020 21:25:32 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id m30so15490086lfp.8\n\tfor ;\n\tTue, 18 Feb 2020 12:25:32 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\t5sm3135828lju.69.2020.02.18.12.25.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 18 Feb 2020 12:25:30 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=unQVTeJWHYQ2fXJIj1mgQOsOHmBDWPc4p4GjOryqqkE=;\n\tb=exxSh8i+bJ9F3aq9ro7CNjLyYwwizarWnV+GmW2AMs5E+4oe0iyNnZwtpvDP7S30/8\n\tbiZg7vvTleagg44nWtqSKh6JerMH/TA76EU6/sogLmdDqbH254B9t4XfHcVW00qmnoPd\n\tobhnv7knQmR5DBRsdPk2hQWChsQHa73fcU0RnC+UF2JgH9euNMXALRMVDMJ2xbtViTtm\n\tdnntXkzq6HZMGSxHHJc6ZMHQsgwnXB8ELxOMyQOL/drRs7Lg2h4YOHQxSlOcofkZ3Nc/\n\tSGdP2c6vmjfYp687aB/i4AuzOdVOBwZ7UecswzpDyIykwwoGs5LFSlM1lYkPTgSfu/DI\n\tL2/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=unQVTeJWHYQ2fXJIj1mgQOsOHmBDWPc4p4GjOryqqkE=;\n\tb=cc6I9aDmVzImYCI+010TUMTvX43tHPqps2m8BPc2Ecsg/C6HxLq/2STjMtNa66xAvr\n\tFdHq4ZhzfHiPhb4txQrU8ytgTxz+DDLVzNMr3KjU6A3Wnyp1PbdBt5S083dUczCsSkSC\n\tkhxrkvEaMCqZxN5Nmi2BGNoyOevBGnTQrZkgYQSv0UVXIr7xxg5xWpMRqGnaxOraa8vR\n\ttxIMCANn5PheNlZfHrp30+5iH6fY6XfN2J8EMzr8zZmBXdtzbuOrj+wVcupZxkSeZaKb\n\td61ltstHME9bTlzePTqLj+W0/yrQXmL2zWWYHBMBBSisHZaak6rdOjQGtcfX2BuP2mha\n\tVKVg==","X-Gm-Message-State":"APjAAAW3yNvoEdSvM/EQfFl9D58WmOX2tY/5fjgMjO7wRipEJmpMAet3\n\toGXPpbFUy6WCSiTjoCbM6E8a1Q==","X-Google-Smtp-Source":"APXvYqwwhL0BchTrUh2gnO4EFOcjd/KAatJB/GGhX/uUGyDcGPekBtXeL5q1vigLI5gMRKcWVDZNxQ==","X-Received":"by 2002:a19:4a92:: with SMTP id\n\tx140mr11662219lfa.29.1582057531325; \n\tTue, 18 Feb 2020 12:25:31 -0800 (PST)","Date":"Tue, 18 Feb 2020 21:25:30 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200218202530.GE1016123@oden.dyn.berto.se>","References":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 20:25:32 -0000"}},{"id":3818,"web_url":"https://patchwork.libcamera.org/comment/3818/","msgid":"<0d03fee6-725a-aa55-1bf6-9de2660d2327@ideasonboard.com>","date":"2020-02-19T09:23:04","subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 18/02/2020 20:25, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> Thanks for your patch.\n> \n> On 2020-02-17 15:39:41 +0000, Kieran Bingham wrote:\n>> Utilise the QStandardPaths::PicturesLocation as a starting point for\n>> saving images from qcam.\n> \n> I feel applications that use these default locations for file types are \n> annoying and anti the *NIX way of working, which to me is to default all \n> interactions to the current working directory.\n\nMy only issue with that, is\n\n\"What is the current working directory for an application started from a\nGUI interface of an 'installed' qcam?\" (/usr/bin/?)\n\nIn my instance, I have added QCam to the gnome menu. So now when I\nlaunch it, I want the output saved in a better default location.\n\n\n\n> I don't feel strongly about this so I won't block this change just want \n> to voice that ;-)\n\nI understand, heard, but I'm afraid I disagree in this instance :-)\n\n--\nKieran\n\n\n> \n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/qcam/main_window.cpp | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 29eaba8454f8..09e4bfc11300 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -17,6 +17,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>> @@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n>> void MainWindow::saveImageAs()\n>> {\n>> \tQImage image = viewfinder_->getCurrentImage();\n>> +\tQString defaultPath = QStandardPaths::standardLocations(QStandardPaths::PicturesLocation).last();\n>> \n>> -\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n>> +\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n>> \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n>> \n>> \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n>> -- \n>> 2.20.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 034CE60434\n\tfor ;\n\tWed, 19 Feb 2020 10:23:08 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30EB82F9;\n\tWed, 19 Feb 2020 10:23:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582104188;\n\tbh=2KAVX9zPB2gGMuXMDG4dyQYJLk02qNVD/HsLFP+6F+s=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=FEKSGvXI12K1QzPTOOHappSUfYdPO7ATvjD92O1HJpx8qW+moB6EBAj9l4ajJDx41\n\tbyTKCZqn3pFS/XVJaMZbdHIZxhFaN6tfnMdwv73+h8vCAHgDqTE9NUbpHwLf1Yz+I+\n\tEbUwNrRWx8mT91vK0gHNS6WxQPCR2FbMpA1CIUeo=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Cc":"libcamera devel ","References":"<20200217153941.20713-1-kieran.bingham@ideasonboard.com>\n\t<20200218202530.GE1016123@oden.dyn.berto.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0d03fee6-725a-aa55-1bf6-9de2660d2327@ideasonboard.com>","Date":"Wed, 19 Feb 2020 09:23:04 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200218202530.GE1016123@oden.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Use standard PicturesLocation\n\tpath for capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Feb 2020 09:23:09 -0000"}}]