{"id":2844,"url":"https://patchwork.libcamera.org/api/patches/2844/?format=json","web_url":"https://patchwork.libcamera.org/patch/2844/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200217151746.30285-1-naush@raspberrypi.com>","date":"2020-02-17T15:17:46","name":"[libcamera-devel] libcamera: ipa: Pass the sensor name and selected mode to the ipa","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bbc7ec60487cdc199b1f97b5ecfe78989d1758f4","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2844/mbox/","series":[{"id":680,"url":"https://patchwork.libcamera.org/api/series/680/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=680","date":"2020-02-17T15:17:46","name":"[libcamera-devel] libcamera: ipa: Pass the sensor name and selected mode to the ipa","version":1,"mbox":"https://patchwork.libcamera.org/series/680/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2844/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2844/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n\t[IPv6:2a00:1450:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08EEF61932\n\tfor ;\n\tMon, 17 Feb 2020 16:19:49 +0100 (CET)","by mail-wr1-x444.google.com with SMTP id z7so20167857wrl.13\n\tfor ;\n\tMon, 17 Feb 2020 07:19:48 -0800 (PST)","from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tf1sm1403513wro.85.2020.02.17.07.19.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 07:19:48 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xHNEuvlAmLf8hzlm1/ONVD954FpewJUdS/fkQArK4mE=;\n\tb=s7Ub+oTjyt9ygIvhtelnC4SXOp+FeNa1bdGn2c0dvTpvKEEKfHt/Bj9wvXn28lcRHy\n\t49ZTehVjUqFYg1h/qyboF44QYmkRLMtBJdm60mJZz2iFiaQv6FYC0kkKjSyWfBQP1aJ4\n\t1O2ANapnRqe3t7Hz4e/nkRHoT3O4AKYFfcB4UaVn7WGxIRBKJtHEpIL7D6pQhdKO/JR+\n\tvp3YVU7fq/a/GfOZZmqdlAr/RpM9aGxOlN0sjzvPmOwPceLHfX7PJkmDIk650GjVe1KC\n\tTVRnpDeM37U/eFeOJBLDfI6bE2ZQJIKHi9DS/DL5janJCE9eCFVB1QK433TrIbOcPsQh\n\tl+Ow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=xHNEuvlAmLf8hzlm1/ONVD954FpewJUdS/fkQArK4mE=;\n\tb=G4UhCwwdYGSevolpnNmhouplBrEiE6b4ERECg6p9ILQarGfcbJh369PRg6LYQ7QUmQ\n\taSbPfqAnHorI2Pifv29w+aQYfDZOJQ+9TL5fcbx8mnrGBbNVguAqYivxENObqOY79gSW\n\tZZ3oqFKGjDrzqPe6hSejrm+zgw1RsBWn9ewClNAAVNP2NIyCfcIHnRWZW2qzzkdrpUkz\n\tc/raxmT8NvZS0T/gPMP0gUzF/DYG1KOzkpInI8mF9sEJYRazxOIdMhECfEpHdbGMihio\n\tEswTxC5DfHnTBiauqxTPyOsuNDeasGiCF8Bu7fpCN27mSGBoMsyDKps9QtjWzvi3scAO\n\tZtvg==","X-Gm-Message-State":"APjAAAUNGJnmh2wfBMTFsHmh6oJpj4TmPxwz623R28aUOQ1ch6a+Umt0\n\tNjOdZA5wrrHFNafTuqgKojTDHHiFTvogBg==","X-Google-Smtp-Source":"APXvYqwp3JI2MOfsgvrUyfeLVd5X9MnOjqVixAXFgJXsRYGMUXw7wqXp095/SXdR4HtdsNjHSroq1Q==","X-Received":"by 2002:adf:e2cf:: with SMTP id\n\td15mr22955829wrj.225.1581952788535; \n\tMon, 17 Feb 2020 07:19:48 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tNaushir Patuck ","Date":"Mon, 17 Feb 2020 15:17:46 +0000","Message-Id":"<20200217151746.30285-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","Subject":"[libcamera-devel] [PATCH] libcamera: ipa: Pass the sensor name and\n\tselected mode to the ipa","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 15:19:49 -0000"},"content":"The ipa needs to know the sensor name to choose the per-camera tuning\nsettings. It also needs the sensor mode which can be, and is usually\ndifferent to the user configured mode. This is required to set any table\nbased parameters which rely on the sensor programmed mode.\n\nSigned-off-by: Naushir Patuck \n---\n include/ipa/ipa_interface.h | 3 +++\n src/ipa/libipa/ipa_interface_wrapper.cpp | 8 ++++++++\n 2 files changed, 11 insertions(+)","diff":"diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h\nindex 229d112..6e4b3ef 100644\n--- a/include/ipa/ipa_interface.h\n+++ b/include/ipa/ipa_interface.h\n@@ -95,12 +95,15 @@ struct ipa_context *ipaCreate();\n #include \n \n #include \"v4l2_controls.h\"\n+#include \"v4l2_videodevice.h\"\n \n namespace libcamera {\n \n struct IPAStream {\n \tunsigned int pixelFormat;\n \tSize size;\n+\tV4L2DeviceFormat deviceFormat;\n+\tconst char *cameraName;\n };\n \n struct IPABuffer {\ndiff --git a/src/ipa/libipa/ipa_interface_wrapper.cpp b/src/ipa/libipa/ipa_interface_wrapper.cpp\nindex b93c1c1..58da86d 100644\n--- a/src/ipa/libipa/ipa_interface_wrapper.cpp\n+++ b/src/ipa/libipa/ipa_interface_wrapper.cpp\n@@ -115,6 +115,14 @@ void IPAInterfaceWrapper::configure(struct ipa_context *_ctx,\n \t\tipaStreams[stream.id] = {\n \t\t\tstream.pixel_format,\n \t\t\tSize(stream.width, stream.height),\n+\t\t\t/*\n+\t\t\t * The below two fields:\n+\t\t\t *\tV4L2DeviceFormat deviceFormat;\n+\t\t\t *\tconst char *cameraName;\n+\t\t\t * must be filled by the pipeline handlers.\n+\t\t\t */\n+\t\t\t{},\n+\t\t\t\"\"\n \t\t};\n \t}\n \n","prefixes":["libcamera-devel"]}