[{"id":3786,"web_url":"https://patchwork.libcamera.org/comment/3786/","msgid":"<2d202cdd-779d-f8e6-2a2b-ebab82626de5@ideasonboard.com>","date":"2020-02-17T16:21:32","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 17/02/2020 14:26, Naushir Patuck wrote:\n> Use micro-seconds for ManualExposure. This is changed from milli-\n> seconds. The latter would not allow very low exposure times.\n> \n> Use double for ManualGain to allow fractional gain adjustments.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4befec7..33062d6 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -44,10 +44,10 @@ controls:\n> \n> - ManualExposure:\n> type: int32_t\n> - description: Specify a fixed exposure time in milli-seconds\n> + description: Specify a fixed exposure time in micro-seconds\n\nAt the moment, the only user of this control\n(PipelineHandlerUVC::processControls()) sets this directly on the V4L2\ncontrol.\n\nAs we don't yet have anything much actually testing this, it's fairly\narbitrary - so I'm certainly not against changing the units.\n\nBut we may need to consider how to map this directly at the platform.\n\nThat said - that's a job for the pipeline handlers ...\n\n\nBut perhaps we need to divide the value by 1000 in the current code at\npipeline/uvcvideo.cpp to maintain consistency.\n\t\t\t\n\n\n> - ManualGain:\n> - type: int32_t\n> - description: Specify a fixed gain parameter\n> + type: double\n> + description: Specify a fixed gain parameter.\n\n\nSame comment applies here that if this is changed, the usage in\npipeline/uvcvideo.cpp needs to be updated at the same time, so I think\nwe'll need to split this patch out to change the units and fix the\n(current) implementation for each of the controls one control at a time.\n\nBut Otherwise, I agree on the unit changes.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C557161944\n\tfor ;\n\tMon, 17 Feb 2020 17:21:35 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D7EF52A;\n\tMon, 17 Feb 2020 17:21:35 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581956495;\n\tbh=NHqcxhArG22OS5hK5QeqgXgahsz5FXytGh3wSFbw494=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=YxuCHeN5MoxWwTfncg+fQlqA0PbKiNt/59KNfQ086tlok7vmdLMnPAC5nZ+Py58qn\n\t66T8u+cReKm07RUtZnmuaQWvlR1HO5KoSH/I5H2x8WyLtpB6v0N7wPPP8roBEE74wz\n\tKkBJNgxgK1pMc7kUo4OBa2X0yE4Z/VrmakPaUtJw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200217142609.22837-1-naush@raspberrypi.com>\n\t<20200217142609.22837-3-naush@raspberrypi.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<2d202cdd-779d-f8e6-2a2b-ebab82626de5@ideasonboard.com>","Date":"Mon, 17 Feb 2020 16:21:32 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200217142609.22837-3-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 16:21:36 -0000"}},{"id":3794,"web_url":"https://patchwork.libcamera.org/comment/3794/","msgid":"<20200218004446.GL4830@pendragon.ideasonboard.com>","date":"2020-02-18T00:44:46","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Mon, Feb 17, 2020 at 04:21:32PM +0000, Kieran Bingham wrote:\n> On 17/02/2020 14:26, Naushir Patuck wrote:\n> > Use micro-seconds for ManualExposure. This is changed from milli-\n> > seconds. The latter would not allow very low exposure times.\n> > \n> > Use double for ManualGain to allow fractional gain adjustments.\n> > \n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 4befec7..33062d6 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -44,10 +44,10 @@ controls:\n> > \n> > - ManualExposure:\n> > type: int32_t\n> > - description: Specify a fixed exposure time in milli-seconds\n> > + description: Specify a fixed exposure time in micro-seconds\n> \n> At the moment, the only user of this control\n> (PipelineHandlerUVC::processControls()) sets this directly on the V4L2\n> control.\n> \n> As we don't yet have anything much actually testing this, it's fairly\n> arbitrary - so I'm certainly not against changing the units.\n> \n> But we may need to consider how to map this directly at the platform.\n> \n> That said - that's a job for the pipeline handlers ...\n> \n> But perhaps we need to divide the value by 1000 in the current code at\n> pipeline/uvcvideo.cpp to maintain consistency.\n\nUVC expresses the exposure time in units of 100µs (I mentioned 100ns\nearlier on IRC, that was a mistake, it's the unit for UVC frame\nintervals, not exposure time), so both would be wrong :-) We sure need\nto fix the UVC pipeline handler, but it doesn't need to be part of this\npatch.\n\n> > - ManualGain:\n> > - type: int32_t\n> > - description: Specify a fixed gain parameter\n> > + type: double\n> > + description: Specify a fixed gain parameter.\n> \n> Same comment applies here that if this is changed, the usage in\n> pipeline/uvcvideo.cpp needs to be updated at the same time, so I think\n> we'll need to split this patch out to change the units and fix the\n> (current) implementation for each of the controls one control at a time.\n\nUVC doesn't specify units for gain. One option would be to map the\ndefault value to 1.0 and consider the gain range to be linear.\n\n> But Otherwise, I agree on the unit changes.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0795961A44\n\tfor ;\n\tTue, 18 Feb 2020 01:45:06 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0929C1220;\n\tTue, 18 Feb 2020 01:45:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581986705;\n\tbh=7G1Pu2YDHbsZQ7MivYtREjztm6kDccqmzydp8084JgA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WAANRR2sY5Tic3VST+uQ5jHJmVuDYEjiAJBkDI4lOXlc8NY9Ilt0nXHhf8sitj4EI\n\thjMUYiGr4Z43z2UaiVAGyzSZV4eHHOrLhjPNBtvyT5b3zFIgMZ/ojIg/hie/alJuRi\n\tW6tPHkcPQl1VPxNcYdGC0a2qHlaBSwRClWaNKSrI=","Date":"Tue, 18 Feb 2020 02:44:46 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200218004446.GL4830@pendragon.ideasonboard.com>","References":"<20200217142609.22837-1-naush@raspberrypi.com>\n\t<20200217142609.22837-3-naush@raspberrypi.com>\n\t<2d202cdd-779d-f8e6-2a2b-ebab82626de5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2d202cdd-779d-f8e6-2a2b-ebab82626de5@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 00:45:06 -0000"}},{"id":3799,"web_url":"https://patchwork.libcamera.org/comment/3799/","msgid":"","date":"2020-02-18T09:20:26","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nOn Tue, 18 Feb 2020 at 00:45, Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> On Mon, Feb 17, 2020 at 04:21:32PM +0000, Kieran Bingham wrote:\n> > On 17/02/2020 14:26, Naushir Patuck wrote:\n> > > Use micro-seconds for ManualExposure. This is changed from milli-\n> > > seconds. The latter would not allow very low exposure times.\n> > >\n> > > Use double for ManualGain to allow fractional gain adjustments.\n> > >\n> > > Signed-off-by: Naushir Patuck \n> > > ---\n> > > src/libcamera/control_ids.yaml | 6 +++---\n> > > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > index 4befec7..33062d6 100644\n> > > --- a/src/libcamera/control_ids.yaml\n> > > +++ b/src/libcamera/control_ids.yaml\n> > > @@ -44,10 +44,10 @@ controls:\n> > >\n> > > - ManualExposure:\n> > > type: int32_t\n> > > - description: Specify a fixed exposure time in milli-seconds\n> > > + description: Specify a fixed exposure time in micro-seconds\n> >\n> > At the moment, the only user of this control\n> > (PipelineHandlerUVC::processControls()) sets this directly on the V4L2\n> > control.\n> >\n> > As we don't yet have anything much actually testing this, it's fairly\n> > arbitrary - so I'm certainly not against changing the units.\n> >\n> > But we may need to consider how to map this directly at the platform.\n> >\n> > That said - that's a job for the pipeline handlers ...\n> >\n> > But perhaps we need to divide the value by 1000 in the current code at\n> > pipeline/uvcvideo.cpp to maintain consistency.\n>\n> UVC expresses the exposure time in units of 100µs (I mentioned 100ns\n> earlier on IRC, that was a mistake, it's the unit for UVC frame\n> intervals, not exposure time), so both would be wrong :-) We sure need\n> to fix the UVC pipeline handler, but it doesn't need to be part of this\n> patch.\n>\n\nAgreed, my V2 patchset will have a commit to address both exposure and gain.\n\n> > > - ManualGain:\n> > > - type: int32_t\n> > > - description: Specify a fixed gain parameter\n> > > + type: double\n> > > + description: Specify a fixed gain parameter.\n> >\n> > Same comment applies here that if this is changed, the usage in\n> > pipeline/uvcvideo.cpp needs to be updated at the same time, so I think\n> > we'll need to split this patch out to change the units and fix the\n> > (current) implementation for each of the controls one control at a time.\n>\n> UVC doesn't specify units for gain. One option would be to map the\n> default value to 1.0 and consider the gain range to be linear.\n>\n> > But Otherwise, I agree on the unit changes.\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n\nRegards,\nNaush","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BA7561D61\n\tfor ;\n\tTue, 18 Feb 2020 10:20:42 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id z26so13927241lfg.13\n\tfor ;\n\tTue, 18 Feb 2020 01:20:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=GTD5YfF95x71VoWe3mn9QbD3/BjFMo2u6TwiMwTUI94=;\n\tb=G0XTVwQO/D8cgJma47wSSota2tGoaYw+j4I0kqXB8IOJudMX4JCyWAw7LkaQ0pGXj+\n\tXqFHjbQS5Og4Uzn8VmoUBz9oH2Ecwihkki9phgMD54m2osc6ukxkP1pXd8fI81qbM7pY\n\tOStyHI/KAqRJw1f3jN7FbI5nC0LFklU8VTfRdHgulk3aBLPvgG9lS7nm8tnYATiBNtML\n\tNWREYvTcgVLEiqF1rSmiqBqC9svM5xYw0vbjSfx3+uSYvDpQx3dXKH2dtPT+PXxdfS5J\n\tEk1OCU9XN/lSQH8W0uwoBdaDMs78atj3k/MlhCjKqtzplN1L+0AycyVkVVSUZP48OCrl\n\tIbEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=GTD5YfF95x71VoWe3mn9QbD3/BjFMo2u6TwiMwTUI94=;\n\tb=WVXF6aTON3wh6J0WH3snAe91E2VQFwS2FPX+/yPHFicxCZUGn1MhCjEbuJH/7fXXHV\n\tgnIkSbGAqZqhYLV4xY2bqH8/w/pWQMeLfB6HAvwxgZcKQeJZ77Yb2AK3HlXy8RYZCP28\n\tUv+niXRwQHfGnS4OSK6qLryPVN7griS+l6gyHzgKPwKCxOoOUxuY6oIi+cnp6CSvipvi\n\tYFJD0WxKzDveRrrANGjaA0MTO/5Dy/JVbob6Od4l4OojiQrd8Y5ZrNNFTZ3XrXc39cs6\n\tsXAsSwW5jSObNYrSRMwMiwZEtM5xjCIAwaxiMeKxKxUbx6IziHmm7NRxFXsovV3+zQgl\n\tfR6g==","X-Gm-Message-State":"APjAAAV+l5ZUaqHimC0obeWU8xz1E6PLCJiIg0cJnjhZIgMYy/HkIWUV\n\tYtQJp4R9I442wbcrhw+pVTFWetJX0HSDHMslxraE0Q==","X-Google-Smtp-Source":"APXvYqzrXelteLF44tU6jFtT3pqYGYcB3gPSnEK5sppygCUjMqXbipLujPAk+Vo9KAWFeeldddJBmRGGvMMRjXynzv8=","X-Received":"by 2002:a05:6512:284:: with SMTP id\n\tj4mr10100317lfp.109.1582017641659; \n\tTue, 18 Feb 2020 01:20:41 -0800 (PST)","MIME-Version":"1.0","References":"<20200217142609.22837-1-naush@raspberrypi.com>\n\t<20200217142609.22837-3-naush@raspberrypi.com>\n\t<2d202cdd-779d-f8e6-2a2b-ebab82626de5@ideasonboard.com>\n\t<20200218004446.GL4830@pendragon.ideasonboard.com>","In-Reply-To":"<20200218004446.GL4830@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Tue, 18 Feb 2020 09:20:26 +0000","Message-ID":"","To":"Laurent Pinchart ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 09:20:42 -0000"}}]