[{"id":3779,"web_url":"https://patchwork.libcamera.org/comment/3779/","msgid":"<20200217114609.GQ3013231@oden.dyn.berto.se>","date":"2020-02-17T11:46:09","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-02-17 13:03:24 +0200, Laurent Pinchart wrote:\n> If one device fails to enumerate, which isn't supposed to happen under\n> normal conditions, both the sysfs and the udev enumerators stop\n> enumeration of further devices. This potentially prevents working\n> devices from being detected and handled. Fix it by skipping the faulty\n> device.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes since v1:\n> \n> - Add more warning messages to DeviceEnumeratorUdev\n> - Use media->deviceNode() and print the driver name where appropriate\n> ---\n> src/libcamera/device_enumerator_sysfs.cpp | 16 +++++++--------\n> src/libcamera/device_enumerator_udev.cpp | 25 ++++++++++++++++-------\n> 2 files changed, 26 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> index ad26affb38a3..197ca235879b 100644\n> --- a/src/libcamera/device_enumerator_sysfs.cpp\n> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n> {\n> \tstruct dirent *ent;\n> \tDIR *dir;\n> -\tint ret = 0;\n> \n> \tstatic const char * const sysfs_dirs[] = {\n> \t\t\"/sys/subsystem/media/devices\",\n> @@ -74,14 +73,15 @@ int DeviceEnumeratorSysfs::enumerate()\n> \t\t}\n> \n> \t\tstd::shared_ptr media = createDevice(devnode);\n> -\t\tif (!media) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> -\t\t}\n> +\t\tif (!media)\n> +\t\t\tcontinue;\n> \n> \t\tif (populateMediaDevice(media) < 0) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to populate media device \"\n> +\t\t\t\t<< media->deviceNode()\n> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> +\t\t\tcontinue;\n> \t\t}\n> \n> \t\taddDevice(media);\n> @@ -89,7 +89,7 @@ int DeviceEnumeratorSysfs::enumerate()\n> \n> \tclosedir(dir);\n> \n> -\treturn ret;\n> +\treturn 0;\n> }\n> \n> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index b2c5fd221dcd..87638c59761c 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -82,8 +82,15 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n> \t\t\treturn -ENODEV;\n> \n> \t\tint ret = populateMediaDevice(media);\n> -\t\tif (ret == 0)\n> -\t\t\taddDevice(media);\n> +\t\tif (ret < 0) {\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to populate media device \"\n> +\t\t\t\t<< media->deviceNode()\n> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> +\t\t\treturn ret;\n> +\t\t}\n> +\n> +\t\taddDevice(media);\n> \t\treturn 0;\n> \t}\n> \n> @@ -141,14 +148,18 @@ int DeviceEnumeratorUdev::enumerate()\n> \t\tdevnode = udev_device_get_devnode(dev);\n> \t\tif (!devnode) {\n> \t\t\tudev_device_unref(dev);\n> -\t\t\tret = -ENODEV;\n> -\t\t\tgoto done;\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to get device node for '\"\n> +\t\t\t\t<< syspath << \"', skipping\";\n> +\t\t\tcontinue;\n> \t\t}\n> \n> -\t\tret = addUdevDevice(dev);\n> +\t\tif (addUdevDevice(dev) < 0)\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to add device for '\"\n> +\t\t\t\t<< syspath << \"', skipping\";\n> +\n> \t\tudev_device_unref(dev);\n> -\t\tif (ret < 0)\n> -\t\t\tbreak;\n> \t}\n> \n> done:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C14936275F\n\tfor ;\n\tMon, 17 Feb 2020 12:46:11 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id b15so11662681lfc.4\n\tfor ;\n\tMon, 17 Feb 2020 03:46:11 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\ty66sm195957lfa.53.2020.02.17.03.46.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 03:46:10 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=+fvg3LPOOMTtBqDoRX/4mLuCpfkVArusoFQu/7IsSw4=;\n\tb=VKK6c2QCVcq3YbEoU/nGVtluEMpe53IqhwDU9Mpvj8bM/ONjxolxxU/t4aieCeCZca\n\t7VFDJGtfn7z7aF2w0/f1f8JZZE6YoztZdwqPDA5+jnwSPXSAf3aZKVxCU2DD4WRB7+Mh\n\tfi6QJXY9Yn9spBK+OvVHuF9nfnge5uGq55aFXDVwYauF1kV/Ysjc44j5NcgnWbAQxlSD\n\tZq4DItGiWkZ7ZnQVG4eHOuo63UxW6IWsofgsf4icnj5Z0TUDetck6jOBilE7MuyFPvOu\n\tJ4nXoagncg3zQ/YlZRmA47768VyOKfYR++cjK4JAtvcq6kaClUZLAM8wJp4Pl8lMOIDr\n\tD/Mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=+fvg3LPOOMTtBqDoRX/4mLuCpfkVArusoFQu/7IsSw4=;\n\tb=pE1zXOH+QNo0aeMQyzIqLVUfC3RctWWLmuCjCwqJ9cO0jNJe5VfE0nHIywwuxtRcCf\n\tV/XBGSgM+QRnvAT3CIY6IhurrI/KoLsxOB3O8fRS8FObKkWu1WpMiE0/aSalnJqUD/MX\n\tHocGefK/3EoAKSNhhVe/qMsLm8bOT8hmLnAJlV2c8zPLuLZ3KRxbqGAZppf6BsCBhjyY\n\trk8FKpv9SmODQ4YqIPYTWxgimMk+ny6BW+Amf9KlDHEGYfyG4f9nz4TzQUYIqiQmxYMS\n\t73p/GHnZ9obiFKA3X6lZvc2xAVB1y7djPLWNwLGU9SvalYlAe0ap0M7cnZ2q5GWXkyUd\n\tp7lA==","X-Gm-Message-State":"APjAAAUhh8i5C5If4dzVI/aMetYtLQZnbEw55Eq1l3dkFvObuG//a41F\n\tuRVO6bJnDj3bxMAvfR7xIP9KdA==","X-Google-Smtp-Source":"APXvYqx0VfgFDk0AHRtgwj9iKUKkJMXycFH0QpKGZBHgpu5VUWR3+5Ak5MWZcBTRFO6YxQdGUnyhZw==","X-Received":"by 2002:a05:6512:687:: with SMTP id\n\tt7mr8093996lfe.30.1581939970943; \n\tMon, 17 Feb 2020 03:46:10 -0800 (PST)","Date":"Mon, 17 Feb 2020 12:46:09 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200217114609.GQ3013231@oden.dyn.berto.se>","References":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 11:46:11 -0000"}},{"id":3781,"web_url":"https://patchwork.libcamera.org/comment/3781/","msgid":"<0056b3b1-451f-c9d0-ecbf-780ddf68d8f5@ideasonboard.com>","date":"2020-02-17T11:56:42","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/02/2020 11:03, Laurent Pinchart wrote:\n> If one device fails to enumerate, which isn't supposed to happen under\n> normal conditions, both the sysfs and the udev enumerators stop\n> enumeration of further devices. This potentially prevents working\n> devices from being detected and handled. Fix it by skipping the faulty\n> device.\n> \n> Signed-off-by: Laurent Pinchart \n\nThe addition of the prints for /which/ device fails don't help my use\ncase as I fail before getting to those prints\n(DeviceEnumerator::createDevice)\n\nWe can't add any further introspection of the MediaDevice in\n::createDevice anyway, so that can't be extended to say more information\nabout the device.\n\nMediaDevice::populate() however is painful, as it discards the actual\nreturn value of the MEDIA_IOC_DEVICE_INFO, and\nMEDIA_IOC_G_TOPOLOGY,ioctls in event of those failing and instead\nreturns -EINVAL ...\n\nBut that is not a topic for /this/ patch.\n\n\nReviewed-by: Kieran Bingham \n(and still Tested-by: KB too if you desire)\n\n\n> ---\n> Changes since v1:\n> \n> - Add more warning messages to DeviceEnumeratorUdev\n> - Use media->deviceNode() and print the driver name where appropriate\n> ---\n> src/libcamera/device_enumerator_sysfs.cpp | 16 +++++++--------\n> src/libcamera/device_enumerator_udev.cpp | 25 ++++++++++++++++-------\n> 2 files changed, 26 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> index ad26affb38a3..197ca235879b 100644\n> --- a/src/libcamera/device_enumerator_sysfs.cpp\n> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n> {\n> \tstruct dirent *ent;\n> \tDIR *dir;\n> -\tint ret = 0;\n> \n> \tstatic const char * const sysfs_dirs[] = {\n> \t\t\"/sys/subsystem/media/devices\",\n> @@ -74,14 +73,15 @@ int DeviceEnumeratorSysfs::enumerate()\n> \t\t}\n> \n> \t\tstd::shared_ptr media = createDevice(devnode);\n> -\t\tif (!media) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> -\t\t}\n> +\t\tif (!media)\n> +\t\t\tcontinue;\n> \n> \t\tif (populateMediaDevice(media) < 0) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to populate media device \"\n> +\t\t\t\t<< media->deviceNode()\n> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> +\t\t\tcontinue;\n> \t\t}\n> \n> \t\taddDevice(media);\n> @@ -89,7 +89,7 @@ int DeviceEnumeratorSysfs::enumerate()\n> \n> \tclosedir(dir);\n> \n> -\treturn ret;\n> +\treturn 0;\n> }\n> \n> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index b2c5fd221dcd..87638c59761c 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -82,8 +82,15 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n> \t\t\treturn -ENODEV;\n> \n\nInterestingly - actually in my testing of the failures, I don't get to\nthe code below.\n\nThe failure occurs during media->populate() which is called from\ncreateDevice, which has just returned -ENODEV above here.\n\n\nAnd while it is valid to call media->driver() below - it's not valid\nhere, as the created device didn't get created :-D\n\n\n\n> \t\tint ret = populateMediaDevice(media);\n> -\t\tif (ret == 0)\n> -\t\t\taddDevice(media);\n> +\t\tif (ret < 0) {\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to populate media device \"\n> +\t\t\t\t<< media->deviceNode()\n> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> +\t\t\treturn ret;\n\n\n\n> +\t\t}\n> +\n> +\t\taddDevice(media);\n> \t\treturn 0;\n> \t}\n> \n> @@ -141,14 +148,18 @@ int DeviceEnumeratorUdev::enumerate()\n> \t\tdevnode = udev_device_get_devnode(dev);\n> \t\tif (!devnode) {\n> \t\t\tudev_device_unref(dev);\n> -\t\t\tret = -ENODEV;\n> -\t\t\tgoto done;\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to get device node for '\"\n> +\t\t\t\t<< syspath << \"', skipping\";\n> +\t\t\tcontinue;\n> \t\t}\n> \n> -\t\tret = addUdevDevice(dev);\n> +\t\tif (addUdevDevice(dev) < 0)\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to add device for '\"\n> +\t\t\t\t<< syspath << \"', skipping\";\n> +\n> \t\tudev_device_unref(dev);\n> -\t\tif (ret < 0)\n> -\t\t\tbreak;\n> \t}\n> \n> done:\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0972F6259B\n\tfor ;\n\tMon, 17 Feb 2020 12:56:46 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D3CB52A;\n\tMon, 17 Feb 2020 12:56:45 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581940605;\n\tbh=d4S5X/t5j68Wcxm2kZl9EzrlOeHM6K5m6hG8EH56JJE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=enq+xcpCnytP/rYD+W+9BU3FoioIHUfzZ8dGMJ8T7fGTM0l9JrLJRPnZjUugAe7o3\n\tdktSzWDpjTonSA9RxDGfhzcG+Dlq7H8gIas16Hrw4mN28w3HX3ui29E6PnkM7vISyc\n\tqtperR/JsMOKmHeKZrSuNcZqHVCO5kwmctEq83HA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0056b3b1-451f-c9d0-ecbf-780ddf68d8f5@ideasonboard.com>","Date":"Mon, 17 Feb 2020 11:56:42 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 11:56:46 -0000"}},{"id":3788,"web_url":"https://patchwork.libcamera.org/comment/3788/","msgid":"<20200217232402.GG4830@pendragon.ideasonboard.com>","date":"2020-02-17T23:24:02","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Feb 17, 2020 at 11:56:42AM +0000, Kieran Bingham wrote:\n> On 17/02/2020 11:03, Laurent Pinchart wrote:\n> > If one device fails to enumerate, which isn't supposed to happen under\n> > normal conditions, both the sysfs and the udev enumerators stop\n> > enumeration of further devices. This potentially prevents working\n> > devices from being detected and handled. Fix it by skipping the faulty\n> > device.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> The addition of the prints for /which/ device fails don't help my use\n> case as I fail before getting to those prints\n> (DeviceEnumerator::createDevice)\n> \n> We can't add any further introspection of the MediaDevice in\n> ::createDevice anyway, so that can't be extended to say more information\n> about the device.\n\nYes, if we fail to retrieve information from the device, then we can\nhardly print it :-)\n\n> MediaDevice::populate() however is painful, as it discards the actual\n> return value of the MEDIA_IOC_DEVICE_INFO, and\n> MEDIA_IOC_G_TOPOLOGY,ioctls in event of those failing and instead\n> returns -EINVAL ...\n> \n> But that is not a topic for /this/ patch.\n\nAgreed.\n\nIt could also be useful to make MediaDevice inherit from Loggable.\n\n> Reviewed-by: Kieran Bingham \n> (and still Tested-by: KB too if you desire)\n\nAbsolutely, thank you.\n\n> > ---\n> > Changes since v1:\n> > \n> > - Add more warning messages to DeviceEnumeratorUdev\n> > - Use media->deviceNode() and print the driver name where appropriate\n> > ---\n> > src/libcamera/device_enumerator_sysfs.cpp | 16 +++++++--------\n> > src/libcamera/device_enumerator_udev.cpp | 25 ++++++++++++++++-------\n> > 2 files changed, 26 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> > index ad26affb38a3..197ca235879b 100644\n> > --- a/src/libcamera/device_enumerator_sysfs.cpp\n> > +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> > @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n> > {\n> > \tstruct dirent *ent;\n> > \tDIR *dir;\n> > -\tint ret = 0;\n> > \n> > \tstatic const char * const sysfs_dirs[] = {\n> > \t\t\"/sys/subsystem/media/devices\",\n> > @@ -74,14 +73,15 @@ int DeviceEnumeratorSysfs::enumerate()\n> > \t\t}\n> > \n> > \t\tstd::shared_ptr media = createDevice(devnode);\n> > -\t\tif (!media) {\n> > -\t\t\tret = -ENODEV;\n> > -\t\t\tbreak;\n> > -\t\t}\n> > +\t\tif (!media)\n> > +\t\t\tcontinue;\n> > \n> > \t\tif (populateMediaDevice(media) < 0) {\n> > -\t\t\tret = -ENODEV;\n> > -\t\t\tbreak;\n> > +\t\t\tLOG(DeviceEnumerator, Warning)\n> > +\t\t\t\t<< \"Failed to populate media device \"\n> > +\t\t\t\t<< media->deviceNode()\n> > +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> > +\t\t\tcontinue;\n> > \t\t}\n> > \n> > \t\taddDevice(media);\n> > @@ -89,7 +89,7 @@ int DeviceEnumeratorSysfs::enumerate()\n> > \n> > \tclosedir(dir);\n> > \n> > -\treturn ret;\n> > +\treturn 0;\n> > }\n> > \n> > int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n> > diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> > index b2c5fd221dcd..87638c59761c 100644\n> > --- a/src/libcamera/device_enumerator_udev.cpp\n> > +++ b/src/libcamera/device_enumerator_udev.cpp\n> > @@ -82,8 +82,15 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n> > \t\t\treturn -ENODEV;\n> > \n> \n> Interestingly - actually in my testing of the failures, I don't get to\n> the code below.\n> \n> The failure occurs during media->populate() which is called from\n> createDevice, which has just returned -ENODEV above here.\n> \n> And while it is valid to call media->driver() below - it's not valid\n> here, as the created device didn't get created :-D\n> \n> > \t\tint ret = populateMediaDevice(media);\n> > -\t\tif (ret == 0)\n> > -\t\t\taddDevice(media);\n> > +\t\tif (ret < 0) {\n> > +\t\t\tLOG(DeviceEnumerator, Warning)\n> > +\t\t\t\t<< \"Failed to populate media device \"\n> > +\t\t\t\t<< media->deviceNode()\n> > +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n> > +\t\t\treturn ret;\n> > +\t\t}\n> > +\n> > +\t\taddDevice(media);\n> > \t\treturn 0;\n> > \t}\n> > \n> > @@ -141,14 +148,18 @@ int DeviceEnumeratorUdev::enumerate()\n> > \t\tdevnode = udev_device_get_devnode(dev);\n> > \t\tif (!devnode) {\n> > \t\t\tudev_device_unref(dev);\n> > -\t\t\tret = -ENODEV;\n> > -\t\t\tgoto done;\n> > +\t\t\tLOG(DeviceEnumerator, Warning)\n> > +\t\t\t\t<< \"Failed to get device node for '\"\n> > +\t\t\t\t<< syspath << \"', skipping\";\n> > +\t\t\tcontinue;\n> > \t\t}\n> > \n> > -\t\tret = addUdevDevice(dev);\n> > +\t\tif (addUdevDevice(dev) < 0)\n> > +\t\t\tLOG(DeviceEnumerator, Warning)\n> > +\t\t\t\t<< \"Failed to add device for '\"\n> > +\t\t\t\t<< syspath << \"', skipping\";\n> > +\n> > \t\tudev_device_unref(dev);\n> > -\t\tif (ret < 0)\n> > -\t\t\tbreak;\n> > \t}\n> > \n> > done:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 196E760438\n\tfor ;\n\tTue, 18 Feb 2020 00:24:23 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 159E21220;\n\tTue, 18 Feb 2020 00:24:21 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581981862;\n\tbh=mBHYetOc3/+JEPyZ4yUuvU5t0AM+7TbBddoKQ4mEcnU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QIlHy0Kne71ZOu7VI6RJC7DQ3s/jq/6/5DFq/DnHXE97RKdVR1MVJNRiz33BhW+Uv\n\tx7u64hACGJo9bmJY5tgZdXj20oWZz9qmic9ITVlCW9wFVLS7pAuHzqvuOBGLNiOGMQ\n\tehZ1O0UmxZ1V5BIoJ4kJ+yEaQ1e+SzAWMAYDPhsg=","Date":"Tue, 18 Feb 2020 01:24:02 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200217232402.GG4830@pendragon.ideasonboard.com>","References":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>\n\t<0056b3b1-451f-c9d0-ecbf-780ddf68d8f5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<0056b3b1-451f-c9d0-ecbf-780ddf68d8f5@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 23:24:23 -0000"}},{"id":3790,"web_url":"https://patchwork.libcamera.org/comment/3790/","msgid":"","date":"2020-02-17T23:51:12","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/02/2020 23:24, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Feb 17, 2020 at 11:56:42AM +0000, Kieran Bingham wrote:\n>> On 17/02/2020 11:03, Laurent Pinchart wrote:\n>>> If one device fails to enumerate, which isn't supposed to happen under\n>>> normal conditions, both the sysfs and the udev enumerators stop\n>>> enumeration of further devices. This potentially prevents working\n>>> devices from being detected and handled. Fix it by skipping the faulty\n>>> device.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> The addition of the prints for /which/ device fails don't help my use\n>> case as I fail before getting to those prints\n>> (DeviceEnumerator::createDevice)\n>>\n>> We can't add any further introspection of the MediaDevice in\n>> ::createDevice anyway, so that can't be extended to say more information\n>> about the device.\n> \n> Yes, if we fail to retrieve information from the device, then we can\n> hardly print it :-)\n> \n>> MediaDevice::populate() however is painful, as it discards the actual\n>> return value of the MEDIA_IOC_DEVICE_INFO, and\n>> MEDIA_IOC_G_TOPOLOGY,ioctls in event of those failing and instead\n>> returns -EINVAL ...\n>>\n>> But that is not a topic for /this/ patch.\n> \n> Agreed.\n> \n> It could also be useful to make MediaDevice inherit from Loggable.\n\nOhh, yes that's a nice solution for it!\n\nIt's quick too - 5 minute implementation posted :-)\n\n--\nKieran\n\n\n>> Reviewed-by: Kieran Bingham \n>> (and still Tested-by: KB too if you desire)\n> \n> Absolutely, thank you.\n> \n>>> ---\n>>> Changes since v1:\n>>>\n>>> - Add more warning messages to DeviceEnumeratorUdev\n>>> - Use media->deviceNode() and print the driver name where appropriate\n>>> ---\n>>> src/libcamera/device_enumerator_sysfs.cpp | 16 +++++++--------\n>>> src/libcamera/device_enumerator_udev.cpp | 25 ++++++++++++++++-------\n>>> 2 files changed, 26 insertions(+), 15 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n>>> index ad26affb38a3..197ca235879b 100644\n>>> --- a/src/libcamera/device_enumerator_sysfs.cpp\n>>> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n>>> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n>>> {\n>>> \tstruct dirent *ent;\n>>> \tDIR *dir;\n>>> -\tint ret = 0;\n>>> \n>>> \tstatic const char * const sysfs_dirs[] = {\n>>> \t\t\"/sys/subsystem/media/devices\",\n>>> @@ -74,14 +73,15 @@ int DeviceEnumeratorSysfs::enumerate()\n>>> \t\t}\n>>> \n>>> \t\tstd::shared_ptr media = createDevice(devnode);\n>>> -\t\tif (!media) {\n>>> -\t\t\tret = -ENODEV;\n>>> -\t\t\tbreak;\n>>> -\t\t}\n>>> +\t\tif (!media)\n>>> +\t\t\tcontinue;\n>>> \n>>> \t\tif (populateMediaDevice(media) < 0) {\n>>> -\t\t\tret = -ENODEV;\n>>> -\t\t\tbreak;\n>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>> +\t\t\t\t<< \"Failed to populate media device \"\n>>> +\t\t\t\t<< media->deviceNode()\n>>> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n>>> +\t\t\tcontinue;\n>>> \t\t}\n>>> \n>>> \t\taddDevice(media);\n>>> @@ -89,7 +89,7 @@ int DeviceEnumeratorSysfs::enumerate()\n>>> \n>>> \tclosedir(dir);\n>>> \n>>> -\treturn ret;\n>>> +\treturn 0;\n>>> }\n>>> \n>>> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n>>> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n>>> index b2c5fd221dcd..87638c59761c 100644\n>>> --- a/src/libcamera/device_enumerator_udev.cpp\n>>> +++ b/src/libcamera/device_enumerator_udev.cpp\n>>> @@ -82,8 +82,15 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n>>> \t\t\treturn -ENODEV;\n>>> \n>>\n>> Interestingly - actually in my testing of the failures, I don't get to\n>> the code below.\n>>\n>> The failure occurs during media->populate() which is called from\n>> createDevice, which has just returned -ENODEV above here.\n>>\n>> And while it is valid to call media->driver() below - it's not valid\n>> here, as the created device didn't get created :-D\n>>\n>>> \t\tint ret = populateMediaDevice(media);\n>>> -\t\tif (ret == 0)\n>>> -\t\t\taddDevice(media);\n>>> +\t\tif (ret < 0) {\n>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>> +\t\t\t\t<< \"Failed to populate media device \"\n>>> +\t\t\t\t<< media->deviceNode()\n>>> +\t\t\t\t<< \" (\" << media->driver() << \"), skipping\";\n>>> +\t\t\treturn ret;\n>>> +\t\t}\n>>> +\n>>> +\t\taddDevice(media);\n>>> \t\treturn 0;\n>>> \t}\n>>> \n>>> @@ -141,14 +148,18 @@ int DeviceEnumeratorUdev::enumerate()\n>>> \t\tdevnode = udev_device_get_devnode(dev);\n>>> \t\tif (!devnode) {\n>>> \t\t\tudev_device_unref(dev);\n>>> -\t\t\tret = -ENODEV;\n>>> -\t\t\tgoto done;\n>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>> +\t\t\t\t<< \"Failed to get device node for '\"\n>>> +\t\t\t\t<< syspath << \"', skipping\";\n>>> +\t\t\tcontinue;\n>>> \t\t}\n>>> \n>>> -\t\tret = addUdevDevice(dev);\n>>> +\t\tif (addUdevDevice(dev) < 0)\n>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>> +\t\t\t\t<< \"Failed to add device for '\"\n>>> +\t\t\t\t<< syspath << \"', skipping\";\n>>> +\n>>> \t\tudev_device_unref(dev);\n>>> -\t\tif (ret < 0)\n>>> -\t\t\tbreak;\n>>> \t}\n>>> \n>>> done:\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 659DB60438\n\tfor ;\n\tTue, 18 Feb 2020 00:51:15 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFB291220;\n\tTue, 18 Feb 2020 00:51:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581983475;\n\tbh=YeGGytNS2eCfTvOtimvwpvgKKE88qxee1O/Xe83PJFg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=jotJHNYlvolOjI1+WdZz7As+dyk7H/R2KM4JXGqj14hXWjWGLXGxRfisLRbVxRyHL\n\tdy9i0Xj2rXcZ7luJR1IU3lBaY/RgY/UNvUr/FwhwD+QvUFRaBQV4ljLtbXToZeroU/\n\tjNtxgco3kNlwPpct3Bw+10vxnh4CTwQqIhTZVGGw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200217110324.7431-1-laurent.pinchart@ideasonboard.com>\n\t<0056b3b1-451f-c9d0-ecbf-780ddf68d8f5@ideasonboard.com>\n\t<20200217232402.GG4830@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 17 Feb 2020 23:51:12 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200217232402.GG4830@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\tDon't stop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 23:51:15 -0000"}}]