[{"id":3774,"web_url":"https://patchwork.libcamera.org/comment/3774/","msgid":"<6268c3ad-952a-dbda-bffc-baa634731d6e@ideasonboard.com>","date":"2020-02-17T10:05:12","subject":"Re: [libcamera-devel] [PATCH] test: camera: buffer_import: Don't\n\tinclude ","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 16/02/2020 22:13, Laurent Pinchart wrote:\n> The header isn't needed since commit 6e1e847753fd (\"test:\n> camera: buffer_import: Update to FrameBuffer restrictions\"). Don't\n> include it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> test/camera/buffer_import.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 7c9cfafc2a47..ab6e74bd1671 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n\nAyeee, are we really using randomness in our /tests/ ... how do we\nrepeat said tests when they fail, and get the same failure?\n\nPresumably this is (was in this case) to 'increase' coverage somehow...\n\nBut random in tests scares me a little ...\n\nAs a general comment:\n\nIf we really want randomness in tests, I think we ought to make sure we\nprint out the a seed in the logs, and make sure we can reproduce in\nevent of a failure.\n\n/me now see's other patches using random and goes to repeat that message\nthere.\n\n--\nKieran\n\n\n> #include \n> \n> #include \"device_enumerator.h\"\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA7E160436\n\tfor ;\n\tMon, 17 Feb 2020 11:05:15 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57D46563;\n\tMon, 17 Feb 2020 11:05:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581933915;\n\tbh=C/RxByE8FzdujP4cfCNDL0lZutc0R9RN8OkUVqy8f8c=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=eQQgPriqLH/4XrJVjY88SOgpcKT1KqAmsU3HRoZEhsn6dfLfzgqazqp4NPrRYaU1d\n\tKUw5XjW70Ab7wQI786r+cY4RWxO320WqzxsJpcEbD2MkFJpZg9FPqanDj5CTfrtsRG\n\t2eojMJ82iHVZ/BC9qjGjYAzkRbPqMauz41v/Npvc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200216221350.26681-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6268c3ad-952a-dbda-bffc-baa634731d6e@ideasonboard.com>","Date":"Mon, 17 Feb 2020 10:05:12 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200216221350.26681-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] test: camera: buffer_import: Don't\n\tinclude ","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 10:05:16 -0000"}},{"id":3780,"web_url":"https://patchwork.libcamera.org/comment/3780/","msgid":"<20200217114652.GR3013231@oden.dyn.berto.se>","date":"2020-02-17T11:46:52","subject":"Re: [libcamera-devel] [PATCH] test: camera: buffer_import: Don't\n\tinclude ","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-02-17 00:13:50 +0200, Laurent Pinchart wrote:\n> The header isn't needed since commit 6e1e847753fd (\"test:\n> camera: buffer_import: Update to FrameBuffer restrictions\"). Don't\n> include it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/camera/buffer_import.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 7c9cfafc2a47..ab6e74bd1671 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> \n> #include \"device_enumerator.h\"\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A56A76275F\n\tfor ;\n\tMon, 17 Feb 2020 12:46:53 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id a13so18500321ljm.10\n\tfor ;\n\tMon, 17 Feb 2020 03:46:53 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\ty7sm236391ljy.92.2020.02.17.03.46.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 03:46:52 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=T12PCV04ZO+Jndm/CsjCqyLXqFg2ge2t1lfpI8kBM+w=;\n\tb=a1fnGsDR/iy15XlL/MXp+xXfWKXnJuCLxzBhGd+aQQg5n44CH4VamQ0MLund+oupQ5\n\t298CKFWwVP/7RFWHIS6eKva4nFa7DehLvMd/xTRbkKEocUYYuyRmeHdweKAr34mtl5e6\n\tbFyutvjpMpYJ5nfjxv9TsnsVNZK6OvGvBHwos2OIHdl25mwCnZfOCZZv1i0yXUGjk+jO\n\twFuG2cr0vLtokj+B1d3HIqnnHGttMwiRyGSkxBLTnMtV+pdKFovIvB27ef4iUF3yViOY\n\t0y8ay6qAKKnHyHjZ9lttToq5Ipa1DHM+9cLOfHCY4WcXCrwSEc7cFx9kGJhF9mYSr0KH\n\tTmEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=T12PCV04ZO+Jndm/CsjCqyLXqFg2ge2t1lfpI8kBM+w=;\n\tb=VFC2q/hiP7O48IgAk0WuHmhH3Gz1b7679e1Od26yfWcmIOmXWCSeSj/QAOr7MHUu/O\n\tFJbO9+V4W8tWb642KskxAeexGDIQBAgY/Ve8Fn1pMzRtD8vmN2XrlIY0RQliEE5EXhtu\n\tjiMUDFNDpaptSYzO+muP2S7yJZ+eFvCDtkf93jFdP3Sdfk5iBjdDfVUvGw1gE+NEq5fU\n\tM9iqJYeAn5MBHYdNBrJ/sXOVBf4/r0GC1SdZ0eHB0R4EMP6XxH4lnEjw+RQXKKVUn2ww\n\thwyvEnbsngpIGbLOZC8sjsUndTr2xWbYas2J/zsMbkEEou9b2T2oi5R1gRtDg/1MJTn8\n\t8vVg==","X-Gm-Message-State":"APjAAAXLMtOYMid50Y3pHXB3EKko0z1W4uRxFXak9mjMXmcQQUaxS71v\n\tnUxSCRmtTUa53W4Dg3TB3cshZw==","X-Google-Smtp-Source":"APXvYqxoomg7w/w2w+8chGv5/o05NgV2TnVOA9OCyujbAEXwTRhlkNAr6ihsW7gbTw+SWaYie9x+5g==","X-Received":"by 2002:a05:651c:111a:: with SMTP id\n\td26mr9569978ljo.153.1581940012848; \n\tMon, 17 Feb 2020 03:46:52 -0800 (PST)","Date":"Mon, 17 Feb 2020 12:46:52 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200217114652.GR3013231@oden.dyn.berto.se>","References":"<20200216221350.26681-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200216221350.26681-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: camera: buffer_import: Don't\n\tinclude ","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 11:46:53 -0000"}}]