[{"id":3782,"web_url":"https://patchwork.libcamera.org/comment/3782/","msgid":"<20200217122005.GS3013231@oden.dyn.berto.se>","date":"2020-02-17T12:20:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++14 std::*_t type\n\ttraits","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-02-16 02:13:04 +0200, Laurent Pinchart wrote:\n> C++14 introduced useful type traits helpers named std::*_t as aliases to\n> std::*<...>::type. Use them to simplify the code.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 6 +++---\n> include/libcamera/object.h | 2 +-\n> include/libcamera/signal.h | 4 ++--\n> src/libcamera/ipa_module.cpp | 10 +++++-----\n> 4 files changed, 11 insertions(+), 11 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 7ffd2e426e18..983bb5cbbad0 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -38,7 +38,7 @@ public:\n> \t{\n> \t}\n> \n> -\tstd::tuple::type...> args_;\n> +\tstd::tuple...> args_;\n> \tR ret_;\n> };\n> \n> @@ -51,7 +51,7 @@ public:\n> \t{\n> \t}\n> \n> -\tstd::tuple::type...> args_;\n> +\tstd::tuple...> args_;\n> };\n> \n> class BoundMethodBase\n> @@ -63,7 +63,7 @@ public:\n> \t}\n> \tvirtual ~BoundMethodBase() {}\n> \n> -\ttemplate::value>::type * = nullptr>\n> +\ttemplate::value> * = nullptr>\n> \tbool match(T *obj) { return obj == obj_; }\n> \tbool match(Object *object) { return object == object_; }\n> \n> diff --git a/include/libcamera/object.h b/include/libcamera/object.h\n> index 4d16f3f2b610..9a3dd0702d39 100644\n> --- a/include/libcamera/object.h\n> +++ b/include/libcamera/object.h\n> @@ -30,7 +30,7 @@ public:\n> \tvoid postMessage(std::unique_ptr msg);\n> \n> \ttemplate -\t\t typename std::enable_if::value>::type * = nullptr>\n> +\t\t typename std::enable_if_t::value> * = nullptr>\n> \tR invokeMethod(R (T::*func)(FuncArgs...), ConnectionType type,\n> \t\t Args... args)\n> \t{\n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index c13bb30f0636..ed30eb559127 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -45,7 +45,7 @@ public:\n> \t}\n> \n> #ifndef __DOXYGEN__\n> -\ttemplate::value>::type * = nullptr>\n> +\ttemplate::value> * = nullptr>\n> \tvoid connect(T *obj, R (T::*func)(Args...),\n> \t\t ConnectionType type = ConnectionTypeAuto)\n> \t{\n> @@ -53,7 +53,7 @@ public:\n> \t\tSignalBase::connect(new BoundMethodMember(obj, object, func, type));\n> \t}\n> \n> -\ttemplate::value>::type * = nullptr>\n> +\ttemplate::value> * = nullptr>\n> #else\n> \ttemplate\n> #endif\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index de65525b8319..a01d0757ff8f 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -42,20 +42,20 @@ LOG_DEFINE_CATEGORY(IPAModule)\n> namespace {\n> \n> template\n> -typename std::remove_extent::type *elfPointer(void *map, off_t offset,\n> -\t\t\t\t\t\t size_t fileSize, size_t objSize)\n> +typename std::remove_extent_t *elfPointer(void *map, off_t offset,\n> +\t\t\t\t\t size_t fileSize, size_t objSize)\n> {\n> \tsize_t size = offset + objSize;\n> \tif (size > fileSize || size < objSize)\n> \t\treturn nullptr;\n> \n> -\treturn reinterpret_cast::type *>\n> +\treturn reinterpret_cast *>\n> \t\t(static_cast(map) + offset);\n> }\n> \n> template\n> -typename std::remove_extent::type *elfPointer(void *map, off_t offset,\n> -\t\t\t\t\t\t size_t fileSize)\n> +typename std::remove_extent_t *elfPointer(void *map, off_t offset,\n> +\t\t\t\t\t size_t fileSize)\n> {\n> \treturn elfPointer(map, offset, fileSize, sizeof(T));\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D83C60C18\n\tfor ;\n\tMon, 17 Feb 2020 13:20:08 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id v201so11683723lfa.11\n\tfor ;\n\tMon, 17 Feb 2020 04:20:07 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tu15sm225088lfl.87.2020.02.17.04.20.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 04:20:05 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=0nHFfvMwkYEtn4B7OQj1kOBdMcWDtBrW3gyFdrEUvV4=;\n\tb=YV7iVk7ZhNTUiYrRVLFcZXYBkSEU0i780dVu82j/TL3EL7QFts+w3QF+SZId6xoamg\n\tnyjfhIQjYegkCZOy0HTqIKY/OJGaSTxWxuN5/qEgjb4a6quobLxtYeAP8mKKvpgRPB+s\n\tLRFBIBiprGcIoCKi2jIwOTz9APw/WPojfiAh15YcxXwzf5ZZ0O9hoq5YCST3PAqu0n3u\n\tb6ty72rUEFEscShHCIUr6rnjzgHYQRNQnfSNxaJgH4KxmRYLh8y/pP5pBEbXMldG1boM\n\t0pJrEWtnB/Tw/w9cs1jHHTjNMmFA/tP+KylvM7oZRE9ft/mtTuya1y8QeLyYvpwmFF7G\n\tzGCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=0nHFfvMwkYEtn4B7OQj1kOBdMcWDtBrW3gyFdrEUvV4=;\n\tb=ivYdfFE52+d+a4oObX8RyjP50GMwAZ2XiUf29sQTFSs1XijpPzkD2lbeDPML6vrnPM\n\tYP2k91KedxieYDtMXu8hIPlqkKoVG66gGEqxRkMh6ufkkcSqnjCxbe51Pi9c+jeWzXFd\n\tz5WBo1NHNopFFgNaucXnwNxvEUyIdR+uouw3U4r47inBiZjLEHdhyscOGHB3es6eHOLP\n\t+WudtidnQZoP6IipS+7ZN2ZX+DRVe1/ZTT36PJoHk5LNrdOn6Mgjk2LErcmkKw3g7oKM\n\tDNYGn8t1MMGZiSb+guTxKEy/atXjxQhZ4m4ovXV0CY+JoAPFA6il+FQeq2/mpPSioa/j\n\tY05g==","X-Gm-Message-State":"APjAAAWg8eWq7yo8kaCGLbG51pTgI6hz8jZcu4EnnZEtRqPBmmaycxuQ\n\tO9oIqlI5j74I1Q65eAV0sZGV4w==","X-Google-Smtp-Source":"APXvYqwqczGpnOJoNSPIqWQJVl5/KlmbkglSbIeM0aBJq6F5MH5aAyyhVq61/DgT5nbhk1K81KOsGw==","X-Received":"by 2002:a05:6512:78:: with SMTP id\n\ti24mr8140907lfo.10.1581942006328; \n\tMon, 17 Feb 2020 04:20:06 -0800 (PST)","Date":"Mon, 17 Feb 2020 13:20:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200217122005.GS3013231@oden.dyn.berto.se>","References":"<20200216001304.5167-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200216001304.5167-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++14 std::*_t type\n\ttraits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 12:20:08 -0000"}}]