[{"id":3773,"web_url":"https://patchwork.libcamera.org/comment/3773/","msgid":"","date":"2020-02-17T08:23:25","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 14/02/2020 12:37, Laurent Pinchart wrote:\n> If one device fails to enumerate, which isn't supposed to happen under\n> normal conditions, both the sysfs and the udev enumerators stop\n> enumeration of further devices. This potentially prevents working\n> devices from being detected and handled. Fix it by skipping the faulty\n> device.\n\nThank you,\n\nThis does indeed allow the system to continue and function with the\navailable cameras.\n\nInterestingly, in the particular case that I was investigating - it\nwasn't the newly added device that failed ... it was the existing camera\ninterface.\n\nThat can be investigated separately.\n\n--\nKieran\n\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/device_enumerator_sysfs.cpp | 15 +++++++--------\n> src/libcamera/device_enumerator_udev.cpp | 8 +++++---\n> 2 files changed, 12 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> index ad26affb38a3..bde736226f95 100644\n> --- a/src/libcamera/device_enumerator_sysfs.cpp\n> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n> {\n> \tstruct dirent *ent;\n> \tDIR *dir;\n> -\tint ret = 0;\n> \n> \tstatic const char * const sysfs_dirs[] = {\n> \t\t\"/sys/subsystem/media/devices\",\n> @@ -74,14 +73,14 @@ int DeviceEnumeratorSysfs::enumerate()\n> \t\t}\n> \n> \t\tstd::shared_ptr media = createDevice(devnode);\n> -\t\tif (!media) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> -\t\t}\n> +\t\tif (!media)\n> +\t\t\tcontinue;\n> \n> \t\tif (populateMediaDevice(media) < 0) {\n> -\t\t\tret = -ENODEV;\n> -\t\t\tbreak;\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to populate media device /dev/media\"\n> +\t\t\t\t<< idx << \", skipping\";\n> +\t\t\tcontinue;\n> \t\t}\n> \n> \t\taddDevice(media);\n> @@ -89,7 +88,7 @@ int DeviceEnumeratorSysfs::enumerate()\n> \n> \tclosedir(dir);\n> \n> -\treturn ret;\n> +\treturn 0;\n> }\n> \n> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index b2c5fd221dcd..3837aaf97e6a 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -145,10 +145,12 @@ int DeviceEnumeratorUdev::enumerate()\n> \t\t\tgoto done;\n> \t\t}\n> \n> -\t\tret = addUdevDevice(dev);\n> +\t\tif (addUdevDevice(dev) < 0)\n> +\t\t\tLOG(DeviceEnumerator, Warning)\n> +\t\t\t\t<< \"Failed to add device for '\"\n> +\t\t\t\t<< syspath << \"', skipping\";\n> +\n> \t\tudev_device_unref(dev);\n> -\t\tif (ret < 0)\n> -\t\t\tbreak;\n> \t}\n> \n> done:\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B87B160436\n\tfor ;\n\tMon, 17 Feb 2020 09:23:28 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BC442AF;\n\tMon, 17 Feb 2020 09:23:27 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581927808;\n\tbh=0iXTg2ybaIOAthWvHXiVyUfB2oM62/RSxkvxszgJxLs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=PP/aOlmtIiMsZmVmM2MN/uwrnw6pTfkw6JU3wKho36ct/G20IvQ1GuUyWKDU25E/l\n\th8uJbn2EFv05A6bGZG8KFYVzkXuAuJ061GdDvaNOTbcMLULfl0VPdB6Wsq3GEl1vIQ\n\tT7G0kbi10tMH6JWpv2GQJeOj45NHgpR79hYJItzg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200214123715.13026-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 17 Feb 2020 08:23:25 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200214123715.13026-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 08:23:29 -0000"}},{"id":3776,"web_url":"https://patchwork.libcamera.org/comment/3776/","msgid":"","date":"2020-02-17T10:41:23","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 17/02/2020 08:23, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 14/02/2020 12:37, Laurent Pinchart wrote:\n>> If one device fails to enumerate, which isn't supposed to happen under\n>> normal conditions, both the sysfs and the udev enumerators stop\n>> enumeration of further devices. This potentially prevents working\n>> devices from being detected and handled. Fix it by skipping the faulty\n>> device.\n> \n> Thank you,\n> \n> This does indeed allow the system to continue and function with the\n> available cameras.\n> \n> Interestingly, in the particular case that I was investigating - it\n> wasn't the newly added device that failed ... it was the existing camera\n> interface.\n> \n> That can be investigated separately.\n> \n> --\n> Kieran\n> \n> \n> \n>> Signed-off-by: Laurent Pinchart \n\n\nThanks, indeed this now continues to function and produces an\nappropriate message for the failing device components:\n\n\n> [2:20:54.425174891] [3209] ERR MediaDevice media_device.cpp:242 Failed to enumerate topology: Bad address\n> [2:20:54.425281647] [3209] INFO DeviceEnumerator device_enumerator.cpp:217 Unable to populate media device /dev/media0 (Invalid argument), skipping\n> [2:20:54.425393663] [3209] WARN DeviceEnumerator device_enumerator_udev.cpp:149 Failed to add device for '/sys/devices/platform/soc/fe801000.csi/media0', skipping\n> Using camera VF0520 Live! Cam Sync: VF0520 L\n\n\nTested-by: Kieran Bingham \n\nAnd with one small comment considered below:\n\nReviewed-by: Kieran Bingham \n\n\n\n\n\n\n>> ---\n>> src/libcamera/device_enumerator_sysfs.cpp | 15 +++++++--------\n>> src/libcamera/device_enumerator_udev.cpp | 8 +++++---\n>> 2 files changed, 12 insertions(+), 11 deletions(-)\n>>\n>> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n>> index ad26affb38a3..bde736226f95 100644\n>> --- a/src/libcamera/device_enumerator_sysfs.cpp\n>> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n>> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n>> {\n>> \tstruct dirent *ent;\n>> \tDIR *dir;\n>> -\tint ret = 0;\n>> \n>> \tstatic const char * const sysfs_dirs[] = {\n>> \t\t\"/sys/subsystem/media/devices\",\n>> @@ -74,14 +73,14 @@ int DeviceEnumeratorSysfs::enumerate()\n>> \t\t}\n>> \n>> \t\tstd::shared_ptr media = createDevice(devnode);\n>> -\t\tif (!media) {\n>> -\t\t\tret = -ENODEV;\n>> -\t\t\tbreak;\n>> -\t\t}\n>> +\t\tif (!media)\n>> +\t\t\tcontinue;\n>> \n>> \t\tif (populateMediaDevice(media) < 0) {\n>> -\t\t\tret = -ENODEV;\n>> -\t\t\tbreak;\n>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>> +\t\t\t\t<< \"Failed to populate media device /dev/media\"\n>> +\t\t\t\t<< idx << \", skipping\";\n\nShouldn't this use something like media->deviceNode() ?\n\n(Perhaps even printing media->driver() and media->model for guidance too?)\n\n\n>> +\t\t\tcontinue;\n>> \t\t}\n>> \n>> \t\taddDevice(media);\n>> @@ -89,7 +88,7 @@ int DeviceEnumeratorSysfs::enumerate()\n>> \n>> \tclosedir(dir);\n>> \n>> -\treturn ret;\n>> +\treturn 0;\n>> }\n>> \n>> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n>> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n>> index b2c5fd221dcd..3837aaf97e6a 100644\n>> --- a/src/libcamera/device_enumerator_udev.cpp\n>> +++ b/src/libcamera/device_enumerator_udev.cpp\n>> @@ -145,10 +145,12 @@ int DeviceEnumeratorUdev::enumerate()\n>> \t\t\tgoto done;\n>> \t\t}\n>> \n>> -\t\tret = addUdevDevice(dev);\n>> +\t\tif (addUdevDevice(dev) < 0)\n>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>> +\t\t\t\t<< \"Failed to add device for '\"\n>> +\t\t\t\t<< syspath << \"', skipping\";\n>> +\n>> \t\tudev_device_unref(dev);\n>> -\t\tif (ret < 0)\n>> -\t\t\tbreak;\n>> \t}\n>> \n>> done:\n>>\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8998360436\n\tfor ;\n\tMon, 17 Feb 2020 11:41:27 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAAE4563;\n\tMon, 17 Feb 2020 11:41:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581936087;\n\tbh=zimLEJTSYl1cIpbZvL1Ni/JFdy6EoQf+Xa9Tyfi//mQ=;\n\th=Reply-To:Subject:From:To:References:Date:In-Reply-To:From;\n\tb=h3BJWEZ6MZ+iBCF4Igi9AEvrC+Lazxn3iyjeVmCVs0mD6spUD7so+srP/zAFFovFl\n\tPHG2eBc6VbsNzQ9wzujv4KOXjJ4h2439VgycgDvsQFjXGfCpIrrK75rB3pLduOkES2\n\tihVp6v5DZFrZQ0at0Qrf+VaMrbJWJn29riVlMvJ8=","Reply-To":"kieran.bingham@ideasonboard.com","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200214123715.13026-1-laurent.pinchart@ideasonboard.com>\n\t","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 17 Feb 2020 10:41:23 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 10:41:27 -0000"}},{"id":3777,"web_url":"https://patchwork.libcamera.org/comment/3777/","msgid":"<20200217104322.GB4830@pendragon.ideasonboard.com>","date":"2020-02-17T10:43:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Feb 17, 2020 at 10:41:23AM +0000, Kieran Bingham wrote:\n> On 17/02/2020 08:23, Kieran Bingham wrote:\n> > On 14/02/2020 12:37, Laurent Pinchart wrote:\n> >> If one device fails to enumerate, which isn't supposed to happen under\n> >> normal conditions, both the sysfs and the udev enumerators stop\n> >> enumeration of further devices. This potentially prevents working\n> >> devices from being detected and handled. Fix it by skipping the faulty\n> >> device.\n> > \n> > Thank you,\n> > \n> > This does indeed allow the system to continue and function with the\n> > available cameras.\n> > \n> > Interestingly, in the particular case that I was investigating - it\n> > wasn't the newly added device that failed ... it was the existing camera\n> > interface.\n> > \n> > That can be investigated separately.\n> > \n> >> Signed-off-by: Laurent Pinchart \n> \n> Thanks, indeed this now continues to function and produces an\n> appropriate message for the failing device components:\n> \n> > [2:20:54.425174891] [3209] ERR MediaDevice media_device.cpp:242 Failed to enumerate topology: Bad address\n> > [2:20:54.425281647] [3209] INFO DeviceEnumerator device_enumerator.cpp:217 Unable to populate media device /dev/media0 (Invalid argument), skipping\n> > [2:20:54.425393663] [3209] WARN DeviceEnumerator device_enumerator_udev.cpp:149 Failed to add device for '/sys/devices/platform/soc/fe801000.csi/media0', skipping\n> > Using camera VF0520 Live! Cam Sync: VF0520 L\n> \n> Tested-by: Kieran Bingham \n> \n> And with one small comment considered below:\n> \n> Reviewed-by: Kieran Bingham \n> \n> >> ---\n> >> src/libcamera/device_enumerator_sysfs.cpp | 15 +++++++--------\n> >> src/libcamera/device_enumerator_udev.cpp | 8 +++++---\n> >> 2 files changed, 12 insertions(+), 11 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> >> index ad26affb38a3..bde736226f95 100644\n> >> --- a/src/libcamera/device_enumerator_sysfs.cpp\n> >> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> >> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n> >> {\n> >> \tstruct dirent *ent;\n> >> \tDIR *dir;\n> >> -\tint ret = 0;\n> >> \n> >> \tstatic const char * const sysfs_dirs[] = {\n> >> \t\t\"/sys/subsystem/media/devices\",\n> >> @@ -74,14 +73,14 @@ int DeviceEnumeratorSysfs::enumerate()\n> >> \t\t}\n> >> \n> >> \t\tstd::shared_ptr media = createDevice(devnode);\n> >> -\t\tif (!media) {\n> >> -\t\t\tret = -ENODEV;\n> >> -\t\t\tbreak;\n> >> -\t\t}\n> >> +\t\tif (!media)\n> >> +\t\t\tcontinue;\n> >> \n> >> \t\tif (populateMediaDevice(media) < 0) {\n> >> -\t\t\tret = -ENODEV;\n> >> -\t\t\tbreak;\n> >> +\t\t\tLOG(DeviceEnumerator, Warning)\n> >> +\t\t\t\t<< \"Failed to populate media device /dev/media\"\n> >> +\t\t\t\t<< idx << \", skipping\";\n> \n> Shouldn't this use something like media->deviceNode() ?\n> \n> (Perhaps even printing media->driver() and media->model for guidance too?)\n\nThat's a good idea, I'll submit a v2 for you to test :-)\n\n> >> +\t\t\tcontinue;\n> >> \t\t}\n> >> \n> >> \t\taddDevice(media);\n> >> @@ -89,7 +88,7 @@ int DeviceEnumeratorSysfs::enumerate()\n> >> \n> >> \tclosedir(dir);\n> >> \n> >> -\treturn ret;\n> >> +\treturn 0;\n> >> }\n> >> \n> >> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n> >> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> >> index b2c5fd221dcd..3837aaf97e6a 100644\n> >> --- a/src/libcamera/device_enumerator_udev.cpp\n> >> +++ b/src/libcamera/device_enumerator_udev.cpp\n> >> @@ -145,10 +145,12 @@ int DeviceEnumeratorUdev::enumerate()\n> >> \t\t\tgoto done;\n> >> \t\t}\n> >> \n> >> -\t\tret = addUdevDevice(dev);\n> >> +\t\tif (addUdevDevice(dev) < 0)\n> >> +\t\t\tLOG(DeviceEnumerator, Warning)\n> >> +\t\t\t\t<< \"Failed to add device for '\"\n> >> +\t\t\t\t<< syspath << \"', skipping\";\n> >> +\n> >> \t\tudev_device_unref(dev);\n> >> -\t\tif (ret < 0)\n> >> -\t\t\tbreak;\n> >> \t}\n> >> \n> >> done:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 564DF60436\n\tfor ;\n\tMon, 17 Feb 2020 11:43:40 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C66CA563;\n\tMon, 17 Feb 2020 11:43:39 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581936220;\n\tbh=JDe7dTMYaYvu/xkfmSSEMUCV/sqznkSTCgusMtdexzQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rSscYaz7igngLeFNqh/+QsGW31prnCDPhy39OLg9jJJgGpL7Gt7hraxC1dN28lk8d\n\t1Owhne409CZAys/jqGp89GRBzZiqCA2ng4F4JFhLTN1wwcNqTRlN7NEt42af6KKOqv\n\taNoeh5D6KZlbEf/7F5hqmSgLAAO0ffAHK2NqBmh4=","Date":"Mon, 17 Feb 2020 12:43:22 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200217104322.GB4830@pendragon.ideasonboard.com>","References":"<20200214123715.13026-1-laurent.pinchart@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 10:43:40 -0000"}},{"id":3778,"web_url":"https://patchwork.libcamera.org/comment/3778/","msgid":"<27913e52-746f-daf2-36df-7a54f6499a47@ideasonboard.com>","date":"2020-02-17T10:47:02","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/02/2020 10:43, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Feb 17, 2020 at 10:41:23AM +0000, Kieran Bingham wrote:\n>> On 17/02/2020 08:23, Kieran Bingham wrote:\n>>> On 14/02/2020 12:37, Laurent Pinchart wrote:\n>>>> If one device fails to enumerate, which isn't supposed to happen under\n>>>> normal conditions, both the sysfs and the udev enumerators stop\n>>>> enumeration of further devices. This potentially prevents working\n>>>> devices from being detected and handled. Fix it by skipping the faulty\n>>>> device.\n>>>\n>>> Thank you,\n>>>\n>>> This does indeed allow the system to continue and function with the\n>>> available cameras.\n>>>\n>>> Interestingly, in the particular case that I was investigating - it\n>>> wasn't the newly added device that failed ... it was the existing camera\n>>> interface.\n>>>\n>>> That can be investigated separately.\n>>>\n>>>> Signed-off-by: Laurent Pinchart \n>>\n>> Thanks, indeed this now continues to function and produces an\n>> appropriate message for the failing device components:\n>>\n>>> [2:20:54.425174891] [3209] ERR MediaDevice media_device.cpp:242 Failed to enumerate topology: Bad address\n>>> [2:20:54.425281647] [3209] INFO DeviceEnumerator device_enumerator.cpp:217 Unable to populate media device /dev/media0 (Invalid argument), skipping\n>>> [2:20:54.425393663] [3209] WARN DeviceEnumerator device_enumerator_udev.cpp:149 Failed to add device for '/sys/devices/platform/soc/fe801000.csi/media0', skipping\n>>> Using camera VF0520 Live! Cam Sync: VF0520 L\n>>\n>> Tested-by: Kieran Bingham \n>>\n>> And with one small comment considered below:\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>>> ---\n>>>> src/libcamera/device_enumerator_sysfs.cpp | 15 +++++++--------\n>>>> src/libcamera/device_enumerator_udev.cpp | 8 +++++---\n>>>> 2 files changed, 12 insertions(+), 11 deletions(-)\n>>>>\n>>>> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n>>>> index ad26affb38a3..bde736226f95 100644\n>>>> --- a/src/libcamera/device_enumerator_sysfs.cpp\n>>>> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n>>>> @@ -33,7 +33,6 @@ int DeviceEnumeratorSysfs::enumerate()\n>>>> {\n>>>> \tstruct dirent *ent;\n>>>> \tDIR *dir;\n>>>> -\tint ret = 0;\n>>>> \n>>>> \tstatic const char * const sysfs_dirs[] = {\n>>>> \t\t\"/sys/subsystem/media/devices\",\n>>>> @@ -74,14 +73,14 @@ int DeviceEnumeratorSysfs::enumerate()\n>>>> \t\t}\n>>>> \n>>>> \t\tstd::shared_ptr media = createDevice(devnode);\n>>>> -\t\tif (!media) {\n>>>> -\t\t\tret = -ENODEV;\n>>>> -\t\t\tbreak;\n>>>> -\t\t}\n>>>> +\t\tif (!media)\n>>>> +\t\t\tcontinue;\n>>>> \n>>>> \t\tif (populateMediaDevice(media) < 0) {\n>>>> -\t\t\tret = -ENODEV;\n>>>> -\t\t\tbreak;\n>>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>>> +\t\t\t\t<< \"Failed to populate media device /dev/media\"\n>>>> +\t\t\t\t<< idx << \", skipping\";\n>>\n>> Shouldn't this use something like media->deviceNode() ?\n>>\n>> (Perhaps even printing media->driver() and media->model for guidance too?)\n> \n> That's a good idea, I'll submit a v2 for you to test :-)\n\nThere's also the local variable available which was used to construct\nthe MediaDevice; - devnode;\n\nBut getting the strings from the MediaDevice and being more verbose\nabout the failure seems a bit more beneficial all the same.\n\n--\nKieran\n\n\n> \n>>>> +\t\t\tcontinue;\n>>>> \t\t}\n>>>> \n>>>> \t\taddDevice(media);\n>>>> @@ -89,7 +88,7 @@ int DeviceEnumeratorSysfs::enumerate()\n>>>> \n>>>> \tclosedir(dir);\n>>>> \n>>>> -\treturn ret;\n>>>> +\treturn 0;\n>>>> }\n>>>> \n>>>> int DeviceEnumeratorSysfs::populateMediaDevice(const std::shared_ptr &media)\n>>>> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n>>>> index b2c5fd221dcd..3837aaf97e6a 100644\n>>>> --- a/src/libcamera/device_enumerator_udev.cpp\n>>>> +++ b/src/libcamera/device_enumerator_udev.cpp\n>>>> @@ -145,10 +145,12 @@ int DeviceEnumeratorUdev::enumerate()\n>>>> \t\t\tgoto done;\n>>>> \t\t}\n>>>> \n>>>> -\t\tret = addUdevDevice(dev);\n>>>> +\t\tif (addUdevDevice(dev) < 0)\n>>>> +\t\t\tLOG(DeviceEnumerator, Warning)\n>>>> +\t\t\t\t<< \"Failed to add device for '\"\n>>>> +\t\t\t\t<< syspath << \"', skipping\";\n>>>> +\n>>>> \t\tudev_device_unref(dev);\n>>>> -\t\tif (ret < 0)\n>>>> -\t\t\tbreak;\n>>>> \t}\n>>>> \n>>>> done:\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1717260436\n\tfor ;\n\tMon, 17 Feb 2020 11:47:06 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70D59563;\n\tMon, 17 Feb 2020 11:47:05 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581936425;\n\tbh=PBobSmnahbQ8DkBY7VJYcnE2e4TiZk+jDCrqCuCJpSI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=hHEy6ACsR91aC/lZdloRpvSUnkrUdGOVTvJTnvMbjse46u9UF7UCi/zWe/j9aIRv+\n\tU7oQrxOS6sgNjSMZbyMVVmPPEReGCjvy9bDhStH/RJaZ32WM0FQOsApstt5kA0o8Ij\n\thSVpU0GfuJousr3P9y91BLaHdumA+Uelj4WOTjkA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200214123715.13026-1-laurent.pinchart@ideasonboard.com>\n\t\n\t\n\t<20200217104322.GB4830@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<27913e52-746f-daf2-36df-7a54f6499a47@ideasonboard.com>","Date":"Mon, 17 Feb 2020 10:47:02 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200217104322.GB4830@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Don't\n\tstop if one device fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 10:47:06 -0000"}}]