[{"id":3757,"web_url":"https://patchwork.libcamera.org/comment/3757/","msgid":"<20200214002846.GT29760@pendragon.ideasonboard.com>","date":"2020-02-14T00:28:46","subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 14, 2020 at 12:18:09AM +0000, Kieran Bingham wrote:\n> Provide Quit, Play, Stop icons.\n> \n> Create a Qt resource to compile icons into the binary and present them\n> on the toolbar.\n> \n> Update the Quit button with a 'cross', and implement Play/Stop buttons.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> ---\n> v2\n>  - Remove pause button\n> \n>  src/qcam/assets/feathericons/feathericons.qrc | 7 +++++++\n>  src/qcam/main_window.cpp                      | 9 ++++++++-\n>  src/qcam/main_window.h                        | 6 +++---\n>  src/qcam/meson.build                          | 9 +++++++--\n>  4 files changed, 25 insertions(+), 6 deletions(-)\n>  create mode 100644 src/qcam/assets/feathericons/feathericons.qrc\n> \n> diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n> new file mode 100644\n> index 000000000000..b8e5c2266408\n> --- /dev/null\n> +++ b/src/qcam/assets/feathericons/feathericons.qrc\n> @@ -0,0 +1,7 @@\n> +<!DOCTYPE RCC><RCC version=\"1.0\">\n> +<qresource>\n> +<file>./play-circle.svg</file>\n> +<file>./stop-circle.svg</file>\n> +<file>./x-circle.svg</file>\n> +</qresource>\n> +</RCC>\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 0e9e717b7e1a..ec93e0177b41 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -12,6 +12,7 @@\n>  \n>  #include <QComboBox>\n>  #include <QCoreApplication>\n> +#include <QIcon>\n>  #include <QInputDialog>\n>  #include <QTimer>\n>  #include <QToolBar>\n> @@ -66,7 +67,7 @@ int MainWindow::createToolbars()\n>  \t/* Disable right click context menu */\n>  \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n>  \n> -\taction = toolbar_->addAction(\"Quit\");\n> +\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n>  \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n>  \n>  \t/* Camera selection */\n> @@ -81,6 +82,12 @@ int MainWindow::createToolbars()\n>  \n>  \ttoolbar_->addSeparator();\n>  \n> +\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"start\");\n> +\tconnect(action, &QAction::triggered, this, &MainWindow::startCapture);\n> +\n> +\taction = toolbar_->addAction(QIcon(\":stop-circle.svg\"), \"stop\");\n> +\tconnect(action, &QAction::triggered, this, &MainWindow::stopCapture);\n\nDo I understand correctly that if capture is stopped and we select\nanother camera through the combo box, capture will be started on the new\ncamera automatically ? Is this desired ?\n\n> +\n>  \treturn 0;\n>  }\n>  \n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 12af103f87d0..27ceed611d59 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -46,14 +46,14 @@ private Q_SLOTS:\n>  \n>  \tvoid switchCamera(int index);\n>  \n> +\tint startCapture();\n> +\tvoid stopCapture();\n> +\n>  private:\n>  \tint createToolbars();\n>  \tstd::string chooseCamera();\n>  \tint openCamera();\n>  \n> -\tint startCapture();\n> -\tvoid stopCapture();\n> -\n>  \tvoid requestComplete(Request *request);\n>  \tint display(FrameBuffer *buffer);\n>  \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 1e71f20fa15e..5b877a84da85 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -11,6 +11,10 @@ qcam_moc_headers = files([\n>      'main_window.h',\n>  ])\n>  \n> +qcam_resources = files([\n> +    'assets/feathericons/feathericons.qrc',\n> +])\n> +\n>  qt5 = import('qt5')\n>  qt5_dep = dependency('qt5',\n>                       method : 'pkg-config',\n> @@ -30,10 +34,11 @@ if qt5_dep.found()\n>          endif\n>      endif\n>  \n> -    moc_files = qt5.preprocess(moc_headers: qcam_moc_headers,\n> +    resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> +                               qresources : qcam_resources,\n>                                 dependencies: qt5_dep)\n>  \n> -    qcam  = executable('qcam', qcam_sources, moc_files,\n> +    qcam  = executable('qcam', qcam_sources, resources,\n>                         install : true,\n>                         dependencies : [libcamera_dep, qt5_dep],\n>                         cpp_args : qt5_cpp_args)","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8ADCE61922\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Feb 2020 01:29:03 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24F12504;\n\tFri, 14 Feb 2020 01:29:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581640143;\n\tbh=8lM4Sm7sJ8fCAd1ZYjEfY4Ie19kgKHienIqhToifZ4U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RlaDz6ir3foF2+TdiWBxgfK0X10iIw/cMTbMhvmin5ddalOZh+BeLQbyXgQ8LqYyJ\n\tGSZcNA4eL9D4ol63sb2fdi0ws6QxBKassVagPDjAPk/Ap4sSG+sjLk7FOIUPyJRd9G\n\t3cETnmEDsBtbwh2X8X4SnOt29UulY5yLKPMRyU+I=","Date":"Fri, 14 Feb 2020 02:28:46 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20200214002846.GT29760@pendragon.ideasonboard.com>","References":"<20200214001810.19302-1-kieran.bingham@ideasonboard.com>\n\t<20200214001810.19302-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200214001810.19302-7-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 14 Feb 2020 00:29:03 -0000"}},{"id":3759,"web_url":"https://patchwork.libcamera.org/comment/3759/","msgid":"<793edfa2-be5a-409a-8094-57668c2517f0@ideasonboard.com>","date":"2020-02-14T08:28:16","subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 14/02/2020 00:28, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Feb 14, 2020 at 12:18:09AM +0000, Kieran Bingham wrote:\n>> Provide Quit, Play, Stop icons.\n>>\n>> Create a Qt resource to compile icons into the binary and present them\n>> on the toolbar.\n>>\n>> Update the Quit button with a 'cross', and implement Play/Stop buttons.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>>\n>> ---\n>> v2\n>>  - Remove pause button\n>>\n>>  src/qcam/assets/feathericons/feathericons.qrc | 7 +++++++\n>>  src/qcam/main_window.cpp                      | 9 ++++++++-\n>>  src/qcam/main_window.h                        | 6 +++---\n>>  src/qcam/meson.build                          | 9 +++++++--\n>>  4 files changed, 25 insertions(+), 6 deletions(-)\n>>  create mode 100644 src/qcam/assets/feathericons/feathericons.qrc\n>>\n>> diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n>> new file mode 100644\n>> index 000000000000..b8e5c2266408\n>> --- /dev/null\n>> +++ b/src/qcam/assets/feathericons/feathericons.qrc\n>> @@ -0,0 +1,7 @@\n>> +<!DOCTYPE RCC><RCC version=\"1.0\">\n>> +<qresource>\n>> +<file>./play-circle.svg</file>\n>> +<file>./stop-circle.svg</file>\n>> +<file>./x-circle.svg</file>\n>> +</qresource>\n>> +</RCC>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 0e9e717b7e1a..ec93e0177b41 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -12,6 +12,7 @@\n>>  \n>>  #include <QComboBox>\n>>  #include <QCoreApplication>\n>> +#include <QIcon>\n>>  #include <QInputDialog>\n>>  #include <QTimer>\n>>  #include <QToolBar>\n>> @@ -66,7 +67,7 @@ int MainWindow::createToolbars()\n>>  \t/* Disable right click context menu */\n>>  \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n>>  \n>> -\taction = toolbar_->addAction(\"Quit\");\n>> +\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n>>  \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n>>  \n>>  \t/* Camera selection */\n>> @@ -81,6 +82,12 @@ int MainWindow::createToolbars()\n>>  \n>>  \ttoolbar_->addSeparator();\n>>  \n>> +\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"start\");\n>> +\tconnect(action, &QAction::triggered, this, &MainWindow::startCapture);\n>> +\n>> +\taction = toolbar_->addAction(QIcon(\":stop-circle.svg\"), \"stop\");\n>> +\tconnect(action, &QAction::triggered, this, &MainWindow::stopCapture);\n> \n> Do I understand correctly that if capture is stopped and we select\n> another camera through the combo box, capture will be started on the new\n> camera automatically ? Is this desired ?\n\n\nI was fine with it.\n\nDo you want to add a patch to track streaming state and only start the\nstream if one was already running?\n\nThat will complicate switchCamera a little, but not by much.\n\nI'm not sure I (yet) see the benefit of switching to a camera but not\nstarting it ...\n\nEspecially as the ViewFinder would then be left with the previous image,\nso it would be quite unclear as to whether the switch stream worked.\n\n\nIdeally we need a status bar (and further in the future a log viewer) to\nmake sure we can notify users of what has / hasn't happened.\n\n--\nKieran\n\n\n\n>> +\n>>  \treturn 0;\n>>  }\n>>  \n>> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n>> index 12af103f87d0..27ceed611d59 100644\n>> --- a/src/qcam/main_window.h\n>> +++ b/src/qcam/main_window.h\n>> @@ -46,14 +46,14 @@ private Q_SLOTS:\n>>  \n>>  \tvoid switchCamera(int index);\n>>  \n>> +\tint startCapture();\n>> +\tvoid stopCapture();\n>> +\n>>  private:\n>>  \tint createToolbars();\n>>  \tstd::string chooseCamera();\n>>  \tint openCamera();\n>>  \n>> -\tint startCapture();\n>> -\tvoid stopCapture();\n>> -\n>>  \tvoid requestComplete(Request *request);\n>>  \tint display(FrameBuffer *buffer);\n>>  \n>> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n>> index 1e71f20fa15e..5b877a84da85 100644\n>> --- a/src/qcam/meson.build\n>> +++ b/src/qcam/meson.build\n>> @@ -11,6 +11,10 @@ qcam_moc_headers = files([\n>>      'main_window.h',\n>>  ])\n>>  \n>> +qcam_resources = files([\n>> +    'assets/feathericons/feathericons.qrc',\n>> +])\n>> +\n>>  qt5 = import('qt5')\n>>  qt5_dep = dependency('qt5',\n>>                       method : 'pkg-config',\n>> @@ -30,10 +34,11 @@ if qt5_dep.found()\n>>          endif\n>>      endif\n>>  \n>> -    moc_files = qt5.preprocess(moc_headers: qcam_moc_headers,\n>> +    resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n>> +                               qresources : qcam_resources,\n>>                                 dependencies: qt5_dep)\n>>  \n>> -    qcam  = executable('qcam', qcam_sources, moc_files,\n>> +    qcam  = executable('qcam', qcam_sources, resources,\n>>                         install : true,\n>>                         dependencies : [libcamera_dep, qt5_dep],\n>>                         cpp_args : qt5_cpp_args)\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 808DD61A27\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Feb 2020 09:28:19 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC529504;\n\tFri, 14 Feb 2020 09:28:18 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581668899;\n\tbh=xMEa+PemeHXpx7vCjcZAngT33szROYTnNj5/45CWmGE=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=a7Cc7er89aoA6rHwc2jgxaDUXgcOnesUn+nueprJXZK1fYzUGWwU/u6ObIp1Ekdl2\n\t3ZTdLQmZp/SgqNCMEE6qQdOnfrpQvVG812Xo9QOma1C8iBMrLlU/9geHngYXiqwUG/\n\tv47ya6ijAuaKTbGZpqaFj/gKrO5QMqYgDT9P8xKw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20200214001810.19302-1-kieran.bingham@ideasonboard.com>\n\t<20200214001810.19302-7-kieran.bingham@ideasonboard.com>\n\t<20200214002846.GT29760@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<793edfa2-be5a-409a-8094-57668c2517f0@ideasonboard.com>","Date":"Fri, 14 Feb 2020 08:28:16 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200214002846.GT29760@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 14 Feb 2020 08:28:19 -0000"}},{"id":3761,"web_url":"https://patchwork.libcamera.org/comment/3761/","msgid":"<20200214094933.GA4831@pendragon.ideasonboard.com>","date":"2020-02-14T09:49:33","subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Feb 14, 2020 at 08:28:16AM +0000, Kieran Bingham wrote:\n> On 14/02/2020 00:28, Laurent Pinchart wrote:\n> > On Fri, Feb 14, 2020 at 12:18:09AM +0000, Kieran Bingham wrote:\n> >> Provide Quit, Play, Stop icons.\n> >>\n> >> Create a Qt resource to compile icons into the binary and present them\n> >> on the toolbar.\n> >>\n> >> Update the Quit button with a 'cross', and implement Play/Stop buttons.\n> >>\n> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >>\n> >> ---\n> >> v2\n> >>  - Remove pause button\n> >>\n> >>  src/qcam/assets/feathericons/feathericons.qrc | 7 +++++++\n> >>  src/qcam/main_window.cpp                      | 9 ++++++++-\n> >>  src/qcam/main_window.h                        | 6 +++---\n> >>  src/qcam/meson.build                          | 9 +++++++--\n> >>  4 files changed, 25 insertions(+), 6 deletions(-)\n> >>  create mode 100644 src/qcam/assets/feathericons/feathericons.qrc\n> >>\n> >> diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n> >> new file mode 100644\n> >> index 000000000000..b8e5c2266408\n> >> --- /dev/null\n> >> +++ b/src/qcam/assets/feathericons/feathericons.qrc\n> >> @@ -0,0 +1,7 @@\n> >> +<!DOCTYPE RCC><RCC version=\"1.0\">\n> >> +<qresource>\n> >> +<file>./play-circle.svg</file>\n> >> +<file>./stop-circle.svg</file>\n> >> +<file>./x-circle.svg</file>\n> >> +</qresource>\n> >> +</RCC>\n> >> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> >> index 0e9e717b7e1a..ec93e0177b41 100644\n> >> --- a/src/qcam/main_window.cpp\n> >> +++ b/src/qcam/main_window.cpp\n> >> @@ -12,6 +12,7 @@\n> >>  \n> >>  #include <QComboBox>\n> >>  #include <QCoreApplication>\n> >> +#include <QIcon>\n> >>  #include <QInputDialog>\n> >>  #include <QTimer>\n> >>  #include <QToolBar>\n> >> @@ -66,7 +67,7 @@ int MainWindow::createToolbars()\n> >>  \t/* Disable right click context menu */\n> >>  \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n> >>  \n> >> -\taction = toolbar_->addAction(\"Quit\");\n> >> +\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n> >>  \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> >>  \n> >>  \t/* Camera selection */\n> >> @@ -81,6 +82,12 @@ int MainWindow::createToolbars()\n> >>  \n> >>  \ttoolbar_->addSeparator();\n> >>  \n> >> +\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"start\");\n> >> +\tconnect(action, &QAction::triggered, this, &MainWindow::startCapture);\n> >> +\n> >> +\taction = toolbar_->addAction(QIcon(\":stop-circle.svg\"), \"stop\");\n> >> +\tconnect(action, &QAction::triggered, this, &MainWindow::stopCapture);\n> > \n> > Do I understand correctly that if capture is stopped and we select\n> > another camera through the combo box, capture will be started on the new\n> > camera automatically ? Is this desired ?\n> \n> I was fine with it.\n> \n> Do you want to add a patch to track streaming state and only start the\n> stream if one was already running?\n> \n> That will complicate switchCamera a little, but not by much.\n> \n> I'm not sure I (yet) see the benefit of switching to a camera but not\n> starting it ...\n> \n> Especially as the ViewFinder would then be left with the previous image,\n> so it would be quite unclear as to whether the switch stream worked.\n> \n> \n> Ideally we need a status bar (and further in the future a log viewer) to\n> make sure we can notify users of what has / hasn't happened.\n\nI'm fine with this behaviour for now, I just wanted to make sure you\nwere aware of it. We'll keep improving qcam, and I'm sure streaming\nstate and camera switching will be reworked anyway.\n\n> >> +\n> >>  \treturn 0;\n> >>  }\n> >>  \n> >> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> >> index 12af103f87d0..27ceed611d59 100644\n> >> --- a/src/qcam/main_window.h\n> >> +++ b/src/qcam/main_window.h\n> >> @@ -46,14 +46,14 @@ private Q_SLOTS:\n> >>  \n> >>  \tvoid switchCamera(int index);\n> >>  \n> >> +\tint startCapture();\n> >> +\tvoid stopCapture();\n> >> +\n> >>  private:\n> >>  \tint createToolbars();\n> >>  \tstd::string chooseCamera();\n> >>  \tint openCamera();\n> >>  \n> >> -\tint startCapture();\n> >> -\tvoid stopCapture();\n> >> -\n> >>  \tvoid requestComplete(Request *request);\n> >>  \tint display(FrameBuffer *buffer);\n> >>  \n> >> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> >> index 1e71f20fa15e..5b877a84da85 100644\n> >> --- a/src/qcam/meson.build\n> >> +++ b/src/qcam/meson.build\n> >> @@ -11,6 +11,10 @@ qcam_moc_headers = files([\n> >>      'main_window.h',\n> >>  ])\n> >>  \n> >> +qcam_resources = files([\n> >> +    'assets/feathericons/feathericons.qrc',\n> >> +])\n> >> +\n> >>  qt5 = import('qt5')\n> >>  qt5_dep = dependency('qt5',\n> >>                       method : 'pkg-config',\n> >> @@ -30,10 +34,11 @@ if qt5_dep.found()\n> >>          endif\n> >>      endif\n> >>  \n> >> -    moc_files = qt5.preprocess(moc_headers: qcam_moc_headers,\n> >> +    resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> >> +                               qresources : qcam_resources,\n> >>                                 dependencies: qt5_dep)\n> >>  \n> >> -    qcam  = executable('qcam', qcam_sources, moc_files,\n> >> +    qcam  = executable('qcam', qcam_sources, resources,\n> >>                         install : true,\n> >>                         dependencies : [libcamera_dep, qt5_dep],\n> >>                         cpp_args : qt5_cpp_args)","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C6D661A27\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Feb 2020 10:49:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86AB9504;\n\tFri, 14 Feb 2020 10:49:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581673790;\n\tbh=7sVeRerNC6R9i5cFdIUyq6o9U/dw7BGkb5ARBiBslKU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g2IhcBlByVxJGHdDrOUcCHcACtqz61SScbWr1zXJ4C9Ckpn1OFORCQUDBafmzQ5qq\n\thzqjUcULAlOQXL5Kl55MQZGPK1T8JgsF20nokTqEGvaEDcYAvUYcO74fgSUvg04OWP\n\t2sa7otjbD0UGIL2CYN9MRX2Y6YhQ9Km4BDkntudI=","Date":"Fri, 14 Feb 2020 11:49:33 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20200214094933.GA4831@pendragon.ideasonboard.com>","References":"<20200214001810.19302-1-kieran.bingham@ideasonboard.com>\n\t<20200214001810.19302-7-kieran.bingham@ideasonboard.com>\n\t<20200214002846.GT29760@pendragon.ideasonboard.com>\n\t<793edfa2-be5a-409a-8094-57668c2517f0@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<793edfa2-be5a-409a-8094-57668c2517f0@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] qcam: Provide initial icon\n\tbuttons \"Play/Stop\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 14 Feb 2020 09:49:51 -0000"}}]