[{"id":3756,"web_url":"https://patchwork.libcamera.org/comment/3756/","msgid":"<20200214002716.GS29760@pendragon.ideasonboard.com>","date":"2020-02-14T00:27:16","subject":"Re: [libcamera-devel] [PATCH v2 4/7] qcam: Introduce a toolbar and\n\tcamera switching","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 14, 2020 at 12:18:07AM +0000, Kieran Bingham wrote:\n> Implement a quit button, and a list of cameras.\n> \n> Selecting a different camera from the Toolbar will stop the current\n> stream, and start streaming the chosen camera device if it can be\n> acquired.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v2:\n> \n> - Add name to toolbar\n> - Rename setCamera to switchCamera\n> - Disable right click context menu on toolbar.\n> - Utilise a combo box for camera selections\n> - Squash in \"qcam: Expose quit method for MainWindow\"\n> \n> src/qcam/main_window.cpp | 64 ++++++++++++++++++++++++++++++++++++++--\n> src/qcam/main_window.h | 5 ++++\n> 2 files changed, 67 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 2ed84cacf655..0e9e717b7e1a 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -10,9 +10,12 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> #include \n> #include \n> +#include \n> +#include \n> \n> #include \n> #include \n> @@ -27,6 +30,8 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> {\n> \tint ret;\n> \n> +\tcreateToolbars();\n> +\n> \ttitle_ = \"QCam \" + QString::fromStdString(CameraManager::version());\n> \tsetWindowTitle(title_);\n> \tconnect(&titleTimer_, SIGNAL(timeout()), this, SLOT(updateTitle()));\n> @@ -40,8 +45,7 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \t\tret = startCapture();\n> \n> \tif (ret < 0)\n> -\t\tQTimer::singleShot(0, QCoreApplication::instance(),\n> -\t\t\t\t &QCoreApplication::quit);\n> +\t\tquit();\n> }\n> \n> MainWindow::~MainWindow()\n> @@ -53,6 +57,39 @@ MainWindow::~MainWindow()\n> \t}\n> }\n> \n> +int MainWindow::createToolbars()\n> +{\n> +\tQAction *action;\n> +\n> +\ttoolbar_ = addToolBar(\"Main\");\n> +\n> +\t/* Disable right click context menu */\n\nI know we need to update checkstyle.py for this...\n\n> +\ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n> +\n> +\taction = toolbar_->addAction(\"Quit\");\n> +\tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> +\n> +\t/* Camera selection */\n\nAnd here too.\n\nReviewed-by: Laurent Pinchart \n\n> +\tQComboBox *cameraCombo = new QComboBox();\n> +\tconnect(cameraCombo, QOverload::of(&QComboBox::activated),\n> +\t\tthis, &MainWindow::switchCamera);\n> +\n> +\tfor (const std::shared_ptr &cam : cm_->cameras())\n> +\t\tcameraCombo->addItem(QString::fromStdString(cam->name()));\n> +\n> +\ttoolbar_->addWidget(cameraCombo);\n> +\n> +\ttoolbar_->addSeparator();\n> +\n> +\treturn 0;\n> +}\n> +\n> +void MainWindow::quit()\n> +{\n> +\tQTimer::singleShot(0, QCoreApplication::instance(),\n> +\t\t\t &QCoreApplication::quit);\n> +}\n> +\n> void MainWindow::updateTitle()\n> {\n> \tunsigned int duration = frameRateInterval_.elapsed();\n> @@ -66,6 +103,29 @@ void MainWindow::updateTitle()\n> \tsetWindowTitle(title_ + \" : \" + QString::number(fps, 'f', 2) + \" fps\");\n> }\n> \n> +void MainWindow::switchCamera(int index)\n> +{\n> +\tconst auto &cameras = cm_->cameras();\n> +\tif (static_cast(index) >= cameras.size())\n> +\t\treturn;\n> +\n> +\tconst std::shared_ptr &cam = cameras[index];\n> +\n> +\tif (cam->acquire()) {\n> +\t\tstd::cout << \"Failed to acquire camera \" << cam->name() << std::endl;\n> +\t\treturn;\n> +\t}\n> +\n> +\tstd::cout << \"Switching to camera \" << cam->name() << std::endl;\n> +\n> +\tstopCapture();\n> +\n> +\tcamera_->release();\n> +\tcamera_ = cam;\n> +\n> +\tstartCapture();\n> +}\n> +\n> std::string MainWindow::chooseCamera()\n> {\n> \tQStringList cameras;\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index d19cda16e36b..12af103f87d0 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -41,9 +41,13 @@ public:\n> \t~MainWindow();\n> \n> private Q_SLOTS:\n> +\tvoid quit();\n> \tvoid updateTitle();\n> \n> +\tvoid switchCamera(int index);\n> +\n> private:\n> +\tint createToolbars();\n> \tstd::string chooseCamera();\n> \tint openCamera();\n> \n> @@ -71,6 +75,7 @@ private:\n> \tuint32_t previousFrames_;\n> \tuint32_t framesCaptured_;\n> \n> +\tQToolBar *toolbar_;\n> \tViewFinder *viewfinder_;\n> \tstd::map> mappedBuffers_;\n> };","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B9E461922\n\tfor ;\n\tFri, 14 Feb 2020 01:27:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7697A504;\n\tFri, 14 Feb 2020 01:27:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581640053;\n\tbh=uXm/MQqdmzKoTxl1nlA5vgFXYNPb+Sc2aT5TGq7z58M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iKxj2CfHuyn8THLDTwMUSyRQEy9Y0GkUGwaIE6LP5bOkSnSpVZiEoDDP6rt2BPKIB\n\tFB+ee88ZO6IWd/M4LKB7EXJUmL/5qNV6qzrFKRNRZZdMzUDQxnOCekgDBnEucH8o1h\n\tIpDqRC5CwS5djs46Rg5rBVdF3qqA++DNLDmw0YuM=","Date":"Fri, 14 Feb 2020 02:27:16 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200214002716.GS29760@pendragon.ideasonboard.com>","References":"<20200214001810.19302-1-kieran.bingham@ideasonboard.com>\n\t<20200214001810.19302-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200214001810.19302-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/7] qcam: Introduce a toolbar and\n\tcamera switching","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Feb 2020 00:27:34 -0000"}},{"id":3760,"web_url":"https://patchwork.libcamera.org/comment/3760/","msgid":"","date":"2020-02-14T08:31:32","subject":"Re: [libcamera-devel] [PATCH v2 4/7] qcam: Introduce a toolbar and\n\tcamera switching","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 14/02/2020 00:27, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Feb 14, 2020 at 12:18:07AM +0000, Kieran Bingham wrote:\n>> Implement a quit button, and a list of cameras.\n>>\n>> Selecting a different camera from the Toolbar will stop the current\n>> stream, and start streaming the chosen camera device if it can be\n>> acquired.\n>>\n>> Signed-off-by: Kieran Bingham \n>>\n>> ---\n>> v2:\n>>\n>> - Add name to toolbar\n>> - Rename setCamera to switchCamera\n>> - Disable right click context menu on toolbar.\n>> - Utilise a combo box for camera selections\n>> - Squash in \"qcam: Expose quit method for MainWindow\"\n>>\n>> src/qcam/main_window.cpp | 64 ++++++++++++++++++++++++++++++++++++++--\n>> src/qcam/main_window.h | 5 ++++\n>> 2 files changed, 67 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 2ed84cacf655..0e9e717b7e1a 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -10,9 +10,12 @@\n>> #include \n>> #include \n>> \n>> +#include \n>> #include \n>> #include \n>> #include \n>> +#include \n>> +#include \n>> \n>> #include \n>> #include \n>> @@ -27,6 +30,8 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n>> {\n>> \tint ret;\n>> \n>> +\tcreateToolbars();\n>> +\n>> \ttitle_ = \"QCam \" + QString::fromStdString(CameraManager::version());\n>> \tsetWindowTitle(title_);\n>> \tconnect(&titleTimer_, SIGNAL(timeout()), this, SLOT(updateTitle()));\n>> @@ -40,8 +45,7 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n>> \t\tret = startCapture();\n>> \n>> \tif (ret < 0)\n>> -\t\tQTimer::singleShot(0, QCoreApplication::instance(),\n>> -\t\t\t\t &QCoreApplication::quit);\n>> +\t\tquit();\n>> }\n>> \n>> MainWindow::~MainWindow()\n>> @@ -53,6 +57,39 @@ MainWindow::~MainWindow()\n>> \t}\n>> }\n>> \n>> +int MainWindow::createToolbars()\n>> +{\n>> +\tQAction *action;\n>> +\n>> +\ttoolbar_ = addToolBar(\"Main\");\n>> +\n>> +\t/* Disable right click context menu */\n> \n> I know we need to update checkstyle.py for this...\n\nSee, I still think a period is really quite redundant there :-)\n\nFixups applied all the same.\n\n\n>> +\ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n>> +\n>> +\taction = toolbar_->addAction(\"Quit\");\n>> +\tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n>> +\n>> +\t/* Camera selection */\n> \n> And here too.\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> +\tQComboBox *cameraCombo = new QComboBox();\n>> +\tconnect(cameraCombo, QOverload::of(&QComboBox::activated),\n>> +\t\tthis, &MainWindow::switchCamera);\n>> +\n>> +\tfor (const std::shared_ptr &cam : cm_->cameras())\n>> +\t\tcameraCombo->addItem(QString::fromStdString(cam->name()));\n>> +\n>> +\ttoolbar_->addWidget(cameraCombo);\n>> +\n>> +\ttoolbar_->addSeparator();\n>> +\n>> +\treturn 0;\n>> +}\n>> +\n>> +void MainWindow::quit()\n>> +{\n>> +\tQTimer::singleShot(0, QCoreApplication::instance(),\n>> +\t\t\t &QCoreApplication::quit);\n>> +}\n>> +\n>> void MainWindow::updateTitle()\n>> {\n>> \tunsigned int duration = frameRateInterval_.elapsed();\n>> @@ -66,6 +103,29 @@ void MainWindow::updateTitle()\n>> \tsetWindowTitle(title_ + \" : \" + QString::number(fps, 'f', 2) + \" fps\");\n>> }\n>> \n>> +void MainWindow::switchCamera(int index)\n>> +{\n>> +\tconst auto &cameras = cm_->cameras();\n>> +\tif (static_cast(index) >= cameras.size())\n>> +\t\treturn;\n>> +\n>> +\tconst std::shared_ptr &cam = cameras[index];\n>> +\n>> +\tif (cam->acquire()) {\n>> +\t\tstd::cout << \"Failed to acquire camera \" << cam->name() << std::endl;\n>> +\t\treturn;\n>> +\t}\n>> +\n>> +\tstd::cout << \"Switching to camera \" << cam->name() << std::endl;\n>> +\n>> +\tstopCapture();\n>> +\n>> +\tcamera_->release();\n>> +\tcamera_ = cam;\n>> +\n>> +\tstartCapture();\n>> +}\n>> +\n>> std::string MainWindow::chooseCamera()\n>> {\n>> \tQStringList cameras;\n>> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n>> index d19cda16e36b..12af103f87d0 100644\n>> --- a/src/qcam/main_window.h\n>> +++ b/src/qcam/main_window.h\n>> @@ -41,9 +41,13 @@ public:\n>> \t~MainWindow();\n>> \n>> private Q_SLOTS:\n>> +\tvoid quit();\n>> \tvoid updateTitle();\n>> \n>> +\tvoid switchCamera(int index);\n>> +\n>> private:\n>> +\tint createToolbars();\n>> \tstd::string chooseCamera();\n>> \tint openCamera();\n>> \n>> @@ -71,6 +75,7 @@ private:\n>> \tuint32_t previousFrames_;\n>> \tuint32_t framesCaptured_;\n>> \n>> +\tQToolBar *toolbar_;\n>> \tViewFinder *viewfinder_;\n>> \tstd::map> mappedBuffers_;\n>> };\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80EB361A27\n\tfor ;\n\tFri, 14 Feb 2020 09:31:35 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9F7F504;\n\tFri, 14 Feb 2020 09:31:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581669095;\n\tbh=DJ9bbAK1Lc3/n5YqU5L2NQvXG5KaA08f5rxN++n8QK4=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=gxR1JmivPbYFdG5E/Ivm9J1JEfdKrnsTbbmvLW9EmMGSNvYVLf3RIYdJ4fGIgG76v\n\t0e/VAoIFDR14HtictvUm4+FjrED8LJ95tjZ11I4BfzjDfzrbzsJoG6h2pPflEkxf5d\n\tK1MnRMvQMAVItKdkzmYd6YNrv+PefoI9r7kWKqes=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200214001810.19302-1-kieran.bingham@ideasonboard.com>\n\t<20200214001810.19302-5-kieran.bingham@ideasonboard.com>\n\t<20200214002716.GS29760@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 14 Feb 2020 08:31:32 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200214002716.GS29760@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 4/7] qcam: Introduce a toolbar and\n\tcamera switching","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Feb 2020 08:31:35 -0000"}}]