[{"id":432,"web_url":"https://patchwork.libcamera.org/comment/432/","msgid":"<20190121084044.7mqkodrujk4uk64h@uno.localdomain>","date":"2019-01-21T08:40:44","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: signal: Enable\n\tdocumentation generation from signal.h file","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n thanks for the series...\n\nFor 1 and 2:\nAcked-by: Jacopo Mondi \n\n3-6 will require some more time for me to look at the implementation\nbetter, and possibly use it in practice, but when I thought about what\nlogging APIs I would have liked to have, they look very similiar to\nwhat's in there.\n\nThanks\n j\n\nOn Mon, Jan 21, 2019 at 02:59:26AM +0200, Laurent Pinchart wrote:\n> signal.cpp is missing a \\file signal.h Doxygen directive, preventing\n> documentation from being generated for the Signal class. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/signal.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/libcamera/signal.cpp b/src/libcamera/signal.cpp\n> index 51536dc5fdd0..8d62b5beeeac 100644\n> --- a/src/libcamera/signal.cpp\n> +++ b/src/libcamera/signal.cpp\n> @@ -5,6 +5,11 @@\n> * signal.cpp - Signal & slot implementation\n> */\n>\n> +/**\n> + * \\file signal.h\n> + * \\brief Signal & slot implementation\n> + */\n> +\n> namespace libcamera {\n>\n> /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA14460B2D\n\tfor ;\n\tMon, 21 Jan 2019 09:40:36 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3B5A5E0008;\n\tMon, 21 Jan 2019 08:40:36 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 21 Jan 2019 09:40:44 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190121084044.7mqkodrujk4uk64h@uno.localdomain>","References":"<20190121005930.10112-1-laurent.pinchart@ideasonboard.com>\n\t<20190121005930.10112-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"kihytxlu23mchdmx\"","Content-Disposition":"inline","In-Reply-To":"<20190121005930.10112-3-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: signal: Enable\n\tdocumentation generation from signal.h file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 08:40:36 -0000"}},{"id":439,"web_url":"https://patchwork.libcamera.org/comment/439/","msgid":"<20190121103118.GD6484@bigcity.dyn.berto.se>","date":"2019-01-21T10:31:18","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: signal: Enable\n\tdocumentation generation from signal.h file","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-21 02:59:26 +0200, Laurent Pinchart wrote:\n> signal.cpp is missing a \\file signal.h Doxygen directive, preventing\n> documentation from being generated for the Signal class. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/signal.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/signal.cpp b/src/libcamera/signal.cpp\n> index 51536dc5fdd0..8d62b5beeeac 100644\n> --- a/src/libcamera/signal.cpp\n> +++ b/src/libcamera/signal.cpp\n> @@ -5,6 +5,11 @@\n> * signal.cpp - Signal & slot implementation\n> */\n> \n> +/**\n> + * \\file signal.h\n> + * \\brief Signal & slot implementation\n> + */\n> +\n> namespace libcamera {\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA76F60C65\n\tfor ;\n\tMon, 21 Jan 2019 11:31:19 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id p6so15139781lfc.1\n\tfor ;\n\tMon, 21 Jan 2019 02:31:19 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr29-v6sm2190311ljd.44.2019.01.21.02.31.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 21 Jan 2019 02:31:18 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=JQXEEZCXttzsiJ8fKOM6fHN6QDaK+YretnTuk4YKrQ0=;\n\tb=DKq9sRGZxudogwZ1pe2MuCziaqouRBnM6RX/k5AD6sORmtFM6UILsNp3HZKAC7XtxJ\n\t+qZdgGurPG+Z2HYPZKqtvG8gs7DoMPv/6cIHj6xwyI/D8oaWDytlLxhjw7AXQE4AI7pj\n\tCTp/g4YHEixALmE+dx7EdvfMRBLZUGTGYAx2tdEDjoYMX5MQ3Jv767/N31YHtlimqhfa\n\tUYzq67FGyQMznwulhvNYXDft6kgVehPq35QjZgc0mbUZYVFdktW7R2OGT4t75unhJ2iV\n\tSeWTy1WOJB+fpnVagCXmxK65SWycidH+MLYw4RlUrY1KX0Oa533E8tc0dbFgR5XtHWzq\n\tEIcA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=JQXEEZCXttzsiJ8fKOM6fHN6QDaK+YretnTuk4YKrQ0=;\n\tb=gyuirv+ApplAPIo2JPyCYJa3ZFJ+RLqaKfNgOHChnb80XcvNiSThl60iYuR7qj6qNa\n\tfaehGvnEIlvlYuPhUD7JBCQ5Z4HSWhsKn1GQbysqEmHUpQEb0bzVbgPMr98N1unvS98J\n\tplGFE9jtNYjx5I3nA74QQTnglng/5pa0IcmfiJrtGj6TcRBLWSEwMgSZihml91elFEif\n\tg9p4uJO5yjGfHG1HzFtU+XMd5qQeS73rLXVUdLnTbAOR9FBcUFqWrVNq0eIptz4bJw3P\n\t3/qoE6JP8AvyKO7/fY+NvcJofQSTSvj5DDy61C3fyoM8HUYbrgLVhd9TI1V1C32sm8Ua\n\tuVXg==","X-Gm-Message-State":"AJcUukd0yblPa6eEmrN6O13BFuFirhqNcmTDlci2IJ46hPFXhWI6rbQG\n\tN6hhLdPn7JKSq8r76ImZ1JwEX1CCgtI=","X-Google-Smtp-Source":"ALg8bN7GqiKb6uKK9EBakQHKP9j0lIqTMC/6zK4Y9R0oY2PUt/MCbM++h1Zk9UuHw5F0Aq3MbpwAeg==","X-Received":"by 2002:a19:f510:: with SMTP id\n\tj16mr17090974lfb.35.1548066679208; \n\tMon, 21 Jan 2019 02:31:19 -0800 (PST)","Date":"Mon, 21 Jan 2019 11:31:18 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190121103118.GD6484@bigcity.dyn.berto.se>","References":"<20190121005930.10112-1-laurent.pinchart@ideasonboard.com>\n\t<20190121005930.10112-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190121005930.10112-3-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: signal: Enable\n\tdocumentation generation from signal.h file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 10:31:20 -0000"}}]