[{"id":3709,"web_url":"https://patchwork.libcamera.org/comment/3709/","msgid":"","date":"2020-02-13T13:27:03","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipa_manager: Use\n\tutils::split()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"And finally,\n\nOn 13/02/2020 13:09, Kieran Bingham wrote:\n> From: Laurent Pinchart \n> \n> Replace the custom string splitting implementation with utils::split().\n> \n> Signed-off-by: Laurent Pinchart \n> [Kieran: Re-fit to master branch]\n> Signed-off-by: Kieran Bingham \n\nI've modified this patch, as it's original base was upon a set of\npatches where I moved all this code around.\n\nTo simplify things, I've rebased it here.\n\nI think the SoB implies Reviewed-by: here anyway, but as I've distinctly\nmodified it - another ~RB tag would be good from anyone.\n\nKieran\n\n\n\n> ---\n> src/libcamera/ipa_manager.cpp | 21 ++++++---------------\n> 1 file changed, 6 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 92adc6c45015..4ffbdd712ac2 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -110,22 +110,13 @@ IPAManager::IPAManager()\n> \t\treturn;\n> \t}\n> \n> -\tconst char *paths = modulePaths;\n> -\twhile (1) {\n> -\t\tconst char *delim = strchrnul(paths, ':');\n> -\t\tsize_t count = delim - paths;\n> -\n> -\t\tif (count) {\n> -\t\t\tstd::string path(paths, count);\n> -\t\t\tret = addDir(path.c_str());\n> -\t\t\tif (ret > 0)\n> -\t\t\t\tipaCount += ret;\n> -\t\t}\n> -\n> -\t\tif (*delim == '\\0')\n> -\t\t\tbreak;\n> +\tfor (const auto &dir : utils::split(modulePaths, \":\")) {\n> +\t\tif (dir.empty())\n> +\t\t\tcontinue;\n> \n> -\t\tpaths += count + 1;\n> +\t\tint ret = addDir(dir.c_str());\n> +\t\tif (ret > 0)\n> +\t\t\tipaCount += ret;\n> \t}\n> \n> \tif (!ipaCount)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB1BC6195F\n\tfor ;\n\tThu, 13 Feb 2020 14:27:06 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45A8A504;\n\tThu, 13 Feb 2020 14:27:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581600426;\n\tbh=ip53BeZgF1rcDyiTWsaKenpoVuFwQ8WCfYaFqBf/+HA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=OWYPYrkPsiWKulwKAKc30F6UDQq55Z+9PvickgtHaBXCmhgich1YG19a/AByf/DCn\n\tCvGhod7H77htes+mxC1WHEzuGljHIyQ5gBBGorhLFnSgxUNFEBGGx1WYNcv6VkjiiK\n\t5yCBcPstU4NJ0eX3O07ooc0s3CboUa9JpHdMt040=","Reply-To":"kieran.bingham@ideasonboard.com","To":"libcamera devel ","References":"<20200213130908.23638-1-kieran.bingham@ideasonboard.com>\n\t<20200213130908.23638-4-kieran.bingham@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 13 Feb 2020 13:27:03 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200213130908.23638-4-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipa_manager: Use\n\tutils::split()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 13:27:07 -0000"}},{"id":3710,"web_url":"https://patchwork.libcamera.org/comment/3710/","msgid":"<20200213133417.GE4833@pendragon.ideasonboard.com>","date":"2020-02-13T13:34:17","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipa_manager: Use\n\tutils::split()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 13, 2020 at 01:27:03PM +0000, Kieran Bingham wrote:\n> And finally,\n> \n> On 13/02/2020 13:09, Kieran Bingham wrote:\n> > From: Laurent Pinchart \n> > \n> > Replace the custom string splitting implementation with utils::split().\n> > \n> > Signed-off-by: Laurent Pinchart \n> > [Kieran: Re-fit to master branch]\n> > Signed-off-by: Kieran Bingham \n> \n> I've modified this patch, as it's original base was upon a set of\n> patches where I moved all this code around.\n> \n> To simplify things, I've rebased it here.\n> \n> I think the SoB implies Reviewed-by: here anyway, but as I've distinctly\n> modified it - another ~RB tag would be good from anyone.\n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/libcamera/ipa_manager.cpp | 21 ++++++---------------\n> > 1 file changed, 6 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> > index 92adc6c45015..4ffbdd712ac2 100644\n> > --- a/src/libcamera/ipa_manager.cpp\n> > +++ b/src/libcamera/ipa_manager.cpp\n> > @@ -110,22 +110,13 @@ IPAManager::IPAManager()\n> > \t\treturn;\n> > \t}\n> > \n> > -\tconst char *paths = modulePaths;\n> > -\twhile (1) {\n> > -\t\tconst char *delim = strchrnul(paths, ':');\n> > -\t\tsize_t count = delim - paths;\n> > -\n> > -\t\tif (count) {\n> > -\t\t\tstd::string path(paths, count);\n> > -\t\t\tret = addDir(path.c_str());\n> > -\t\t\tif (ret > 0)\n> > -\t\t\t\tipaCount += ret;\n> > -\t\t}\n> > -\n> > -\t\tif (*delim == '\\0')\n> > -\t\t\tbreak;\n> > +\tfor (const auto &dir : utils::split(modulePaths, \":\")) {\n> > +\t\tif (dir.empty())\n> > +\t\t\tcontinue;\n> > \n> > -\t\tpaths += count + 1;\n> > +\t\tint ret = addDir(dir.c_str());\n> > +\t\tif (ret > 0)\n> > +\t\t\tipaCount += ret;\n> > \t}\n> > \n> > \tif (!ipaCount)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE7926195F\n\tfor ;\n\tThu, 13 Feb 2020 14:34:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CC9D504;\n\tThu, 13 Feb 2020 14:34:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581600874;\n\tbh=7X/XnZ2J4bxa0tI0YRqvJMitiF7zgZ71DzQ4hRAxcPw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hpx1l5jgiU4dIqcw5zYqxnz5AfV4M3xkfU7g9SbqG8qK1eqwXErGaDevAB2qNG70T\n\tTNOcP+d8XHtwkqss5aj7l1KOKd3U+OWdSiEdxOAJ0NidAcLCg0gTs5S+IwdzC/utrW\n\tYzLNDRMmyAC7kfcdsNJtkOkWlnNMe2wrQT/67A3w=","Date":"Thu, 13 Feb 2020 15:34:17 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200213133417.GE4833@pendragon.ideasonboard.com>","References":"<20200213130908.23638-1-kieran.bingham@ideasonboard.com>\n\t<20200213130908.23638-4-kieran.bingham@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: ipa_manager: Use\n\tutils::split()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 13:34:35 -0000"}}]