[{"id":437,"web_url":"https://patchwork.libcamera.org/comment/437/","msgid":"<20190121102304.GC6484@bigcity.dyn.berto.se>","date":"2019-01-21T10:23:04","subject":"Re: [libcamera-devel] [PATCH 1/6] Documentation: coding_style: Add\n\tmove semantics to C++11 features","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-21 02:59:25 +0200, Laurent Pinchart wrote:\n> Add the move semantics (move constructor and move assignment) to the\n> allowed C++11 features, as we extensively use them for the unique and\n> shared pointers.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  Documentation/coding-style.rst | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 66db3cebe132..30a1455d8c65 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -80,6 +80,7 @@ C++-11-specific features:\n>    Smart pointers, as well as shared pointers and weak pointers, shall not be\n>    overused.\n>  * Variadic class and function templates\n> +* rvalue references, move constructor and move assignment\n>  \n>  Object Ownership\n>  ~~~~~~~~~~~~~~~~\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA2B260C65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jan 2019 11:23:06 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id l15-v6so17019504lja.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jan 2019 02:23:06 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tj138sm2198512lfg.64.2019.01.21.02.23.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 21 Jan 2019 02:23:05 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ioU0aA5F2FYKYsK/i2z+NILiHcjOX8vU+yK2uTfuB/0=;\n\tb=gw8+qIK/gGomxJ50UrELlq5npQ3VwpdcsZrThhF6ijSgGj4HWFuNl/MIxywJY/YXUx\n\taS2gh3c7oDZidLJAIUWPE54n5iZLhoQovrJz891Rxe0+t8jZqz3/O0BuVniIHNvoL8I6\n\tf5nJnnnfnnbZsCOFygf9T/Vsip1tmq4XvQnYNGr/O9b57O+nrvcZi5pgeoQSZC+GU54c\n\t6wPP71kbuPeey1VTHJCSprasV6qoszo2z9L/tSaqRIxfiI/elhOtxLJDoozQOpNdwcJp\n\tieA4dSdFNfpGb7WUmQUW3E5zOATtAsAdZSPhiuyTb/s3wDr07Obh+uNmZr4056vEa3pb\n\tTO0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ioU0aA5F2FYKYsK/i2z+NILiHcjOX8vU+yK2uTfuB/0=;\n\tb=g/u+pFz565V6LXC3G3E0OL9GnN1fJKNxBePJvG5HFRbTDdFimjL3G7N9w3fpGXHx5y\n\tt7NUXaEe2gIuB5etaJBJqgBtlXg/q6zyINwX3ybBJHjWNL8cnbbW/3flybiiJhWCMLkg\n\t0uHQz8ASjqFy/AISfDCFvNmpTX80xLbsgotkoMe5Akq4gjFIvw0k9Jof1P6FEE3l8/F6\n\tOE+BV0t4wKK5cE4Ij0wHq+LgxEvOlgIupp/ldBUxAyChEkGmlZkXb+mrfFfLmX0WKnDi\n\tZmIrgZ8fPjBItD9vqXe4dzdQL5hjAfSFWx4LUC4Tg0kfNpE7iJKpylDyN+R114IXP48h\n\tjcZQ==","X-Gm-Message-State":"AJcUukd+HRZ66euYk3jPBdKx476xY/FhHJG4MNpAHVW8R1XrpVrdKoo+\n\txXMwu3RUa+cc+jt0AGYYVttj9Id3Uy4=","X-Google-Smtp-Source":"ALg8bN74gdEV4g2mQkEgiPONO495mN8VYMgqMZ7GmVIWFXJZ3hKY3eg+fdXNpSbt3C7SG2S25kUpOg==","X-Received":"by 2002:a2e:81a:: with SMTP id\n\t26-v6mr3979488lji.14.1548066185844; \n\tMon, 21 Jan 2019 02:23:05 -0800 (PST)","Date":"Mon, 21 Jan 2019 11:23:04 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190121102304.GC6484@bigcity.dyn.berto.se>","References":"<20190121005930.10112-1-laurent.pinchart@ideasonboard.com>\n\t<20190121005930.10112-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190121005930.10112-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/6] Documentation: coding_style: Add\n\tmove semantics to C++11 features","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 21 Jan 2019 10:23:07 -0000"}}]