[{"id":3702,"web_url":"https://patchwork.libcamera.org/comment/3702/","msgid":"<940e7a72-5106-14ad-5c8b-fb6b6faa667d@ideasonboard.com>","date":"2020-02-13T10:35:37","subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/02/2020 23:54, Laurent Pinchart wrote:\n> We use array designators for array initialization, which is a C99\n> extension. clang-10 warns about it, causing a build failure.\n> \n> As this is a useful extension, silence the warning. This needs to be\n> done only if the compiler supports the -Wno-c99-designator argument,\n> otherwise a -Wunknown-warning-option will be generated.\n> \n\nAs we actively use the feature, why not then set the standard\nappropriately instead...\n\nindex 0bbd24b2a295..7d572fa9a47a 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n 'werror=true',\n 'warning_level=2',\n 'cpp_std=c++14',\n+ 'c_std=c99', # or =c11, or higher if desired [0]\n ],\n license : 'LGPL 2.1+')\n\nOr will that not apply because we're using C++ compilers... but then if\nthat's the case, why is our c++ compiler complaining about C features...\n\n[0] https://mesonbuild.com/Builtin-options.html#compiler-options\n\n--\nKieran\n\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> meson.build | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 0bbd24b2a295..aceba997aebd 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -60,6 +60,12 @@ if cc.get_id() == 'clang'\n> endif\n> endif\n> \n> +if cc.has_argument('-Wno-c99-designator')\n> + common_arguments += [\n> + '-Wno-c99-designator',\n> + ]\n> +endif\n> +\n> c_arguments += common_arguments\n> cpp_arguments += common_arguments\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B964660F3C\n\tfor ;\n\tThu, 13 Feb 2020 11:35:41 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E2D3504;\n\tThu, 13 Feb 2020 11:35:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581590141;\n\tbh=hcPKIfUAtdfkw2Gbnq48RC6SrKBPIGyciY+KGYrCSw0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Lqg5604rPSUCIEk7roDRSMjvv/eclKElqQ+toBwh1uS6D2t7AEi5k354+5N7XeGQg\n\tlcZFGUtZdXIBLHuTJZFFY2s+HmNnxPmj9cSQ6dQHdhrB5BrrCX2zcGDwU6ZakilYeJ\n\t1wvA6S32dINkPbTX2jvWsO2/QLBnEzsRwnyEt0Ak=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<940e7a72-5106-14ad-5c8b-fb6b6faa667d@ideasonboard.com>","Date":"Thu, 13 Feb 2020 10:35:37 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 10:35:41 -0000"}},{"id":3703,"web_url":"https://patchwork.libcamera.org/comment/3703/","msgid":"<20200213105208.GB4833@pendragon.ideasonboard.com>","date":"2020-02-13T10:52:08","subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Feb 13, 2020 at 10:35:37AM +0000, Kieran Bingham wrote:\n> On 12/02/2020 23:54, Laurent Pinchart wrote:\n> > We use array designators for array initialization, which is a C99\n> > extension. clang-10 warns about it, causing a build failure.\n> > \n> > As this is a useful extension, silence the warning. This needs to be\n> > done only if the compiler supports the -Wno-c99-designator argument,\n> > otherwise a -Wunknown-warning-option will be generated.\n> > \n> \n> As we actively use the feature, why not then set the standard\n> appropriately instead...\n> \n> index 0bbd24b2a295..7d572fa9a47a 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n> 'werror=true',\n> 'warning_level=2',\n> 'cpp_std=c++14',\n> + 'c_std=c99', # or =c11, or higher if desired [0]\n> ],\n> license : 'LGPL 2.1+')\n> \n> Or will that not apply because we're using C++ compilers... but then if\n> that's the case, why is our c++ compiler complaining about C features...\n\nThe option is indeed for C sources only. I'm not sure what the rationale\nis for clang++ to complain about this, but it does.\n\nFor what it's worth, ChromeOS also sets -Wno-c99-designator.\n\n> [0] https://mesonbuild.com/Builtin-options.html#compiler-options\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > meson.build | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 0bbd24b2a295..aceba997aebd 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -60,6 +60,12 @@ if cc.get_id() == 'clang'\n> > endif\n> > endif\n> > \n\nI'll add a comment here:\n\n# We use C99 designated initializers for arrays as C++ has no equivalent\n# feature. Both gcc and clang support this extension, but recent\n# versions of clang generate a warning that needs to be disabled.\n\n> > +if cc.has_argument('-Wno-c99-designator')\n> > + common_arguments += [\n> > + '-Wno-c99-designator',\n> > + ]\n> > +endif\n> > +\n> > c_arguments += common_arguments\n> > cpp_arguments += common_arguments\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61CE060F3C\n\tfor ;\n\tThu, 13 Feb 2020 11:52:25 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92728504;\n\tThu, 13 Feb 2020 11:52:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581591144;\n\tbh=l/waEnmK7g3f571nuSV0W581FIA2jVkqGZWHeziRFDk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Md4WtsY8rOpcLaq2kgvvnIV5yIlvSRuALDW7RI8EuAZW7kd+EN8IX4qoC6o1jdvMX\n\tq6SZO9tgPrWLGs305f6y9tzsPS5s2+sw9YozVeiJBk8WS30ueKnPSyl7y8aXpr+G8G\n\t8yWbDKk/k5bk2FBqkvrbYPw10MIqHzEcCCTMRbss=","Date":"Thu, 13 Feb 2020 12:52:08 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200213105208.GB4833@pendragon.ideasonboard.com>","References":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>\n\t<940e7a72-5106-14ad-5c8b-fb6b6faa667d@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<940e7a72-5106-14ad-5c8b-fb6b6faa667d@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 10:52:25 -0000"}},{"id":3705,"web_url":"https://patchwork.libcamera.org/comment/3705/","msgid":"<0edcf0f2-a3c4-c189-5b34-15512f75d7ba@ideasonboard.com>","date":"2020-02-13T11:46:50","subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 13/02/2020 10:52, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Feb 13, 2020 at 10:35:37AM +0000, Kieran Bingham wrote:\n>> On 12/02/2020 23:54, Laurent Pinchart wrote:\n>>> We use array designators for array initialization, which is a C99\n>>> extension. clang-10 warns about it, causing a build failure.\n>>>\n>>> As this is a useful extension, silence the warning. This needs to be\n>>> done only if the compiler supports the -Wno-c99-designator argument,\n>>> otherwise a -Wunknown-warning-option will be generated.\n>>>\n>>\n>> As we actively use the feature, why not then set the standard\n>> appropriately instead...\n>>\n>> index 0bbd24b2a295..7d572fa9a47a 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n>> 'werror=true',\n>> 'warning_level=2',\n>> 'cpp_std=c++14',\n>> + 'c_std=c99', # or =c11, or higher if desired [0]\n>> ],\n>> license : 'LGPL 2.1+')\n>>\n>> Or will that not apply because we're using C++ compilers... but then if\n>> that's the case, why is our c++ compiler complaining about C features...\n> \n> The option is indeed for C sources only. I'm not sure what the rationale\n> is for clang++ to complain about this, but it does.\n> \n> For what it's worth, ChromeOS also sets -Wno-c99-designator.\n> \n>> [0] https://mesonbuild.com/Builtin-options.html#compiler-options\n>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> meson.build | 6 ++++++\n>>> 1 file changed, 6 insertions(+)\n>>>\n>>> diff --git a/meson.build b/meson.build\n>>> index 0bbd24b2a295..aceba997aebd 100644\n>>> --- a/meson.build\n>>> +++ b/meson.build\n>>> @@ -60,6 +60,12 @@ if cc.get_id() == 'clang'\n>>> endif\n>>> endif\n>>> \n> \n> I'll add a comment here:\n> \n> # We use C99 designated initializers for arrays as C++ has no equivalent\n> # feature. Both gcc and clang support this extension, but recent\n> # versions of clang generate a warning that needs to be disabled.\n\n\nGreat, I think the comment helps a lot there.\n\nReviewed-by: Kieran Bingham \n\n\n>>> +if cc.has_argument('-Wno-c99-designator')\n>>> + common_arguments += [\n>>> + '-Wno-c99-designator',\n>>> + ]\n>>> +endif\n>>> +\n>>> c_arguments += common_arguments\n>>> cpp_arguments += common_arguments\n>>> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA82F6043C\n\tfor ;\n\tThu, 13 Feb 2020 12:46:54 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24D882D2;\n\tThu, 13 Feb 2020 12:46:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581594414;\n\tbh=X2qLwpoDVgxomY+Q7lSphMOtS4NdR0TfnayOaCTaC2c=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=EMSww/+HvPI6llPFIOevMFFu8HIVh+ayGlqNRIwRpKir+KqGhh//YX0+2Nq4vYszQ\n\tlntYjCYJyt4gFOwVWb/B+WB0f0qvl1fR2W53o9vEl1AwH9zlDpznYc2n2Nes5DarPB\n\tdX210RkoTF4ze8+Y5qOh9vdpTg3AHYpGgv7YG8zI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>\n\t<940e7a72-5106-14ad-5c8b-fb6b6faa667d@ideasonboard.com>\n\t<20200213105208.GB4833@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0edcf0f2-a3c4-c189-5b34-15512f75d7ba@ideasonboard.com>","Date":"Thu, 13 Feb 2020 11:46:50 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200213105208.GB4833@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 11:46:54 -0000"}},{"id":3706,"web_url":"https://patchwork.libcamera.org/comment/3706/","msgid":"<20200213120535.GG3013231@oden.dyn.berto.se>","date":"2020-02-13T12:05:35","subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-02-13 01:54:51 +0200, Laurent Pinchart wrote:\n> We use array designators for array initialization, which is a C99\n> extension. clang-10 warns about it, causing a build failure.\n> \n> As this is a useful extension, silence the warning. This needs to be\n> done only if the compiler supports the -Wno-c99-designator argument,\n> otherwise a -Wunknown-warning-option will be generated.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> meson.build | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 0bbd24b2a295..aceba997aebd 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -60,6 +60,12 @@ if cc.get_id() == 'clang'\n> endif\n> endif\n> \n> +if cc.has_argument('-Wno-c99-designator')\n> + common_arguments += [\n> + '-Wno-c99-designator',\n> + ]\n> +endif\n> +\n> c_arguments += common_arguments\n> cpp_arguments += common_arguments\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF2546043C\n\tfor ;\n\tThu, 13 Feb 2020 13:05:37 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id n18so6284004ljo.7\n\tfor ;\n\tThu, 13 Feb 2020 04:05:37 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tx23sm1194003lff.24.2020.02.13.04.05.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 13 Feb 2020 04:05:36 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=OmkyJFxJjhklXTfFI+0dXYc67BYg6nGCFHxrj5/73Hg=;\n\tb=B/pQbGVZ5wKp77vXtGYPrromZKVDKZJM2MF+JZx3WHu7RsIP73znLjWb3ZNIE780En\n\tlwuH7jKhb0wTA7LiREeh8yJQB3s0kct6QIERIvwOwW9HMzRtJaZ7ytHV9M1tHa8lSCqa\n\t7FRN5wXyJzh4PqwmWXTw2o2K/t3rDzpXQhxU9pJxmU5dnVQlIdU3pG0Vsrthnr0/waKw\n\ty+70bTroWu/Bm8/8n6a2RYKxybPfZ2sudbgwEbPhJS8JOj3x+Do0f3k1FJxJuZRAr2cJ\n\tLX+rAtgELDoxViAjWY/E+4jzRI5G8Rr7xhYOeKv+XKClt6UYU3/s2Is6uvQ2apBJW3xf\n\tgwmw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=OmkyJFxJjhklXTfFI+0dXYc67BYg6nGCFHxrj5/73Hg=;\n\tb=k/qKK5tdCHh4RkTz6DKSADFyXlOWwWk3Y/DWTMDWJ0VvYJEv6XlvIEZu6HWN80Nna7\n\tG7cDyn5y/o5U9ifXencRB3Ms7MRWw6t4GObZu4430qJ2YuQTsUa3a2slk3ph6kaaDkBD\n\tKu5JmfqPkgOGEpjumDCt6b5yDI7QNP+V5OAmya5YfwmV/3YkL3IlCxQdWw90gKGVoMEd\n\t5iKvhj98/PVJu8IBbhE17Di1NHalW/2GcdOI8D6HoyYHnYJSxnHoVtFBiq/q3uMezAC+\n\twIohKUF7JKgr7SNnUH85HYavj8IeGjy4S+kf7q0T6kFihK8mC5gnzb/kAJU04SnFS6Nq\n\tXqFg==","X-Gm-Message-State":"APjAAAX9PUjLi0+bSNay15HCQrXS1NMVcTGKuGsruHZt/FSx56WKjQAo\n\t+4xvNCLyzoDnqmXio627dYh32XVlyRo=","X-Google-Smtp-Source":"APXvYqxLGz9YyEqSSw3uWIElMfd4Y74/4XAI3fEVaXqmZ5aIcN3A59bIJwkKptYwu7vCXSXXIF731Q==","X-Received":"by 2002:a2e:9942:: with SMTP id\n\tr2mr10568949ljj.182.1581595536811; \n\tThu, 13 Feb 2020 04:05:36 -0800 (PST)","Date":"Thu, 13 Feb 2020 13:05:35 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200213120535.GG3013231@oden.dyn.berto.se>","References":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200212235451.6206-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] meson.build: Silence the C99\n\tdesignators warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 12:05:37 -0000"}}]