[{"id":3651,"web_url":"https://patchwork.libcamera.org/comment/3651/","msgid":"<20200211091507.GA28355@pendragon.ideasonboard.com>","date":"2020-02-11T09:15:07","subject":"Re: [libcamera-devel] [PATCH v2] qcam: Switch default stream role\n\tto viewfinder","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Feb 11, 2020 at 08:50:10AM +0000, Naushir Patuck wrote:\n> qcam currently only displays a standard viewfinder. As such set the\n> StreamRole parameter to Viewfinder so that the pipeline handlers can\n> setup the appropriate resolutions and formats.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nand pushed to master.\n\n> ---\n>  src/qcam/main_window.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index df51fa8..70a3e61 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -125,7 +125,7 @@ int MainWindow::startCapture()\n>  {\n>  \tint ret;\n>  \n> -\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n> +\tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n>  \n>  \tStreamConfiguration &cfg = config_->at(0);\n>  \tif (options_.isSet(OptSize)) {","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCD0A6097B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Feb 2020 10:15:23 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE483595;\n\tTue, 11 Feb 2020 10:15:22 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581412523;\n\tbh=PHnz1oE7tVph/9c9a81Z6nAL9OOzgMV7ecGBzWJnw7U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wBHAVrmvCIiiEgW0z59jjwPCU67KQVzNMGXQDagL9wRPpP9Jui2bWH8bLFOplpOxS\n\txJ2uoZk+3CHMYydbSbtVHB6pgJNZpP2nPpYB2mT6Jg65k7lGp3fI+9rrXwOqzufIaP\n\tWRHlm3h9/1fNMubgqPQw36mVDXAZFXxDHXTQPZ2s=","Date":"Tue, 11 Feb 2020 11:15:07 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200211091507.GA28355@pendragon.ideasonboard.com>","References":"<20200211085010.10191-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200211085010.10191-1-naush@raspberrypi.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] qcam: Switch default stream role\n\tto viewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 11 Feb 2020 09:15:24 -0000"}}]