{"id":2802,"url":"https://patchwork.libcamera.org/api/patches/2802/?format=json","web_url":"https://patchwork.libcamera.org/patch/2802/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200211085010.10191-1-naush@raspberrypi.com>","date":"2020-02-11T08:50:10","name":"[libcamera-devel,v2] qcam: Switch default stream role to viewfinder","commit_ref":"8ce24bebbf177136b1a5640287239644e98c4b52","pull_url":null,"state":"accepted","archived":false,"hash":"ba5edc52cba5a8026adf741eeb1e94f24c40eb11","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2802/mbox/","series":[{"id":666,"url":"https://patchwork.libcamera.org/api/series/666/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=666","date":"2020-02-11T08:50:10","name":"[libcamera-devel,v2] qcam: Switch default stream role to viewfinder","version":2,"mbox":"https://patchwork.libcamera.org/series/666/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2802/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2802/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D033E6043C\n\tfor ;\n\tTue, 11 Feb 2020 09:52:15 +0100 (CET)","by mail-wr1-x441.google.com with SMTP id c9so11203082wrw.8\n\tfor ;\n\tTue, 11 Feb 2020 00:52:15 -0800 (PST)","from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\ta13sm4400386wrp.93.2020.02.11.00.52.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 11 Feb 2020 00:52:14 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=XT9QGHUjP7HVNJEwI5Rbt3JF/kduWzVHHnlHBMyvjIY=;\n\tb=MWzv0Iph9U/jgZqUPqGhvB2igj71tYKXmdWxcM9ycbE+w0tE7UvXEeg3XxtXyR1n+C\n\tNr3VyXjUI1ydE/Ux21t8zqEE+V600o10xtykxabsl+VfxVjzujhO907TlDd4N4B1Trr7\n\tKRryLp3K1x6Jmg/t1rc36Etswn1cdmVAcq3d1jWsvZn10Riu9IelHkaboj/lfS/ToJKk\n\tvr3ZQ/KUOJ66lbx1s+kzCpsfN/GmV/CSD2eJfizvLu+ZsRJ3XJZUJ9NDEYgv9wkMvT0z\n\tJYaM2fYEUQJzsEsNijLUsrKWTkNeHOaTlFtmIiYuutNZPIurZNkR7h9HAJDZE93fB/ut\n\tsQbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=XT9QGHUjP7HVNJEwI5Rbt3JF/kduWzVHHnlHBMyvjIY=;\n\tb=TzoFbGt/6MLAbNf/QiiHyJefq24QjYh4Ys820QC62BEjTFAALobRQd68mJ2Mhtk9oz\n\tAvtVnK22qLhiwbKR4rRFMaXHWOQ3CVWSknPRp1tPjnn8fMnuDl7WBmlziIF/m3ga+yXk\n\tdi7VARoRWFBEwoScwS55sbBvCuJ5e8nO9Y6fcst5s159KkW0/ddEZdvglfzZ6oqkjo9Q\n\t9+S6xNjfAvTecOKSUfK/PimCuEk0iXR/UFNVv1wNKFGb801hqUMIh50OcF/l9JnpqeXf\n\tSfFm+1NE8tAadhExYMLTWX+3jMOPbGHnVRKGICOk7915/SmUXEgWoBXDLV/NS3iL80Ug\n\tk1hw==","X-Gm-Message-State":"APjAAAX2wSulVu5hFvotm9kzYN4FzOvpzYDVP2fJw5NXlHYRdLmQZhb5\n\tueFeI49F5qRun1GFIIDlfOTExKPNlh6u7w==","X-Google-Smtp-Source":"APXvYqxcTQ1l70y2KyCgb0a1mgpcjT5sDy4+bKSo2Vi8SjohiHDyRwSTiZH/v2WVx41sMtqghzAQyg==","X-Received":"by 2002:a5d:4702:: with SMTP id y2mr7049371wrq.37.1581411135221; \n\tTue, 11 Feb 2020 00:52:15 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Feb 2020 08:50:10 +0000","Message-Id":"<20200211085010.10191-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] qcam: Switch default stream role to\n\tviewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 08:52:16 -0000"},"content":"qcam currently only displays a standard viewfinder. As such set the\nStreamRole parameter to Viewfinder so that the pipeline handlers can\nsetup the appropriate resolutions and formats.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \n---\n src/qcam/main_window.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex df51fa8..70a3e61 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -125,7 +125,7 @@ int MainWindow::startCapture()\n {\n \tint ret;\n \n-\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n+\tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n \n \tStreamConfiguration &cfg = config_->at(0);\n \tif (options_.isSet(OptSize)) {\n","prefixes":["libcamera-devel","v2"]}