[{"id":3629,"web_url":"https://patchwork.libcamera.org/comment/3629/","msgid":"<20200206234244.GJ7611@pendragon.ideasonboard.com>","date":"2020-02-06T23:42:44","subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:\n> Provide simple clean icons from https://feathericons.com/\n> (https://github.com/feathericons/feather)\n> \n> These are provided under the MIT license.\n\nCould you add a copy of the license to licenses/ ?\n\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/assets/feathericons/README.md | 5 +\n> src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++\n> src/qcam/assets/feathericons/*.svg | +\n> \n> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md\n> new file mode 100644\n> index 000000000000..ce7664f6bf16\n> --- /dev/null\n> +++ b/src/qcam/assets/feathericons/README.md\n> @@ -0,0 +1,5 @@\n> +Icons from https://feathericons.com/\n> +License: MIT\n> +\n> +Generate the QRC file with:\n> + rcc --project\n> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg\n> new file mode 100644\n> index 000000000000..669a57a772fa\n> --- /dev/null\n> +++ b/src/qcam/assets/feathericons/activity.svg\n> @@ -0,0 +1 @@\n\nShould we add an SPDX tag here ?\n\n\n\n> +\n> \\ No newline at end of file\n> \n> < Remaing icons chopped >\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 457F860864\n\tfor ;\n\tFri, 7 Feb 2020 00:43:00 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C53909CE;\n\tFri, 7 Feb 2020 00:42:59 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581032579;\n\tbh=ic1s5xyfv0F0LoTluguvvsAmDbdB4n9r9nOYhGDFTzE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Rrj/WLu/dynNB+lUSyQn1+J1tDrDFkySAnhHoJCbg+mXnAQhtzQ4k1ADeAFyn/Gqu\n\tjzZtYXRHS7tLle6SZCZg/aSPSDHpfdPJ7nXJuOED26UaMSEog67m+vvGIcAiVqeuAl\n\t6wnDWs2rpRwV82RuH2VgrpFly3/8LPig/Htw2vsI=","Date":"Fri, 7 Feb 2020 01:42:44 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200206234244.GJ7611@pendragon.ideasonboard.com>","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200206150504.24204-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Feb 2020 23:43:00 -0000"}},{"id":3750,"web_url":"https://patchwork.libcamera.org/comment/3750/","msgid":"<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>","date":"2020-02-13T22:38:03","subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/02/2020 23:42, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:\n>> Provide simple clean icons from https://feathericons.com/\n>> (https://github.com/feathericons/feather)\n>>\n>> These are provided under the MIT license.\n> \n> Could you add a copy of the license to licenses/ ?\n\nLooks like you've handled that with your licences series.\n\n\n\n> \n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/qcam/assets/feathericons/README.md | 5 +\n>> src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++\n>> src/qcam/assets/feathericons/*.svg | +\n>>\n>> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md\n>> new file mode 100644\n>> index 000000000000..ce7664f6bf16\n>> --- /dev/null\n>> +++ b/src/qcam/assets/feathericons/README.md\n>> @@ -0,0 +1,5 @@\n>> +Icons from https://feathericons.com/\n>> +License: MIT\n\nPerhaps I should set this as the SPDX, although that would then perhaps\nrepresent the README.md file ...?\n\n>> +\n>> +Generate the QRC file with:\n>> + rcc --project\n>> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg\n>> new file mode 100644\n>> index 000000000000..669a57a772fa\n>> --- /dev/null\n>> +++ b/src/qcam/assets/feathericons/activity.svg\n>> @@ -0,0 +1 @@\n> \n> Should we add an SPDX tag here ?\n> \n> \n\nI don't think we should modify the files just to put a licence statement\nin them no. They are an external import.\n\n\n> \n>> +\n>> \\ No newline at end of file\n>>\n>> < Remaing icons chopped >\n> \n> Reviewed-by: Laurent Pinchart \n\nWhat are your thoughts on adding the full set, vs adding only the icons\nused in the series 'so far'.\n\nAdding the full set makes it easier to add functionality later and be\nable to identify what icons are available, but of course comes at the\nexpense of storing more icons in the our repository ...\n\n\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1FD561A10\n\tfor ;\n\tThu, 13 Feb 2020 23:38:06 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 237CC504;\n\tThu, 13 Feb 2020 23:38:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581633486;\n\tbh=8PQAHN+2Q1o5INgsYc9oIA5PNqRSDRaCoXYucCfwWYI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=aQk5pc6V+QeMbYZRWzyn0AyPhzNLWHEDvu+fnQxAsSIyG1qAOF1M9UED4FN+0YUN9\n\tt+BjqAexpEAf3o4Co6tIjwmQxrtCWjxxGG+zCvbZ1T37NCWhJjZKa6z6zIlam/9SWj\n\tqR1RCp3FgVdr/eF5WeXOjzKNGTSuPqEDRL2JxQ8w=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-5-kieran.bingham@ideasonboard.com>\n\t<20200206234244.GJ7611@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>","Date":"Thu, 13 Feb 2020 22:38:03 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200206234244.GJ7611@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 22:38:06 -0000"}},{"id":3751,"web_url":"https://patchwork.libcamera.org/comment/3751/","msgid":"<20200213224120.GP29760@pendragon.ideasonboard.com>","date":"2020-02-13T22:41:20","subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Feb 13, 2020 at 10:38:03PM +0000, Kieran Bingham wrote:\n> On 06/02/2020 23:42, Laurent Pinchart wrote:\n> > On Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:\n> >> Provide simple clean icons from https://feathericons.com/\n> >> (https://github.com/feathericons/feather)\n> >>\n> >> These are provided under the MIT license.\n> > \n> > Could you add a copy of the license to licenses/ ?\n> \n> Looks like you've handled that with your licences series.\n> \n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/qcam/assets/feathericons/README.md | 5 +\n> >> src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++\n> >> src/qcam/assets/feathericons/*.svg | +\n> >>\n> >> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md\n> >> new file mode 100644\n> >> index 000000000000..ce7664f6bf16\n> >> --- /dev/null\n> >> +++ b/src/qcam/assets/feathericons/README.md\n> >> @@ -0,0 +1,5 @@\n> >> +Icons from https://feathericons.com/\n> >> +License: MIT\n> \n> Perhaps I should set this as the SPDX, although that would then perhaps\n> represent the README.md file ...?\n\nIt would represent the README.md only, yes :-S\n\n> >> +\n> >> +Generate the QRC file with:\n> >> + rcc --project\n> >> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg\n> >> new file mode 100644\n> >> index 000000000000..669a57a772fa\n> >> --- /dev/null\n> >> +++ b/src/qcam/assets/feathericons/activity.svg\n> >> @@ -0,0 +1 @@\n> > \n> > Should we add an SPDX tag here ?\n> > \n> > \n> \n> I don't think we should modify the files just to put a licence statement\n> in them no. They are an external import.\n\nI agree.\n\nThe REUSE specification includes a way to specify licenses for files\nthat can't be modified, maybe we can use that.\n\n> >> +\n> >> \\ No newline at end of file\n> >>\n> >> < Remaing icons chopped >\n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> What are your thoughts on adding the full set, vs adding only the icons\n> used in the series 'so far'.\n> \n> Adding the full set makes it easier to add functionality later and be\n> able to identify what icons are available, but of course comes at the\n> expense of storing more icons in the our repository ...\n\nIt won't use much disk space, the icons are very small, but adding only\nthe icons we need has the nice advantage of quickly showing which files\nare used (all of them). It's a bit like commented-out code, we usually\nstrip it. I think I'd be in favour of only adding the icons we use, but\nit maybe not be difficult to convince me otherwise.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBA1761A10\n\tfor ;\n\tThu, 13 Feb 2020 23:41:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55F822D2;\n\tThu, 13 Feb 2020 23:41:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581633697;\n\tbh=1yy7nCipavwTkdbIzmN/wxu8SnfixPsLN2VI6Iy0bHw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SXU5T8VTIvmhsYEjpW2+c4iU4QkjnXT0zpLPlJFz+pbp7Gn4VG/oX+Px1CXma7rvX\n\tiRYSZ0Eb275NhAT8EPSlj3c5pRninna7N4alldt1QZ1AjKNLenLJTXoqr1uS8dZoyq\n\t5M8oXMYuUreen75tsLhYi3S9d8bmAThQeSVPRysM=","Date":"Fri, 14 Feb 2020 00:41:20 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200213224120.GP29760@pendragon.ideasonboard.com>","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-5-kieran.bingham@ideasonboard.com>\n\t<20200206234244.GJ7611@pendragon.ideasonboard.com>\n\t<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 22:41:38 -0000"}},{"id":3752,"web_url":"https://patchwork.libcamera.org/comment/3752/","msgid":"<97c46978-fb83-637e-ea17-686a980b9b49@ideasonboard.com>","date":"2020-02-13T22:44:39","subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 13/02/2020 22:41, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Feb 13, 2020 at 10:38:03PM +0000, Kieran Bingham wrote:\n>> On 06/02/2020 23:42, Laurent Pinchart wrote:\n>>> On Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:\n>>>> Provide simple clean icons from https://feathericons.com/\n>>>> (https://github.com/feathericons/feather)\n>>>>\n>>>> These are provided under the MIT license.\n>>>\n>>> Could you add a copy of the license to licenses/ ?\n>>\n>> Looks like you've handled that with your licences series.\n>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> src/qcam/assets/feathericons/README.md | 5 +\n>>>> src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++\n>>>> src/qcam/assets/feathericons/*.svg | +\n>>>>\n>>>> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md\n>>>> new file mode 100644\n>>>> index 000000000000..ce7664f6bf16\n>>>> --- /dev/null\n>>>> +++ b/src/qcam/assets/feathericons/README.md\n>>>> @@ -0,0 +1,5 @@\n>>>> +Icons from https://feathericons.com/\n>>>> +License: MIT\n>>\n>> Perhaps I should set this as the SPDX, although that would then perhaps\n>> represent the README.md file ...?\n> \n> It would represent the README.md only, yes :-S\n> \n>>>> +\n>>>> +Generate the QRC file with:\n>>>> + rcc --project\n>>>> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg\n>>>> new file mode 100644\n>>>> index 000000000000..669a57a772fa\n>>>> --- /dev/null\n>>>> +++ b/src/qcam/assets/feathericons/activity.svg\n>>>> @@ -0,0 +1 @@\n>>>\n>>> Should we add an SPDX tag here ?\n>>>\n>>> \n>>\n>> I don't think we should modify the files just to put a licence statement\n>> in them no. They are an external import.\n> \n> I agree.\n> \n> The REUSE specification includes a way to specify licenses for files\n> that can't be modified, maybe we can use that.\n> \n>>>> +\n>>>> \\ No newline at end of file\n>>>>\n>>>> < Remaing icons chopped >\n>>>\n>>> Reviewed-by: Laurent Pinchart \n>>\n>> What are your thoughts on adding the full set, vs adding only the icons\n>> used in the series 'so far'.\n>>\n>> Adding the full set makes it easier to add functionality later and be\n>> able to identify what icons are available, but of course comes at the\n>> expense of storing more icons in the our repository ...\n> \n> It won't use much disk space, the icons are very small, but adding only\n> the icons we need has the nice advantage of quickly showing which files\n> are used (all of them). It's a bit like commented-out code, we usually\n> strip it. I think I'd be in favour of only adding the icons we use, but\n> it maybe not be difficult to convince me otherwise.\n\n\nI agree in general, but in this instance, it's more about ensuring a\ndeveloper can easily extend qcam, and identify what icons they have to\nwork with from an existing design set.\n\nI'm tempted to keep the icons in the assets location, but only specify\nicons that we /use/ in the QRC file (so that we're not storing all\nunused icons in the qcam binary itself).\n\nAnd even better in the future, get the qrc file generated from an array\nin meson...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBFB461A10\n\tfor ;\n\tThu, 13 Feb 2020 23:44:42 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 691772D2;\n\tThu, 13 Feb 2020 23:44:42 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581633882;\n\tbh=eOARzV4PzyWsGU1PLx9WM8pN1IwU4+fRDkX3rMfO3F0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=PbkY4oyI189V2B5mnehyexZaLxhp8O5+NRp+u7NLTw1Xx/PsuDBRhND1QhE/np/33\n\tUffcVgq78snpWIKPCCNOlfwn3MaoW8u5Tz5HuL/eBvnoUJBcHTwqdzKCvZLr2xIuek\n\tPkeXvPf0iaUFSM882KSOMvmsEOtTNP7hjcOgBCG0=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-5-kieran.bingham@ideasonboard.com>\n\t<20200206234244.GJ7611@pendragon.ideasonboard.com>\n\t<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>\n\t<20200213224120.GP29760@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<97c46978-fb83-637e-ea17-686a980b9b49@ideasonboard.com>","Date":"Thu, 13 Feb 2020 22:44:39 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200213224120.GP29760@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 22:44:43 -0000"}},{"id":3753,"web_url":"https://patchwork.libcamera.org/comment/3753/","msgid":"<20200213224530.GQ29760@pendragon.ideasonboard.com>","date":"2020-02-13T22:45:30","subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Feb 13, 2020 at 10:44:39PM +0000, Kieran Bingham wrote:\n> On 13/02/2020 22:41, Laurent Pinchart wrote:\n> > On Thu, Feb 13, 2020 at 10:38:03PM +0000, Kieran Bingham wrote:\n> >> On 06/02/2020 23:42, Laurent Pinchart wrote:\n> >>> On Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:\n> >>>> Provide simple clean icons from https://feathericons.com/\n> >>>> (https://github.com/feathericons/feather)\n> >>>>\n> >>>> These are provided under the MIT license.\n> >>>\n> >>> Could you add a copy of the license to licenses/ ?\n> >>\n> >> Looks like you've handled that with your licences series.\n> >>\n> >>>> Signed-off-by: Kieran Bingham \n> >>>> ---\n> >>>> src/qcam/assets/feathericons/README.md | 5 +\n> >>>> src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++\n> >>>> src/qcam/assets/feathericons/*.svg | +\n> >>>>\n> >>>> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md\n> >>>> new file mode 100644\n> >>>> index 000000000000..ce7664f6bf16\n> >>>> --- /dev/null\n> >>>> +++ b/src/qcam/assets/feathericons/README.md\n> >>>> @@ -0,0 +1,5 @@\n> >>>> +Icons from https://feathericons.com/\n> >>>> +License: MIT\n> >>\n> >> Perhaps I should set this as the SPDX, although that would then perhaps\n> >> represent the README.md file ...?\n> > \n> > It would represent the README.md only, yes :-S\n> > \n> >>>> +\n> >>>> +Generate the QRC file with:\n> >>>> + rcc --project\n> >>>> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg\n> >>>> new file mode 100644\n> >>>> index 000000000000..669a57a772fa\n> >>>> --- /dev/null\n> >>>> +++ b/src/qcam/assets/feathericons/activity.svg\n> >>>> @@ -0,0 +1 @@\n> >>>\n> >>> Should we add an SPDX tag here ?\n> >>>\n> >>> \n> >>\n> >> I don't think we should modify the files just to put a licence statement\n> >> in them no. They are an external import.\n> > \n> > I agree.\n> > \n> > The REUSE specification includes a way to specify licenses for files\n> > that can't be modified, maybe we can use that.\n> > \n> >>>> +\n> >>>> \\ No newline at end of file\n> >>>>\n> >>>> < Remaing icons chopped >\n> >>>\n> >>> Reviewed-by: Laurent Pinchart \n> >>\n> >> What are your thoughts on adding the full set, vs adding only the icons\n> >> used in the series 'so far'.\n> >>\n> >> Adding the full set makes it easier to add functionality later and be\n> >> able to identify what icons are available, but of course comes at the\n> >> expense of storing more icons in the our repository ...\n> > \n> > It won't use much disk space, the icons are very small, but adding only\n> > the icons we need has the nice advantage of quickly showing which files\n> > are used (all of them). It's a bit like commented-out code, we usually\n> > strip it. I think I'd be in favour of only adding the icons we use, but\n> > it maybe not be difficult to convince me otherwise.\n> \n> \n> I agree in general, but in this instance, it's more about ensuring a\n> developer can easily extend qcam, and identify what icons they have to\n> work with from an existing design set.\n> \n> I'm tempted to keep the icons in the assets location, but only specify\n> icons that we /use/ in the QRC file (so that we're not storing all\n> unused icons in the qcam binary itself).\n\nWorks for me.\n\n> And even better in the future, get the qrc file generated from an array\n> in meson...\n\nIf you have time to spare :-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59FE861A10\n\tfor ;\n\tThu, 13 Feb 2020 23:45:47 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0C402D2;\n\tThu, 13 Feb 2020 23:45:46 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581633947;\n\tbh=eLwRODCKyI2+Yv3+j5uPwzsho6JdwP3GzfEtxiensIQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dCqJEZfotjMBlSJAa7TGGxRsJJssVZi1irfYQ3qn3cTeA0uV+8NC3FLeOLGGxvise\n\taQbZHBdmjue9cCLwGpO3HVAzhRmdo6Bfu+yJhBwRDdJ/sAh3G5FCUtTBAYmKK8jeKY\n\t1R7H5UFY9/EUG2L7KHRsv5cgXY2Zb0zHy9FVuei0=","Date":"Fri, 14 Feb 2020 00:45:30 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200213224530.GQ29760@pendragon.ideasonboard.com>","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-5-kieran.bingham@ideasonboard.com>\n\t<20200206234244.GJ7611@pendragon.ideasonboard.com>\n\t<216b064b-9f34-e97e-3caf-f99142ca4332@ideasonboard.com>\n\t<20200213224120.GP29760@pendragon.ideasonboard.com>\n\t<97c46978-fb83-637e-ea17-686a980b9b49@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<97c46978-fb83-637e-ea17-686a980b9b49@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial\n\ticon set","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 22:45:47 -0000"}}]