[{"id":430,"web_url":"https://patchwork.libcamera.org/comment/430/","msgid":"<20190120230643.GA23038@pendragon.ideasonboard.com>","date":"2019-01-20T23:06:43","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Jan 20, 2019 at 03:04:35PM +0100, Niklas Söderlund wrote:\n> Extend the document of the intended usage of DeviceMatch need for\n\ns/document/documentation/\n\n> information to correctly function to find a uniquely identifiable media\n\nI'm not sure what you meant by the \"need for information to correctly\nfunction\".\n\n> device.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> ---\n> * Changes since v1\n> - Rephrased most of it after review comments from Laurent, Thanks!\n> \n>  src/libcamera/device_enumerator.cpp | 12 ++++++++++++\n>  1 file changed, 12 insertions(+)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 55c510e3b79a415b..d41e1e580b3451ab 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -52,6 +52,18 @@ namespace libcamera {\n>   *\n>   * The description is meant to be filled by pipeline managers and passed to a\n>   * device enumerator to find matching media devices.\n> + *\n> + * A DeviceMatch is created with a specific Linux device driver in mind,\n> + * therefore the name of the driver is a required property. One or more Entity\n> + * names can be added as as match criteria.\n\ns/as as/as/\n\n> + *\n> + * Pipeline handlers are recommended to add entities to DeviceMatch as\n> + * appropriare to ensure that the media device they need can be uniquely\n> + * identified. This is useful  when the corresponding kernel driver can produce\n\ns/  / /\n\n> + * different graphs, for instance as a result of different driver versions or\n> + * hardware configurations, and not all those graphs are suitable for a pipeline\n> + * handler.\n> + *\n\ns/^ \\*\\n//\n\nWith these fixed,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>   */\n>  \n>  /**","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86EF160C81\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jan 2019 00:06:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1F50F8B;\n\tMon, 21 Jan 2019 00:06:43 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548025604;\n\tbh=FC1wBxjiWp37IHg1NjBaGJukzibeqpRfJWtnpz7z5qc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Pa042twkXmMd/uHF14Odzn0hG2L6XkVLXiiihG6ccujdZWVN6IOpI2SyiaBcMJjqi\n\tCqmcHgtOWPzMOBL/0uXr8Ml3sHRe3RGyvPEOcj7Z/2jLdscdmGYS2G3TFBfHQXO5g3\n\tggfSxhyRy2zPjTIPQ6xUR2NuMN6vEHxkQwjppMzw=","Date":"Mon, 21 Jan 2019 01:06:43 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190120230643.GA23038@pendragon.ideasonboard.com>","References":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 20 Jan 2019 23:06:44 -0000"}},{"id":486,"web_url":"https://patchwork.libcamera.org/comment/486/","msgid":"<20190122125808.GO6484@bigcity.dyn.berto.se>","date":"2019-01-22T12:58:08","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nOn 2019-01-21 01:06:43 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Sun, Jan 20, 2019 at 03:04:35PM +0100, Niklas Söderlund wrote:\n> > Extend the document of the intended usage of DeviceMatch need for\n> \n> s/document/documentation/\n> \n> > information to correctly function to find a uniquely identifiable media\n> \n> I'm not sure what you meant by the \"need for information to correctly\n> function\".\n\nHow about,\n\nExtend the documentation of the intended usage of DeviceMatch. The \nDeviceMatch needs enough information to be able to uniquely identify a \nspecific media device.\n\n> \n> > device.\n> > \n> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> > ---\n> > * Changes since v1\n> > - Rephrased most of it after review comments from Laurent, Thanks!\n> > \n> >  src/libcamera/device_enumerator.cpp | 12 ++++++++++++\n> >  1 file changed, 12 insertions(+)\n> > \n> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > index 55c510e3b79a415b..d41e1e580b3451ab 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> > @@ -52,6 +52,18 @@ namespace libcamera {\n> >   *\n> >   * The description is meant to be filled by pipeline managers and passed to a\n> >   * device enumerator to find matching media devices.\n> > + *\n> > + * A DeviceMatch is created with a specific Linux device driver in mind,\n> > + * therefore the name of the driver is a required property. One or more Entity\n> > + * names can be added as as match criteria.\n> \n> s/as as/as/\n> \n> > + *\n> > + * Pipeline handlers are recommended to add entities to DeviceMatch as\n> > + * appropriare to ensure that the media device they need can be uniquely\n> > + * identified. This is useful  when the corresponding kernel driver can produce\n> \n> s/  / /\n> \n> > + * different graphs, for instance as a result of different driver versions or\n> > + * hardware configurations, and not all those graphs are suitable for a pipeline\n> > + * handler.\n> > + *\n> \n> s/^ \\*\\n//\n> \n> With these fixed,\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> >   */\n> >  \n> >  /**\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B3C560C65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jan 2019 13:58:11 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id x85-v6so20552003ljb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jan 2019 04:58:11 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tw4sm1799427lfk.83.2019.01.22.04.58.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 22 Jan 2019 04:58:09 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=h1AUWsYnijsa3uqOCsIZTtXyfOouB5oLxrPyWmcXJUc=;\n\tb=JqYaBfQKP3ZzYmKzLzX8KwDfiCRMsWPJ9nVtDTb/2161al/pGyIJRU3CWOoCydx7YL\n\t9F/RYWIBGnFirRem53uYmoatTXDidE3SjgvGk8C0eAHysnaDWGyc+TUVnLIZ3XCGEsx4\n\tvnLkWChy0HIMG+oRd+frja8HaktdqDqqECalTRJlO+X3esCy/XxTxHeCtcjJd+Nd4dX5\n\tT7ViigKIggVtHj1GJYPRV+0RQBum14bdYDtufRrEOG/8Sfq08pgA0Qf/Cgg8p2gEPvrZ\n\t4tZQc3mHAsxR921ezAD6A7IGXgImlILd32wjYMY7X4wcvavcdck2tWFnwE5NY+76/J5E\n\tymcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=h1AUWsYnijsa3uqOCsIZTtXyfOouB5oLxrPyWmcXJUc=;\n\tb=PwXekPnFmzQttDG0kKGfbQ6FvJDGxFRxvzpuV7beSMoSOBmBLITSWNcVUUBQ3k+i6I\n\tJKEDMZxeEgBhEkr+Kmh8cqM47YQ6d8L4RCHMdtxx4JqleAiWPHXJA5wCrEvjmjeAQ+ct\n\tmfuEDJ0NANViAIiBO/eCShLCFivCGNS9MnuW5OuB160kxmOrxGNxR9ZEkk1l6+UIBqSp\n\tS3TLQ+b6ntz5xD7BmmfQKOmGL5PvTwylH8kvHn2vz87ZaJTvt+YhrSaGqdl+w2/MjO4e\n\txauep1d2E03Gi15Nvv9bzooVtJh9/kTvEixsxuB0jIIDKSXb7vEmvO2x9ZZMsbuZ8a3S\n\tl8IQ==","X-Gm-Message-State":"AJcUukd8exYdUeBF0dDaMrDFe8S56lNhd+GAoaTFQ8WDqXnN+NRbX9s0\n\tEoTTrrFV3g7E4h/bLDy3UGrBWC4nlew=","X-Google-Smtp-Source":"ALg8bN7tPO2kN8pHp5Xm7NdWLmkcBfAnZ12QWAx5BYVqouZB2pSO5uhkApMGg43C+3mA9irFyeaLsQ==","X-Received":"by 2002:a2e:2b8d:: with SMTP id\n\tr13-v6mr20616657ljr.79.1548161890549; \n\tTue, 22 Jan 2019 04:58:10 -0800 (PST)","Date":"Tue, 22 Jan 2019 13:58:08 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122125808.GO6484@bigcity.dyn.berto.se>","References":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>\n\t<20190120230643.GA23038@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190120230643.GA23038@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 22 Jan 2019 12:58:11 -0000"}},{"id":492,"web_url":"https://patchwork.libcamera.org/comment/492/","msgid":"<20190122135055.GE4455@pendragon.ideasonboard.com>","date":"2019-01-22T13:50:55","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Tue, Jan 22, 2019 at 01:58:08PM +0100, Niklas Söderlund wrote:\n> On 2019-01-21 01:06:43 +0200, Laurent Pinchart wrote:\n> > On Sun, Jan 20, 2019 at 03:04:35PM +0100, Niklas Söderlund wrote:\n> >> Extend the document of the intended usage of DeviceMatch need for\n> > \n> > s/document/documentation/\n> > \n> >> information to correctly function to find a uniquely identifiable media\n> > \n> > I'm not sure what you meant by the \"need for information to correctly\n> > function\".\n> \n> How about,\n> \n> Extend the documentation of the intended usage of DeviceMatch. The \n> DeviceMatch needs enough information to be able to uniquely identify a \n> specific media device.\n\nMuch better, thanks.\n\n> >> device.\n> >> \n> >> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> >> ---\n> >> * Changes since v1\n> >> - Rephrased most of it after review comments from Laurent, Thanks!\n> >> \n> >>  src/libcamera/device_enumerator.cpp | 12 ++++++++++++\n> >>  1 file changed, 12 insertions(+)\n> >> \n> >> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> >> index 55c510e3b79a415b..d41e1e580b3451ab 100644\n> >> --- a/src/libcamera/device_enumerator.cpp\n> >> +++ b/src/libcamera/device_enumerator.cpp\n> >> @@ -52,6 +52,18 @@ namespace libcamera {\n> >>   *\n> >>   * The description is meant to be filled by pipeline managers and passed to a\n> >>   * device enumerator to find matching media devices.\n> >> + *\n> >> + * A DeviceMatch is created with a specific Linux device driver in mind,\n> >> + * therefore the name of the driver is a required property. One or more Entity\n> >> + * names can be added as as match criteria.\n> > \n> > s/as as/as/\n> > \n> >> + *\n> >> + * Pipeline handlers are recommended to add entities to DeviceMatch as\n> >> + * appropriare to ensure that the media device they need can be uniquely\n> >> + * identified. This is useful  when the corresponding kernel driver can produce\n> > \n> > s/  / /\n> > \n> >> + * different graphs, for instance as a result of different driver versions or\n> >> + * hardware configurations, and not all those graphs are suitable for a pipeline\n> >> + * handler.\n> >> + *\n> > \n> > s/^ \\*\\n//\n> > \n> > With these fixed,\n> > \n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> >>   */\n> >>  \n> >>  /**","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 139DE60B1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jan 2019 14:50:56 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yyyyyyyyyyyyyby-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00::2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89E3353E;\n\tTue, 22 Jan 2019 14:50:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548165055;\n\tbh=31yeVWhfX6pOPxXsQZ3LF6elCKFf50MDLAKTWGRYru8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=K77wDV/L4REkmrkOaRdDVvKExmQWK+o9XJoz8HVIVLfmywFBawcRY7h0pEw4ZCxMI\n\txDh5H3jY8Evef5V3qnoBJKaUWU33AmKAq6Q6+jlIeEStkbsYu2Uw206o9KUSwjMfxh\n\t0n2En3o6F57MNWa2t/5EMsQGQXVZ+TFvvDhnoCnQ=","Date":"Tue, 22 Jan 2019 15:50:55 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122135055.GE4455@pendragon.ideasonboard.com>","References":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>\n\t<20190120230643.GA23038@pendragon.ideasonboard.com>\n\t<20190122125808.GO6484@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190122125808.GO6484@bigcity.dyn.berto.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 22 Jan 2019 13:50:56 -0000"}},{"id":495,"web_url":"https://patchwork.libcamera.org/comment/495/","msgid":"<20190122140713.GB4127@bigcity.dyn.berto.se>","date":"2019-01-22T14:07:14","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello,\n\nOn 2019-01-22 15:50:55 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> On Tue, Jan 22, 2019 at 01:58:08PM +0100, Niklas Söderlund wrote:\n> > On 2019-01-21 01:06:43 +0200, Laurent Pinchart wrote:\n> > > On Sun, Jan 20, 2019 at 03:04:35PM +0100, Niklas Söderlund wrote:\n> > >> Extend the document of the intended usage of DeviceMatch need for\n> > > \n> > > s/document/documentation/\n> > > \n> > >> information to correctly function to find a uniquely identifiable media\n> > > \n> > > I'm not sure what you meant by the \"need for information to correctly\n> > > function\".\n> > \n> > How about,\n> > \n> > Extend the documentation of the intended usage of DeviceMatch. The \n> > DeviceMatch needs enough information to be able to uniquely identify a \n> > specific media device.\n> \n> Much better, thanks.\n\nThanks,\n\nThis patch is now merged to master.\n\n> \n> > >> device.\n> > >> \n> > >> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> > >> ---\n> > >> * Changes since v1\n> > >> - Rephrased most of it after review comments from Laurent, Thanks!\n> > >> \n> > >>  src/libcamera/device_enumerator.cpp | 12 ++++++++++++\n> > >>  1 file changed, 12 insertions(+)\n> > >> \n> > >> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > >> index 55c510e3b79a415b..d41e1e580b3451ab 100644\n> > >> --- a/src/libcamera/device_enumerator.cpp\n> > >> +++ b/src/libcamera/device_enumerator.cpp\n> > >> @@ -52,6 +52,18 @@ namespace libcamera {\n> > >>   *\n> > >>   * The description is meant to be filled by pipeline managers and passed to a\n> > >>   * device enumerator to find matching media devices.\n> > >> + *\n> > >> + * A DeviceMatch is created with a specific Linux device driver in mind,\n> > >> + * therefore the name of the driver is a required property. One or more Entity\n> > >> + * names can be added as as match criteria.\n> > > \n> > > s/as as/as/\n> > > \n> > >> + *\n> > >> + * Pipeline handlers are recommended to add entities to DeviceMatch as\n> > >> + * appropriare to ensure that the media device they need can be uniquely\n> > >> + * identified. This is useful  when the corresponding kernel driver can produce\n> > > \n> > > s/  / /\n> > > \n> > >> + * different graphs, for instance as a result of different driver versions or\n> > >> + * hardware configurations, and not all those graphs are suitable for a pipeline\n> > >> + * handler.\n> > >> + *\n> > > \n> > > s/^ \\*\\n//\n> > > \n> > > With these fixed,\n> > > \n> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > \n> > >>   */\n> > >>  \n> > >>  /**\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8C0C60B1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jan 2019 15:07:15 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id g11-v6so20724236ljk.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jan 2019 06:07:15 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tz7-v6sm23439lji.42.2019.01.22.06.07.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 22 Jan 2019 06:07:14 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=BlnqJSK2viIOQm2k50o9K7iK6hkUv+ueCmCzMBajyYU=;\n\tb=qZozznp20ByX2Fl2NWcMa+0/i6M1x07grAvicdFK1Hqicm3uR76k1q4mTHfZEkUkLm\n\tyXPbayKVtRuTrhO/ANY2RIyO2UxREJMD/HW5RmOA1sVYBsjaFvse4wpdErm++A5VCjOc\n\tFFKQCdBLbGm6SqIUWxjwai1dl5ckEFJ3m9s2p5rd6a0YrQ5JiXRhR9RofLe+RGlq2sqR\n\tubFyuujsWAG8fztUZLOnRQwLfTgpMdzda+KtuSga1q7xtiijGgTos0IkXLeI5znA1O1K\n\tI2zlJEU3iENqnj3WwsV3Qu/PhwTZMFL1Cp5+uUvatofuHS9MUNphABKuZCStcOVnxdkT\n\tOIQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=BlnqJSK2viIOQm2k50o9K7iK6hkUv+ueCmCzMBajyYU=;\n\tb=FfGfGcHIMVqPc45lyr9yi54CtbqCciZhM37YxCqCR8DZCrzzOfGWLy8ZuquraySq60\n\t6glRN54gQzXGF4szqIX+pdOx5sIVx0Bp+8B4FoBdPSaY+zoTTyZr3Zn90sv2Gs9eQ9Yt\n\tdbkvqMcSSFnxRGog6BJY0RXB8xRCDpRwPVVLqCXh5WhmlJ1e8+qTNmTpUdhxHvq5HVHJ\n\tpThN11XeJhYRXBbQDaNZdZuSneikYLDYdyMZzEh7UIPvV9dgtqCONSehmVGnZ/v2uQol\n\tcRGgOExy4Em8Y2wstyT1LQE+vg8Y+DNScSf/bYsXsaae3Q3hDVMGIFnW7h33yeP3uqV9\n\tEz6g==","X-Gm-Message-State":"AJcUukdEN2Kff6JqYeeLNbdJikf1AjkvJGKBVItEZPPa4nbRPFJXDmdH\n\toTLPxvlcxSsWg0SLM/wmPZal1Wox9iI=","X-Google-Smtp-Source":"ALg8bN61D9LMGMhJbu+QC36haMKteDfANUNNYVh0joqsevyU/OfOB8oVyNOUrtSKwnOHTJAaPzXxgw==","X-Received":"by 2002:a2e:2e1a:: with SMTP id\n\tu26-v6mr22625749lju.8.1548166035089; \n\tTue, 22 Jan 2019 06:07:15 -0800 (PST)","Date":"Tue, 22 Jan 2019 15:07:14 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122140713.GB4127@bigcity.dyn.berto.se>","References":"<20190120140435.23252-1-niklas.soderlund@ragnatech.se>\n\t<20190120230643.GA23038@pendragon.ideasonboard.com>\n\t<20190122125808.GO6484@bigcity.dyn.berto.se>\n\t<20190122135055.GE4455@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190122135055.GE4455@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator:\n\textend documentation of DeviceMatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 22 Jan 2019 14:07:16 -0000"}}]