[{"id":3627,"web_url":"https://patchwork.libcamera.org/comment/3627/","msgid":"<20200206220652.GH7611@pendragon.ideasonboard.com>","date":"2020-02-06T22:06:52","subject":"Re: [libcamera-devel] [PATCH 2/6] qcam: Expose quit method for\n\tMainWindow","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 06, 2020 at 03:05:00PM +0000, Kieran Bingham wrote:\n> Provide a method to facilitate clean shutdowns.\n> \n> Signed-off-by: Kieran Bingham \n\nProvided this is useful in a subsequent patch,\n\nReviewed-by: Laurent Pinchart \n\nBut I think you can squash it with the patch that uses it.\n\n> ---\n> src/qcam/main_window.cpp | 9 +++++++--\n> src/qcam/main_window.h | 1 +\n> 2 files changed, 8 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 38bc04a23b86..b51a16de199d 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -41,8 +41,7 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \t}\n> \n> \tif (ret < 0)\n> -\t\tQTimer::singleShot(0, QCoreApplication::instance(),\n> -\t\t\t\t &QCoreApplication::quit);\n> +\t\tquit();\n> }\n> \n> MainWindow::~MainWindow()\n> @@ -54,6 +53,12 @@ MainWindow::~MainWindow()\n> \t}\n> }\n> \n> +void MainWindow::quit()\n> +{\n> +\tQTimer::singleShot(0, QCoreApplication::instance(),\n> +\t\t\t &QCoreApplication::quit);\n> +}\n> +\n> void MainWindow::updateTitle()\n> {\n> \tunsigned int duration = frameRateInterval_.elapsed();\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 04fb9e3ea869..a11443b30b37 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -41,6 +41,7 @@ public:\n> \t~MainWindow();\n> \n> private Q_SLOTS:\n> +\tvoid quit();\n> \tvoid updateTitle();\n> \n> private:\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E4BA60864\n\tfor ;\n\tThu, 6 Feb 2020 23:07:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51918B7D;\n\tThu, 6 Feb 2020 23:07:13 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581026833;\n\tbh=8E7aN1ghO65I3+u5UQhKDmES4CAZ9PY//ZU8zhM/Mas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=etwKwsaF0Ao7yPHITotXx3IWtYgFz3oobDe1dbpQLBljZDSKQzw53hU4PAieUCKdC\n\tFqlteEMtJOUzZ1IgxzNuckVvxdk+JrHlr6lRif9HJsgxADBedzJsb8PPvk/h56z/56\n\t4RTmPhwpiIv2dA/DyyCmDMCgEc8N76jXQeArud0Q=","Date":"Fri, 7 Feb 2020 00:06:52 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200206220652.GH7611@pendragon.ideasonboard.com>","References":"<20200206150504.24204-1-kieran.bingham@ideasonboard.com>\n\t<20200206150504.24204-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200206150504.24204-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/6] qcam: Expose quit method for\n\tMainWindow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Feb 2020 22:07:14 -0000"}}]