{"id":2780,"url":"https://patchwork.libcamera.org/api/patches/2780/?format=json","web_url":"https://patchwork.libcamera.org/patch/2780/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200206012601.153858-5-jacopo@jmondi.org>","date":"2020-02-06T01:25:56","name":"[libcamera-devel,v5,4/9] libcamera: properties: Add rotation property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d3f3ea94ad7332796a6ef9f28191d61dfb7d4aff","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2780/mbox/","series":[{"id":662,"url":"https://patchwork.libcamera.org/api/series/662/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=662","date":"2020-02-06T01:25:52","name":"Introduce camera properties","version":5,"mbox":"https://patchwork.libcamera.org/series/662/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2780/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2780/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8BC260446\n\tfor ;\n\tThu, 6 Feb 2020 02:23:34 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 92766240002\n\tfor ;\n\tThu, 6 Feb 2020 01:23:34 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 6 Feb 2020 02:25:56 +0100","Message-Id":"<20200206012601.153858-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200206012601.153858-1-jacopo@jmondi.org>","References":"<20200206012601.153858-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 4/9] libcamera: properties: Add\n\trotation property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Feb 2020 01:23:35 -0000"},"content":"The rotation property describes the rotation of the camera sensor.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/property_ids.yaml | 329 ++++++++++++++++++++++++++++++++\n 1 file changed, 329 insertions(+)","diff":"diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex f384e5205ef6..c3070de9d9f8 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -25,4 +25,333 @@ controls:\n description: |\n The camera is attached to the device in a way that allows it to\n be moved freely\n+\n+ - Rotation:\n+ type: int32_t\n+ description: |\n+ The camera rotation is expressed as the angular difference in degrees\n+ between two reference systems, one relative to the camera module\n+ intrinsics characteristics, and one artificially defined on the external\n+ world scene to be captured when projected on the image sensor pixel\n+ array.\n+\n+ A camera sensor has a 2-dimensional reference system 'Rc' defined by\n+ its pixel array read-out order. The origin is set to the first pixel\n+ being read out, the X-axis points along the column read-out direction\n+ towards the last columns, and the Y-axis along the row read-out\n+ direction towards the last row.\n+\n+ A typical example for a sensor with a 2592x1944 pixel array matrix\n+ observed from the front is\n+\n+ 2591 X-axis 0\n+ <------------------------+ 0\n+ .......... ... ..........!\n+ .......... ... ..........! Y-axis\n+ ... !\n+ .......... ... ..........!\n+ .......... ... ..........! 1943\n+ V\n+\n+\n+ The external world scene reference system 'Rs' is a 2-dimensional\n+ reference system on the focal plane of the camera module. The origin is\n+ placed on the top-left corner of the visible scene, the X-axis points\n+ towards the right, and the Y-axis points towards the bottom of the\n+ scene. The top, bottom, left and right directions are intentionally not\n+ defined and depend on the environment in which the camera is used.\n+\n+ A typical example of a (very common) picture of a shark swimming from\n+ left to right, as seen from the camera, is\n+\n+ 0 X-axis\n+ 0 +------------------------------------>\n+ !\n+ !\n+ ! |\\____)\\___\n+ ! ) _____ __`<\n+ ! |/ )/\n+ !\n+ V\n+ Y-axis\n+\n+ With the reference system 'Rs' placed on the camera focal plane.\n+\n+ !\n+ / !\n+ / !\n+ / !\n+ _ / !\n+ +-/ \\-+ / !\n+ | (o) | ! Camera focal plane\n+ +-----+ \\ !\n+ \\ !\n+ \\ !\n+ \\ !\n+ \\ !\n+ !\n+\n+ When projected on the sensor's pixel array, the image and the associated\n+ reference system 'Rs' are typically (but not always) inverted, due to\n+ the camera module's lens optical inversion effect.\n+\n+ Assuming the above represented scene of the swimming shark, the lens\n+ inversion projects the scene and its reference system onto the sensor\n+ pixel array, seen from the front of the camera sensor, as follow\n+\n+ Y-axis\n+ ^\n+ !\n+ ! |\\_____)\\__\n+ ! ) ____ ___.<\n+ ! |/ )/\n+ !\n+ !\n+ 0 +------------------------------------>\n+ 0 X-axis\n+\n+ Note the shark being upside-down.\n+\n+ The resulting projected reference system is named 'Rp'.\n+\n+ The camera rotation property is then defined as the angular difference\n+ in the counterclockwise direction between the camera reference system\n+ 'Rc' and the projected scene reference system 'Rp'. It is expressed in\n+ degrees as a number in the range [0, 360[.\n+\n+ Examples\n+\n+ 0 degrees camera rotation\n+\n+\n+ Y-Rp\n+ ^\n+ !\n+ Y-Rc !\n+ ^ !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------>\n+ ! 0 X-Rp\n+ 0 +------------------------------------>\n+ 0 X-Rc\n+\n+\n+ X-Rc 0\n+ <------------------------------------+ 0\n+ !\n+ X-Rp 0 !\n+ <------------------------------------+ 0 !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rc\n+ !\n+ V\n+ Y-Rp\n+\n+ 90 degrees camera rotation\n+\n+ 0 Y-Rc\n+ 0 +----------------------->\n+ !\n+ ! Y-Rp\n+ ! ^\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------>\n+ ! 0 X-Rp\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+ 180 degrees camera rotation\n+\n+ 0\n+ <-----------------------------------+ 0\n+ X-Rc !\n+ y-Rp !\n+ ^ !\n+ ! ! Y-Rc\n+ ! !\n+ ! !\n+ ! V\n+ !\n+ 0 +------------------------------------>\n+ 0 X-Rp\n+\n+ 270 degrees camera rotation\n+\n+ 0 Y-Rc\n+ 0 +----------------------->\n+ ! 0\n+ ! <-----------------------------------+ 0\n+ ! X-Rc !\n+ ! !\n+ ! !\n+ ! !\n+ ! !\n+ ! V\n+ ! Y-Rp\n+ !\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+\n+ Example one - Webcam\n+\n+ A camera module installed on the user facing part of a laptop screen\n+ casing used for video calls. The captured images are meant to be\n+ displayed in landscape mode (width > height) on the laptop screen.\n+\n+ The camera is typically mounted upside-down to compensate the lens\n+ optical inversion effect.\n+\n+ Y-Rp\n+ Y-Rc ^\n+ ^ !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! 0 +------------------------------------->\n+ ! 0 X-Rp\n+ 0 +------------------------------------->\n+ 0 X-Rc\n+\n+ The two reference systems are aligned, the resulting camera rotation is\n+ 0 degrees, no rotation correction needs to be applied to the resulting\n+ image once captured to memory buffers to correctly display it to users.\n+\n+ +--------------------------+\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ +--------------------------+\n+\n+ If the camera sensor is not mounted upside-down to compensate for the\n+ lens optical inversion, the two reference systems will not be aligned,\n+ with 'Rp' being rotated 180 degrees relatively to 'Rc'.\n+\n+\n+ X-Rc 0\n+ <------------------------------------+ 0\n+ Y-Rp !\n+ ^ !\n+ ! ! Y-Rc\n+ ! |\\_____)\\__ !\n+ ! ) ____ ___.< !\n+ ! |/ )/ !\n+ ! V\n+ !\n+ 0 +------------------------------------->\n+ 0 X-Rp\n+\n+ The image once captured to memory will then be rotated by 180 degrees\n+\n+ +--------------------------------------+\n+ ! !\n+ ! __/(_____/| !\n+ ! >.___ ____ ( !\n+ ! \\( \\| !\n+ ! !\n+ +--------------------------------------+\n+\n+ A software rotation correction of 180 degrees should be applied to\n+ correctly display the image.\n+\n+ +--------------------------------------+\n+ ! !\n+ ! |\\____)\\___ !\n+ ! ) _____ __`< !\n+ ! |/ )/ !\n+ ! !\n+ +--------------------------------------+\n+\n+ Example two - Phone camera\n+\n+ A camera installed on the back side of a mobile device facing away from\n+ the user. The captured images are meant to be displayed in portrait mode\n+ (height > width) to match the device screen orientation and the device\n+ usage orientation used when taking the picture.\n+\n+ The camera sensor is typically mounted with its pixel array longer side\n+ aligned to the device longer side, upside-down mounted to compensate for\n+ the lens optical inversion effect.\n+\n+ 0 Y-Rc\n+ 0 +-------------------------->\n+ ! Y-Rp\n+ ! ^\n+ ! !\n+ ! !\n+ ! ! |\\_____)\\__\n+ ! ! ) ____ ___.<\n+ ! ! |/ )/\n+ ! !\n+ ! !\n+ ! !\n+ ! 0 +---------------------------------->\n+ ! 0 X-Rp\n+ !\n+ !\n+ !\n+ !\n+ V\n+ X-Rc\n+\n+ The two reference systems are not aligned and the 'Rp' reference\n+ system is rotated by 90 degrees in the counterclockwise direction\n+ relatively to the 'Rc' reference system.\n+\n+ The image once captured to memory will be rotated.\n+\n+ +-----------------------------------------------------+\n+ | _ _ |\n+ | \\ / |\n+ | | | |\n+ | | | |\n+ | | > |\n+ | < | |\n+ | | | |\n+ | . |\n+ | V |\n+ +-----------------------------------------------------+\n+\n+ A correction of 90 degrees in counterclockwise direction has to be\n+ applied to correctly display the image in portrait mode on the device\n+ screen.\n+\n+ +---------------+\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\\____)\\___ |\n+ | ) _____ __`< |\n+ | |/ )/ |\n+ | |\n+ | |\n+ | |\n+ | |\n+ | |\n+ +---------------+\n ...\n","prefixes":["libcamera-devel","v5","4/9"]}