[{"id":3623,"web_url":"https://patchwork.libcamera.org/comment/3623/","msgid":"<20200206203525.GE7611@pendragon.ideasonboard.com>","date":"2020-02-06T20:35:25","subject":"Re: [libcamera-devel] [PATCH 5/5] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Feb 05, 2020 at 01:04:20PM +0000, Kieran Bingham wrote:\n> The tests declare a hard-coded LIBCAMERA_IPA_MODULE_PATH to allow tests\n> to run from the test-suite.\n> \n> This requires tests to be run only from the root of the build directory,\n> otherwise (for example, by running in their local directory) they will\n> not be able to correctly locate the IPA modules.\n> \n> Now that the build path for the IPA manager is provided through the\n> RUNPATH, we can remove the redundant setting of the\n> LIBCAMERA_IPA_MODULE_PATH for tests.\n> \n> Signed-off-by: Kieran Bingham \n\nI really like this.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/libtest/test.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\n> index 333d2160e276..6cd3fbe6df06 100644\n> --- a/test/libtest/test.cpp\n> +++ b/test/libtest/test.cpp\n> @@ -21,10 +21,6 @@ int Test::execute()\n> {\n> \tint ret;\n> \n> -\tret = setenv(\"LIBCAMERA_IPA_MODULE_PATH\", \"src/ipa\", 1);\n> -\tif (ret)\n> -\t\treturn errno;\n> -\n> \tret = setenv(\"LIBCAMERA_IPA_PROXY_PATH\", \"src/libcamera/proxy/worker\", 1);\n> \tif (ret)\n> \t\treturn errno;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2671060864\n\tfor ;\n\tThu, 6 Feb 2020 21:35:41 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDCB09F0;\n\tThu, 6 Feb 2020 21:35:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581021340;\n\tbh=M2B4GgqaSWqTSjsg2I+VQ83D9B+LR6PZWCNBYOLSztA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PsGeLUEyrX4wrHtbDZjbM/bN2ogCjP3Ufc1JFbT2/THGvKYlvWm5rkzC4jYECledD\n\tKLqNUzQyNSOhnYYWtgYT6ylzrHySHGmmeh+MMe3fhm+3mXf9egiYHaAfRUy3UoxaXC\n\txsekg3O10df2/kd4zm/xfiIH4eI46OrFSR2j65C0=","Date":"Thu, 6 Feb 2020 22:35:25 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200206203525.GE7611@pendragon.ideasonboard.com>","References":"<20200205130420.8736-1-kieran.bingham@ideasonboard.com>\n\t<20200205130420.8736-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200205130420.8736-6-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] tests: Remove IPA_MODULE_PATH\n\tenvironment variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Feb 2020 20:35:41 -0000"}}]