[{"id":3618,"web_url":"https://patchwork.libcamera.org/comment/3618/","msgid":"<7ae7377a-5c7a-5e42-a8ce-c1b1e52d65b6@ideasonboard.com>","date":"2020-02-06T16:10:41","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2_videodevice: Add\n\tcrop/selection control.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 04/02/2020 11:24, Naushir Patuck wrote:\n> Add control for cropping/selection on a V4L2 video device through\n> the VIDIOC_S_SELECTION ioctl. This is similar to the existing cropping\n> control available on V4L2 sub-devices.\n\nI would have said that ideally this should come with an implementation\nto test it, but I'm not sure how easy it is to test crop/selection\ncontrol, perhaps vimc/vivid would give us a means to do so.\n\nBut that said, I don't think the crop/compose for the subdevs have tests\neither, so I don't think that's a blocker at the moment, except for the\nfact that this has no users in the code base, though I suspect there\nwill be one soon enough.\n\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/include/v4l2_videodevice.h | 5 +++\n> src/libcamera/v4l2_videodevice.cpp | 48 ++++++++++++++++++++++++\n> 2 files changed, 53 insertions(+)\n> \n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index e4d35ab..fcf0726 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -182,6 +182,9 @@ public:\n> \tint setFormat(V4L2DeviceFormat *format);\n> \tImageFormats formats();\n> \n> +\tint setCrop(Rectangle *rect);\n> +\tint setCompose(Rectangle *rect);\n> +\n> \tint exportBuffers(unsigned int count,\n> \t\t\t std::vector> *buffers);\n> \tint importBuffers(unsigned int count);\n> @@ -216,6 +219,8 @@ private:\n> \tstd::vector enumPixelformats();\n> \tstd::vector enumSizes(unsigned int pixelFormat);\n> \n> +\tint setSelection(unsigned int target, Rectangle *rect);\n> +\n> \tint requestBuffers(unsigned int count);\n> \tstd::unique_ptr createBuffer(const struct v4l2_buffer &buf);\n> \tFileDescriptor exportDmabufFd(unsigned int index, unsigned int plane);\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 8226773..f3c66ed 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -940,6 +940,54 @@ std::vector V4L2VideoDevice::enumSizes(unsigned int pixelFormat)\n> \treturn sizes;\n> }\n> \n> +/**\n> + * \\brief Set a crop rectangle on the V4L2 video device node\n> + * \\param[inout] rect The rectangle describing the crop target area\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int V4L2VideoDevice::setCrop(Rectangle *rect)\n> +{\n> +\treturn setSelection(V4L2_SEL_TGT_CROP, rect);\n> +}\n> +\n> +/**\n> + * \\brief Set a compose rectangle on the V4L2 video device node\n> + * \\param[inout] rect The rectangle describing the compose target area\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int V4L2VideoDevice::setCompose(Rectangle *rect)\n> +{\n> +\treturn setSelection(V4L2_SEL_TGT_COMPOSE, rect);\n> +}\n> +\n> +int V4L2VideoDevice::setSelection(unsigned int target, Rectangle *rect)\n> +{\n> +\tstruct v4l2_selection sel = {};\n> +\n> +\tsel.type = bufferType_;\n> +\tsel.target = target;\n> +\tsel.flags = 0;\n> +\n> +\tsel.r.left = rect->x;\n> +\tsel.r.top = rect->y;\n> +\tsel.r.width = rect->w;\n> +\tsel.r.height = rect->h;\n> +\n> +\tint ret = ioctl(VIDIOC_S_SELECTION, &sel);\n> +\tif (ret < 0) {\n> +\t\tLOG(V4L2, Error) << \"Unable to set rectangle \" << target\n> +\t\t\t\t << \": \" << strerror(-ret);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\trect->x = sel.r.left;\n> +\trect->y = sel.r.top;\n> +\trect->w = sel.r.width;\n> +\trect->h = sel.r.height;\n> +\n> +\treturn 0;\n> +}\n> +\n> int V4L2VideoDevice::requestBuffers(unsigned int count)\n> {\n> \tstruct v4l2_requestbuffers rb = {};\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CF2B60902\n\tfor ;\n\tThu, 6 Feb 2020 17:10:44 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07C7A9F0;\n\tThu, 6 Feb 2020 17:10:43 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581005444;\n\tbh=IWmLE+LnePJqqs2yax7QVILNNHfdPJDw9ZBN1rrExEo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LjCiZyUpEpDqCHZaFtAuqUfWp1IZoaKaJCRlFlB8J4FYz6RiuEw5l11nQOAWMicZI\n\tlzy6D6CnV7F+NYqRiGnO3eQeTqzY1MWr7f4S+N3KGgn1cjs9m/iiaGweFYyCvDCppb\n\tVEDXEdwpuaNLfEJd/O8bN52OsE4dmRqCLg1kmQSE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200204112444.8395-1-naush@raspberrypi.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7ae7377a-5c7a-5e42-a8ce-c1b1e52d65b6@ideasonboard.com>","Date":"Thu, 6 Feb 2020 16:10:41 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200204112444.8395-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2_videodevice: Add\n\tcrop/selection control.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Feb 2020 16:10:44 -0000"}},{"id":3745,"web_url":"https://patchwork.libcamera.org/comment/3745/","msgid":"<20200213203118.GM29760@pendragon.ideasonboard.com>","date":"2020-02-13T20:31:18","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2_videodevice: Add\n\tcrop/selection control.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Feb 04, 2020 at 11:24:44AM +0000, Naushir Patuck wrote:\n> Add control for cropping/selection on a V4L2 video device through\n> the VIDIOC_S_SELECTION ioctl. This is similar to the existing cropping\n> control available on V4L2 sub-devices.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Jacopo Mondi \n\nWith the period at the end of the commit subject removed,\n\nReviewed-by: Laurent Pinchart \n\nand pushed to the master branch.\n\n> ---\n> src/libcamera/include/v4l2_videodevice.h | 5 +++\n> src/libcamera/v4l2_videodevice.cpp | 48 ++++++++++++++++++++++++\n> 2 files changed, 53 insertions(+)\n> \n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index e4d35ab..fcf0726 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -182,6 +182,9 @@ public:\n> \tint setFormat(V4L2DeviceFormat *format);\n> \tImageFormats formats();\n> \n> +\tint setCrop(Rectangle *rect);\n> +\tint setCompose(Rectangle *rect);\n> +\n> \tint exportBuffers(unsigned int count,\n> \t\t\t std::vector> *buffers);\n> \tint importBuffers(unsigned int count);\n> @@ -216,6 +219,8 @@ private:\n> \tstd::vector enumPixelformats();\n> \tstd::vector enumSizes(unsigned int pixelFormat);\n> \n> +\tint setSelection(unsigned int target, Rectangle *rect);\n> +\n> \tint requestBuffers(unsigned int count);\n> \tstd::unique_ptr createBuffer(const struct v4l2_buffer &buf);\n> \tFileDescriptor exportDmabufFd(unsigned int index, unsigned int plane);\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 8226773..f3c66ed 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -940,6 +940,54 @@ std::vector V4L2VideoDevice::enumSizes(unsigned int pixelFormat)\n> \treturn sizes;\n> }\n> \n> +/**\n> + * \\brief Set a crop rectangle on the V4L2 video device node\n> + * \\param[inout] rect The rectangle describing the crop target area\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int V4L2VideoDevice::setCrop(Rectangle *rect)\n> +{\n> +\treturn setSelection(V4L2_SEL_TGT_CROP, rect);\n> +}\n> +\n> +/**\n> + * \\brief Set a compose rectangle on the V4L2 video device node\n> + * \\param[inout] rect The rectangle describing the compose target area\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int V4L2VideoDevice::setCompose(Rectangle *rect)\n> +{\n> +\treturn setSelection(V4L2_SEL_TGT_COMPOSE, rect);\n> +}\n> +\n> +int V4L2VideoDevice::setSelection(unsigned int target, Rectangle *rect)\n> +{\n> +\tstruct v4l2_selection sel = {};\n> +\n> +\tsel.type = bufferType_;\n> +\tsel.target = target;\n> +\tsel.flags = 0;\n> +\n> +\tsel.r.left = rect->x;\n> +\tsel.r.top = rect->y;\n> +\tsel.r.width = rect->w;\n> +\tsel.r.height = rect->h;\n> +\n> +\tint ret = ioctl(VIDIOC_S_SELECTION, &sel);\n> +\tif (ret < 0) {\n> +\t\tLOG(V4L2, Error) << \"Unable to set rectangle \" << target\n> +\t\t\t\t << \": \" << strerror(-ret);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\trect->x = sel.r.left;\n> +\trect->y = sel.r.top;\n> +\trect->w = sel.r.width;\n> +\trect->h = sel.r.height;\n> +\n> +\treturn 0;\n> +}\n> +\n> int V4L2VideoDevice::requestBuffers(unsigned int count)\n> {\n> \tstruct v4l2_requestbuffers rb = {};","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97C4C60837\n\tfor ;\n\tThu, 13 Feb 2020 21:31:35 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D7E7504;\n\tThu, 13 Feb 2020 21:31:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581625895;\n\tbh=tC6EpFJpUH/biF0PTZD2bmUz1K+/DuOn/i4+fAiH66Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c9SXPYH4OO/FjKOTHAPP7diXoaGxGKoxNy2j85efMgb6utKNJqbUGKJ/Gg8d7Poms\n\tQXnXiZ8fbeLjSyZFav2YS2QAJs7qVox+2XLbLV7+8Mo1IzV/obWfSzvGGcZtJdwnxn\n\t3zJd3kfF8Z8xcQ2dec5duhaC2/lGwwSEqwRcJvtE=","Date":"Thu, 13 Feb 2020 22:31:18 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200213203118.GM29760@pendragon.ideasonboard.com>","References":"<20200204112444.8395-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200204112444.8395-1-naush@raspberrypi.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: v4l2_videodevice: Add\n\tcrop/selection control.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Feb 2020 20:31:35 -0000"}}]