[{"id":40063,"web_url":"https://patchwork.libcamera.org/comment/40063/","msgid":"<178595055109.2300677.14369647088726992896@ping.linuxembedded.co.uk>","date":"2026-08-05T17:22:31","subject":"Re: [PATCH v7 32/32] ipa: libipa: lsc: Specialize Interpolator for\n\tuint8_t","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-08-05 17:13:14)\n> Specialize Interpolator<>::interpolate() for uint8_t register size.\n> \n> Some platforms (Mali, Simple) use an 8 bit register size. Provide\n> a specialization for the that type of Interpolator<>::interpolate().\n\nI look forward to Barnabas or Laurent checking this one, but I won't\nblock it so:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/libipa/lsc.cpp | 11 +++++++++++\n> src/ipa/libipa/lsc.h | 7 +++++++\n> 2 files changed, 18 insertions(+)\n> \n> diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\n> index a8b89bcedf57..cf9ea6e68c73 100644\n> --- a/src/ipa/libipa/lsc.cpp\n> +++ b/src/ipa/libipa/lsc.cpp\n> @@ -102,6 +102,17 @@ void Interpolator>::\n> for (auto const &[k, v] : a)\n> interpolateVector(v, b.at(k), dest[k], lambda);\n> }\n> +\n> +template<>\n> +void Interpolator>::\n> + interpolate(const lsc::Components &a,\n> + const lsc::Components &b,\n> + lsc::Components &dest,\n> + double lambda)\n> +{\n> + for (auto const &[k, v] : a)\n> + interpolateVector(v, b.at(k), dest[k], lambda);\n> +}\n> #endif\n> \n> /**\n> diff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h\n> index 30330f284013..17d5a4a141c1 100644\n> --- a/src/ipa/libipa/lsc.h\n> +++ b/src/ipa/libipa/lsc.h\n> @@ -48,6 +48,13 @@ void Interpolator>::\n> const lsc::Components &b,\n> lsc::Components &dest,\n> double lambda);\n> +\n> +template<>\n> +void Interpolator>::\n> + interpolate(const lsc::Components &a,\n> + const lsc::Components &b,\n> + lsc::Components &dest,\n> + double lambda);\n> #endif /* __DOXYGEN__ */\n> \n> class LscAlgorithmBase\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91B23C3301\n\tfor ;\n\tWed, 5 Aug 2026 17:22:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A32566812F;\n\tWed, 5 Aug 2026 19:22:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C2F768124\n\tfor ;\n\tWed, 5 Aug 2026 19:22:34 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B899A929;\n\tWed, 5 Aug 2026 19:21:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TRHOjl4A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785950483;\n\tbh=XUxmEMCUgrwRfXaBlDJ8Eo7nwcdCaF1SXKYaM+3fiC8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TRHOjl4A8+HKrRgTZoan2LqWy51yDrBgnzsPCri6A9z6XCIKkVRr7qTuOPLyEPWew\n\ttM12RqPpkPxlBPOXk8yF/2Kf8UXwcCajVVX/q41Tgp505SNE/z65gzNYtiS2nsamYV\n\t9Ol45b18VnxuQ/1070WzVkeDJ4r3WsXYANleQAlc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260805-libipa-algorithms-v7-32-7425b5b795d4@ideasonboard.com>","References":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>\n\t<20260805-libipa-algorithms-v7-32-7425b5b795d4@ideasonboard.com>","Subject":"Re: [PATCH v7 32/32] ipa: libipa: lsc: Specialize Interpolator for\n\tuint8_t","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tMilan Zamazal ,\n\tStefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 05 Aug 2026 18:22:31 +0100","Message-ID":"<178595055109.2300677.14369647088726992896@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]