{"id":27648,"url":"https://patchwork.libcamera.org/api/patches/27648/?format=json","web_url":"https://patchwork.libcamera.org/patch/27648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260805-libipa-algorithms-v7-25-7425b5b795d4@ideasonboard.com>","date":"2026-08-05T16:13:07","name":"[v7,25/32] ipa: libipa: lsc_polynomial: Remove sensorSize_","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"90c7432a2fb516b6f8dff4227390dfa18f044bd4","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27648/mbox/","series":[{"id":6110,"url":"https://patchwork.libcamera.org/api/series/6110/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6110","date":"2026-08-05T16:12:42","name":"ipa: libipa: Introduce libipa algorithms","version":7,"mbox":"https://patchwork.libcamera.org/series/6110/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27648/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 385C8C3349\n\tfor ;\n\tWed, 5 Aug 2026 16:13:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B95D368176;\n\tWed, 5 Aug 2026 18:13:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 024146815D\n\tfor ;\n\tWed, 5 Aug 2026 18:13:41 +0200 (CEST)","from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32CC03A1C;\n\tWed, 5 Aug 2026 18:12:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gpXU2o7a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785946350;\n\tbh=M+fhDFMVeC56oP6o4RBljPBP/g+PMAsqSnprrwRtIGE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=gpXU2o7aUavh40D6VC91z5x08ekzih/zJ6LKuNZft4aH9qMAJZG/fk9ZMCy/JDUFK\n\tZR/wd+tDBa03SOpJmxQSzuiAbujhYOxzMFjoNh5taJN/05zRZERstC3qUVNMKu4hr/\n\tf2w16vvCudTZu4KwiYzqT2qvBLFzUr56zry3IHhU=","From":"Jacopo Mondi ","Date":"Wed, 05 Aug 2026 18:13:07 +0200","Subject":"[PATCH v7 25/32] ipa: libipa: lsc_polynomial: Remove sensorSize_","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260805-libipa-algorithms-v7-25-7425b5b795d4@ideasonboard.com>","References":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","In-Reply-To":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug , \n\tMilan Zamazal ","Cc":"Jacopo Mondi , \n\tKieran Bingham ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3310;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=M+fhDFMVeC56oP6o4RBljPBP/g+PMAsqSnprrwRtIGE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2EhLF0PSNsubEXvKKaAggussVkC7HraJm/Mu\n\tGA67W2uDJSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhIQAKCRByNAaPFqFW\n\tPFwJD/42edBnsf/JeLciDXrYV7PlgsJk6rMQpQAdDQyDCATBxj7uxNBoLpUdVE08cHcpxD5i037\n\teEG5G8V06coibazmQFwkAGh3Ae6TonG0Awp71eDujkzzwYTryZr//g+DMwIY2nVdr2moHGRMNH1\n\tj0LgmUXoRapS4MIn0MJM/vy6ob0C3GgReDd8i6qyWcJlyvg0tJQ6I2Z8o0vzuEcVDkpdacF+tJU\n\tYXjnDr2W3zN+N9Wi6/SC6CzG3gC0EhVQR/m/hUJVvEIJnNWpzn8BP6WZTMcb/RZRViSfEVs2pEO\n\tn5bUC9Ksj62Jgb8qu98ToC9amG4qddK/iJ6wH1E4L8qtIL8gphnB7DRZnvfo3aO+vaImTqhI3DH\n\t7xvAS8fgbSM/H5AHtX88l33cExhcsJg3tPQcHOJFZNvJPxRIkwMrJ9mulfDDhu4aqfRcWSnFZfb\n\tOlP8KrFOiB9/5r1PGhR8dHasymSfro4PUR/FaXGED8joFFwyznopWDbYSEY/yLmyD/1IRuI+gZ/\n\tjYM9ggpECKzMu0DxpwiZtdRk/CBQ0n1rGgBbGqvlLaxoleZR4GLXpxUWNAvmY+6oCc2Y/MxSb+y\n\tvGRh5zWLAF7ihGcvKCBdB1L8WvmOD2U4o07r/GY8wB2lPRfcDNtGB1hLK4yZWI35ZuWSLMESZN9\n\tVKPFg61aAmcx4rg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The sensorSize_ field is only used during the init() function and is\nprovided to LscPolynomial using the LscDescriptor type.\n\nThere is no need to store it as a class member and to pass it in\nat class construction time.\n\nRemove it and move the \\todo comment in the LscDescriptor type\ndocumentation.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \nReviewed-by: Stefan Klug \n---\n src/ipa/libipa/lsc.cpp | 6 +-----\n src/ipa/libipa/lsc_base.cpp | 3 +++\n src/ipa/libipa/lsc_polynomial.cpp | 7 -------\n src/ipa/libipa/lsc_polynomial.h | 6 ------\n 4 files changed, 4 insertions(+), 18 deletions(-)","diff":"diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 32626049a2e2..2062b795991d 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control\n \t\timpl_ = std::make_unique();\n \t\tLOG(Lsc, Debug) << \"Using table-based Lsc\";\n \t} else if (type == \"polynomial\") {\n-\t\t/*\n-\t\t * \\todo Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\timpl_ = std::make_unique(descriptor.sensorSize);\n+\t\timpl_ = std::make_unique();\n \t\tpolynomial_ = true;\n \t\tLOG(Lsc, Debug) << \"Using polynomial Lsc\";\n \t} else {\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 289cb3da33f2..cb770f164d53 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -78,6 +78,9 @@ void Interpolator::\n * \\var LscDescriptor::sensorSize\n * \\brief The physical sensor size. This is the largest frame size used to\n * generate the LSC table. Only used by the polynomial LSC algorithm\n+ *\n+ * \\todo: Most likely the reference frame should be native_size.\n+ * Let's wait how the internal discussions progress.\n */\n \n /**\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex c3871eb3295c..0eb017de6b50 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)\n * \\sa LscImplementation\n */\n \n-/**\n- * \\fn LscPolynomial::LscPolynomial\n- * \\param[in] sensorSize The physical sensor size\n- *\n- * Construct an LscPolynomial\n- */\n-\n /**\n * \\brief Parse polynomial LSC data\n * \\param[in] sets The tuning file content\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex 4c6af2d4900d..548ed94b2461 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -57,11 +57,6 @@ private:\n \tusing PolynomialComponentsMap = std::map;\n \n public:\n-\tLscPolynomial(const Size &sensorSize)\n-\t\t: sensorSize_(sensorSize)\n-\t{\n-\t}\n-\n \tint parseLscData(const ValueNode &sets,\n \t\t\t const LscDescriptor &descriptor) override;\n \n@@ -75,7 +70,6 @@ private:\n \t\t\t\t\t Span yPositions,\n \t\t\t\t\t const Rectangle &cropRectangle);\n \tPolynomialComponentsMap lscData_;\n-\tSize sensorSize_;\n };\n \n } /* namespace ipa */\n","prefixes":["v7","25/32"]}