{"id":27647,"url":"https://patchwork.libcamera.org/api/patches/27647/?format=json","web_url":"https://patchwork.libcamera.org/patch/27647/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260805-libipa-algorithms-v7-24-7425b5b795d4@ideasonboard.com>","date":"2026-08-05T16:13:06","name":"[v7,24/32] ipa: libipa: lsc: Document Components parsing","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ba27d76aa745ad74f74bddbded38fd6d8ec2387","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27647/mbox/","series":[{"id":6110,"url":"https://patchwork.libcamera.org/api/series/6110/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6110","date":"2026-08-05T16:12:42","name":"ipa: libipa: Introduce libipa algorithms","version":7,"mbox":"https://patchwork.libcamera.org/series/6110/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27647/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27647/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C304C3348\n\tfor ;\n\tWed, 5 Aug 2026 16:13:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F7F56818D;\n\tWed, 5 Aug 2026 18:13:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62FBF68164\n\tfor ;\n\tWed, 5 Aug 2026 18:13:40 +0200 (CEST)","from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63A912B5C;\n\tWed, 5 Aug 2026 18:12:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IiPKhfT3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785946349;\n\tbh=EIoRTYcRxBXUh/gCEob8/0V/PQOEtmC11Bd6tGcGu5A=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=IiPKhfT3jI+4+Mv4WSc9Ws0wquMVFZKaV9F4QwcsU04pEy4aCOAN7H3cUpa2udXpU\n\tbE1MqJ/Oi/lXjJRKRIekP7L+qln7CJKQ4dLtu6PbPUXScTNhie4pq1elEI3hKcuhWX\n\t7N9TW8TyB5Z9LlCGhjWBLAGgOTNrqtGMBZLJ4tU8=","From":"Jacopo Mondi ","Date":"Wed, 05 Aug 2026 18:13:06 +0200","Subject":"[PATCH v7 24/32] ipa: libipa: lsc: Document Components parsing","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260805-libipa-algorithms-v7-24-7425b5b795d4@ideasonboard.com>","References":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","In-Reply-To":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug , \n\tMilan Zamazal ","Cc":"Jacopo Mondi , \n\tKieran Bingham ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4373;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=EIoRTYcRxBXUh/gCEob8/0V/PQOEtmC11Bd6tGcGu5A=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2EhMH6SJkKBp+o6RNsehjgtMjuOVy2o0ZigK\n\t9CKJN6GYRuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhIQAKCRByNAaPFqFW\n\tPIh7EACUOuy6eIBfsRNjBCEm4q0/qJ1Z0PxsHS7n+08ypmUn0vXsH3f2+0mNBTNaEY/HbzJe2xI\n\tbid69DMRDH8TAMFpE8W6l1w2x5N0kVZ1aZ9UfeA8u/iqPRMcbLP30UaPDGRFMR8QVOlxxvkVs3Y\n\t31rUnaT9biPkpcFMJHFFrWIVXj8LHJdLhziQndgWdPmbPX6SbE8N6HsJ6X6gcenwCf7ln9D899Q\n\tDv3QWQJJpXX6ujmtFtV9JeMIPHnmtyt3Zm4ctx59tGhVusTwLSOToPglhHEuWEjXOQL+0vOMfl7\n\tN09NRapgjsYsi2Z2ppoHgbaSpA45I7Np3k8qHMQku1KcvSMYJlTFaqRT7SvAtmuozPr/rjPzkIu\n\tU8kBrKSmqQbY9WXx+S/PHU4B/SXCPu/QxCwzc4Pf8Pg5x4X5UtgQF9DEVAjXiUBiNxURZb1GdHA\n\tLe/Bj3YgAX5BmAaymqMJuTiy6vumh4YJkW5XVvKuzKS0mPpRqiLpg/P/gEOVh2wboprhi6DEFSa\n\twR3TdwhiXuGNgZPOfjtzFAeH1oNnsLRxeB/neLGt7unJDygAhAcI/ntdWtzUFF+UOxPiPa4eYEv\n\tWJHAN2UpJhR5fFCFnSVX6WxMo4E1Ng09hYpkIIvJ6MPTliJ5U1E6+5od+Y+YK4sJB6QfE9cRCu0\n\txSTdFXrwUny9u9w==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Document with examples how different IPA modules parse the tuning\nfile depending on the number of colour channels they support.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Stefan Klug \nReviewed-by: Kieran Bingham \n---\n src/ipa/libipa/lsc.cpp | 111 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 111 insertions(+)","diff":"diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 831f6b003df1..32626049a2e2 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -68,6 +68,117 @@ namespace lsc {\n * tables are indexed by colour temperature with per-colour-components vectors\n * of gain values or polynomial coefficients.\n *\n+ * The colour components names are IPA-implementation specific and depend on the\n+ * ISP LSC engine design. Some LSC engine support 4 colour components (r, gr,\n+ * gb, b), some only support 3 colour components (r, g, b). The name (and\n+ * number) of the expected colour components shall be provided to\n+ * LscAlgorithm::init() using the LscDescriptor::keys field.\n+ *\n+ * Example of a tabular lens shading tuning file with 'r', 'g' and 'b' colour\n+ * components. The gain table has been omitted here, but the expected number\n+ * of entries has to be equal to\n+ * LscDescriptor::numHSamples * LscDescriptor::numVSamples.\n+ *\n+ * \\code{.yaml}\n+ * - Lsc:\n+ * sets:\n+ * - ct: 2500\n+ * r: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * g: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * b: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * - ct: 6500\n+ * r: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * g: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * b: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * \\endcode\n+ *\n+ * Example of a polynomial lens shading tuning file with 'r', 'gr', 'gb' and 'b'\n+ * colour components:\n+ *\n+ * \\code{.yaml}\n+ * - Lsc:\n+ * type: \"polynomial\"\n+ * sets:\n+ * - ct: 2500\n+ * r:\n+ * cx: 0.5006571711950275\n+ * cy: 0.510093737499277\n+ * k0: 1.5393282208428813\n+ * k1: -1.1434559757908016\n+ * k2: 4.332602305814554\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gr:\n+ * cx: 0.5009320529087338\n+ * cy: 0.511208038949085\n+ * k0: 1.5634738574805407\n+ * k1: -1.5623484259968348\n+ * k2: 4.846686073656501\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gb:\n+ * cx: 0.5012013290343839\n+ * cy: 0.5128251541578288\n+ * k0: 1.526147944919103\n+ * k1: -1.4316976083689723\n+ * k2: 4.792604063222728\n+ * k3: 0.0\n+ * k4: 0.0\n+ * b:\n+ * cx: 0.49864139511067784\n+ * cy: 0.5162095081739346\n+ * k0: 1.0405245474038738\n+ * k1: 0.05618339879447103\n+ * k2: 1.8792813594001752\n+ * k3: 0.0\n+ * k4: 0.0\n+ * - ct: 6000\n+ * r:\n+ * cx: 0.5006202239353942\n+ * cy: 0.5099531318307661\n+ * k0: 1.4702946023945032\n+ * k1: -0.8893767547927631\n+ * k2: 3.920547732201387\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gr:\n+ * cx: 0.500907874178317\n+ * cy: 0.511084916024106\n+ * k0: 1.5336172760559457\n+ * k1: -1.39964026514435\n+ * k2: 4.565487728954618\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gb:\n+ * cx: 0.5011898608900477\n+ * cy: 0.5126797906745105\n+ * k0: 1.5013145790354843\n+ * k1: -1.2747407173754124\n+ * k2: 4.514682876897286\n+ * k3: 0.0\n+ * k4: 0.0\n+ * b:\n+ * cx: 0.4987561413116136\n+ * cy: 0.5159619420778772\n+ * k0: 1.0102986422191802\n+ * k1: 0.13263449763985727\n+ * k2: 1.686556107316064\n+ * k3: 0.0\n+ * k4: 0.0\n+ * \\endcode\n+ *\n * At LscAlgorithm::configure() time the LSC tables are re-sampled on the\n * sensor's crop rectangle in use to adapt them to the configuration in use for\n * a streaming session. Polynomial LSC tables support re-sampling and can be\n","prefixes":["v7","24/32"]}