{"id":27635,"url":"https://patchwork.libcamera.org/api/patches/27635/?format=json","web_url":"https://patchwork.libcamera.org/patch/27635/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260805-libipa-algorithms-v7-12-7425b5b795d4@ideasonboard.com>","date":"2026-08-05T16:12:54","name":"[v7,12/32] ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dd4cb13fac34030e00c1a9537a4428eae62df079","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27635/mbox/","series":[{"id":6110,"url":"https://patchwork.libcamera.org/api/series/6110/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6110","date":"2026-08-05T16:12:42","name":"ipa: libipa: Introduce libipa algorithms","version":7,"mbox":"https://patchwork.libcamera.org/series/6110/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27635/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27635/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A58C8C333E\n\tfor ;\n\tWed, 5 Aug 2026 16:13:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E149B68160;\n\tWed, 5 Aug 2026 18:13:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D86268127\n\tfor ;\n\tWed, 5 Aug 2026 18:13:32 +0200 (CEST)","from [192.168.125.177] (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88AA01387;\n\tWed, 5 Aug 2026 18:12:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vsIIP8aT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785946342;\n\tbh=yXwIPDDYuWnxiEQ7pfsAy2nzJEmWvfcuWcpTAAq3aio=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=vsIIP8aTsAqkI8S30j1LPgZHZ8rZTxjRKIlIPcCdalDmDunbk/sWU1ICaw4Hah1gY\n\taIaz7Jxeuea2h74zVevfpCRWevjFK/2WmB7DtpinzW1ZNQjEud9enXIiHGy7aItDgt\n\tJp6DZ9NZEcAFUBdJ8pNmoLshy2dBafsiAARz0/1c=","From":"Jacopo Mondi ","Date":"Wed, 05 Aug 2026 18:12:54 +0200","Subject":"[PATCH v7 12/32] ipa: libipa: lsc_polynomial: Don't inline\n\tValueNode accessor","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260805-libipa-algorithms-v7-12-7425b5b795d4@ideasonboard.com>","References":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","In-Reply-To":"<20260805-libipa-algorithms-v7-0-7425b5b795d4@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug , \n\tMilan Zamazal ","Cc":"Jacopo Mondi , \n\tLaurent Pinchart , \n\tKieran Bingham ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3022;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=gKG7oMvPdTnWPY3Xqu6aZDyF064c3RNYURQAJyWHzUw=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqc2Ecn6sfB4NARzz6SZlyx0IjbKcD+EOPeMzv3\n\tec016jRJpiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCanNhHAAKCRByNAaPFqFW\n\tPNvVEACORUAzF7U/J1YSBW7iafYJ68uyc6wAv/c4vIDmAwl1xyffPqlH6kAdS5Xuyvb7q+/6NbO\n\twZpMao9WpYGN/90hROLEcaDheUNjYbbcyuY8n47FDByKDWcr7Q5fnl0auaiAe5qPoftjJwyjnZ/\n\t3KlpPtsfXhF8iQp0lMyTaxxHZm3/+E/RLs213ZtaWhSTN91/QBc7UaHjwNv2AUkeGmtVv0rWUTC\n\tWn7uddWkdSUmi/AxfdAvzbvIXh6gRA7G2XObievL3jt1V01w8WHJthzILv82WR8XpWwqGsOlSGf\n\tg8JYWmcoOW+ltsVz6KV2Y3hwjcmhaNYMvRnoXmuD2wlQ3AyJ3kxfVHjxsC9jPDrJlhqVISZiwNb\n\tyQ+D92Q0VYdzEBYnuLhMwaYHZJ3CFhRzObtXBd+jeVWnUwtB91GqFuLWBixg1Qjd0j7M7QR/7gF\n\t/+iqM5C108aQgxrh1rdayQlWU2XfXEwXcBkZUz7OhWPKhQVsXNH9ORaIPBdlUcClZGQbH3aGbIL\n\tBfbN5H+uANni0pVjCYrbvxhZItHWQ0mshdrCnLxaTR62AwQJp8p5+/kZYSWhJU8QId9nsKLn/CX\n\tYUsno3gYADeKvF7u01PcTaPHJLsMQe02N0CqcMHbBWvPjWccn2pYcOiDjFDWf6NzN6XcE6FTTOm\n\tGR95tKSkTOrtVYg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThere's no need to inline the ValueNode::Accessor::get() function for\nLscPolynomial. Move it to from lsc_polynomial.h to lsc_polynomial.cpp.\n\nWhile at it, replace C++-style comments with C-style comments according\nto the libcamera coding style.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_polynomial.cpp | 28 ++++++++++++++++++++++++++--\n src/ipa/libipa/lsc_polynomial.h | 26 --------------------------\n 2 files changed, 26 insertions(+), 28 deletions(-)","diff":"diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex f607d86c54c3..921af0b0bd13 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -77,5 +77,29 @@ namespace ipa {\n * \\param size The size of the reference image\n */\n \n-} // namespace ipa\n-} // namespace libcamera\n+} /* namespace ipa */\n+\n+#ifndef __DOXYGEN__\n+template<>\n+std::optional\n+ValueNode::Accessor::get(const ValueNode &obj) const\n+{\n+\tstd::optional cx = obj[\"cx\"].get();\n+\tstd::optional cy = obj[\"cy\"].get();\n+\tstd::optional k0 = obj[\"k0\"].get();\n+\tstd::optional k1 = obj[\"k1\"].get();\n+\tstd::optional k2 = obj[\"k2\"].get();\n+\tstd::optional k3 = obj[\"k3\"].get();\n+\tstd::optional k4 = obj[\"k4\"].get();\n+\n+\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n+\t\tLOG(LscPolynomial, Error)\n+\t\t\t<< \"Polynomial is missing a parameter\";\n+\t\treturn std::nullopt;\n+\t}\n+\n+\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n+}\n+#endif /* __DOXYGEN__ */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex a0d27c4b21d6..d52ec86946b1 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -80,30 +80,4 @@ private:\n \n } /* namespace ipa */\n \n-#ifndef __DOXYGEN__\n-\n-template<>\n-struct ValueNode::Accessor {\n-\tstd::optional get(const ValueNode &obj) const\n-\t{\n-\t\tstd::optional cx = obj[\"cx\"].get();\n-\t\tstd::optional cy = obj[\"cy\"].get();\n-\t\tstd::optional k0 = obj[\"k0\"].get();\n-\t\tstd::optional k1 = obj[\"k1\"].get();\n-\t\tstd::optional k2 = obj[\"k2\"].get();\n-\t\tstd::optional k3 = obj[\"k3\"].get();\n-\t\tstd::optional k4 = obj[\"k4\"].get();\n-\n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n-\t\t\tLOG(LscPolynomial, Error)\n-\t\t\t\t<< \"Polynomial is missing a parameter\";\n-\t\t\treturn std::nullopt;\n-\t\t}\n-\n-\t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n-\t}\n-};\n-\n-#endif\n-\n } /* namespace libcamera */\n","prefixes":["v7","12/32"]}