[{"id":3603,"web_url":"https://patchwork.libcamera.org/comment/3603/","msgid":"","date":"2020-01-31T10:02:51","subject":"Re: [libcamera-devel] [PATCH] QCam: Swich default stream role to\n\tviewfinder.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch,\n\nOn 31/01/2020 09:52, naush@raspberrypi.com wrote:\n> From: Naushir Patuck \n> \n> QCam currently only displays a standard viewfinder. As such set the\n> StreamRole parameter to Viewfinder so that the pipeline handlers can\n> setup the appropriate resolutions and formats.\n\nI agree, this makes sense as a sane starting condition.\n\nIn the future we can add controls and support to QCam for selecting this\nmode at application runtime too, but certainly starting the Viewfinder\nup as a Viewfinder sounds perfectly reasonable to me.\n\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index df51fa8..70a3e61 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -125,7 +125,7 @@ int MainWindow::startCapture()\n> {\n> \tint ret;\n> \n> -\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n> +\tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n> \n> \tStreamConfiguration &cfg = config_->at(0);\n> \tif (options_.isSet(OptSize)) {\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65C12608D7\n\tfor ;\n\tFri, 31 Jan 2020 11:02:55 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D847C71D;\n\tFri, 31 Jan 2020 11:02:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580464975;\n\tbh=RzrhPEOvujnm9lfE97KYOodg/yfIStyfSFNBmD/oXd8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=h0zSBrJTPDA0pPZ4P43DlwY8RJbxoZWh/q3Tq4/Muz3E3QwMUEUgzJ4kqofJ2j6Kp\n\t72Ly1LyQVyOXFInhSLxYTTRcIuqY8X6BI8KO1oKzAvMF0BI2AP6dn/n+lCPZ4mUbXe\n\tRfJ1qIlNWt9OC67B1M1z85HCNvXGY1Bqo15Q0vzc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"naush@raspberrypi.com, libcamera-devel@lists.libcamera.org","References":"<20200131095245.25906-1-naush@raspberrypi.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 31 Jan 2020 10:02:51 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200131095245.25906-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] QCam: Swich default stream role to\n\tviewfinder.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 31 Jan 2020 10:02:55 -0000"}},{"id":3646,"web_url":"https://patchwork.libcamera.org/comment/3646/","msgid":"<20200210212153.GC2429426@oden.dyn.berto.se>","date":"2020-02-10T21:21:53","subject":"Re: [libcamera-devel] [PATCH] QCam: Swich default stream role to\n\tviewfinder.","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your patch.\n\nOn 2020-01-31 09:52:45 +0000, naush@raspberrypi.com wrote:\n> From: Naushir Patuck \n> \n> QCam currently only displays a standard viewfinder. As such set the\n> StreamRole parameter to Viewfinder so that the pipeline handlers can\n> setup the appropriate resolutions and formats.\n> \n> Signed-off-by: Naushir Patuck \n\nSmall nit for the patch subject,\n\n- Please use qcam: instead of QCam:\n- s/Swich/Switch/\n- Drop the period (.) at the end of the subject line\n\nWith these small things fixed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index df51fa8..70a3e61 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -125,7 +125,7 @@ int MainWindow::startCapture()\n> {\n> \tint ret;\n> \n> -\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n> +\tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n> \n> \tStreamConfiguration &cfg = config_->at(0);\n> \tif (options_.isSet(OptSize)) {\n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF6F160990\n\tfor ;\n\tMon, 10 Feb 2020 22:21:55 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id 9so5353516lfq.10\n\tfor ;\n\tMon, 10 Feb 2020 13:21:55 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tc22sm662341lfc.93.2020.02.10.13.21.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 Feb 2020 13:21:54 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=IpeLpPaKc1Re4Vc8dCbsUiEFvZxiBOeuzs9gGI2xm+s=;\n\tb=AA1p2cEkqQ41gIhRdYTHVXhZMOU9Ef2ORDY+kgxPsW5qqeXxFjDpCaISeNEYTTW3DQ\n\tJ1bOeRrQQCNQ5WDf8chvMW+HVX0a1mVyB61e+SzI7KyrloHnq0MuV6ekh36LkXlGU00z\n\tkkWzNX/BgXyZxk7m60bhhct2XyevY+lCl1nKu4yb2HzqncjzflazNs6T6FxX+CMxC0na\n\t7xdkr5ghnFEykSHzmfdY6o1Izo2x2aQAELpXNYlVJqYSnN7YGcf5lvMWu1joaZRDPMhS\n\tfq8dwx3oBVUxiMAZVDPIHTSZLtBuMnuxjBmU9R5PGBy3DDkgM4jFGSuSbFJrlN79jTn1\n\tDWtw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=IpeLpPaKc1Re4Vc8dCbsUiEFvZxiBOeuzs9gGI2xm+s=;\n\tb=K5hF8JOQkrhk6bqdU/yeZSD1xWV79WZcaoGhS/HLd7VbglRhmrphYwpZhReo/eyfby\n\ti2U8CpdRm3cz47qPilR4TLVt2aUOAocKjrfwyVIA30mWQqVv9/JvKsl3HvcOCds8JSfw\n\tUA2KrUY8juJw/Kp5KIc0d04j6imnX+Dl2o8nJOL5FgdPkgkCal1wE9Esn6yW8IFsRicU\n\taefxiWd5oCOuXTY/rAgBGmt40dGXTlkIW78yR99Y44+q+FissiT4RC0AF3UhyLgZYbtQ\n\tGDALZsjJKLceNIR6tttYlcdsG++sHjPjN12fj7y1VX9nj618oIvG2vYqUont8hI2UpOC\n\tlmEg==","X-Gm-Message-State":"APjAAAVIXESuVhyRbc7kLlqoH2NwDieL7ui4kVNFcCPj8juofAN/9wlS\n\tUtIsIJKCp/vL4CYxAf7hnSUfCA==","X-Google-Smtp-Source":"APXvYqzgxY3cWlQFiDM6U3Dit+EMvuOcUi9G+9XKXF6oR2MgSYDxAmz2Gi3wDHxtYxEJY2L5Qlqq4Q==","X-Received":"by 2002:ac2:592f:: with SMTP id\n\tv15mr1690868lfi.105.1581369715066; \n\tMon, 10 Feb 2020 13:21:55 -0800 (PST)","Date":"Mon, 10 Feb 2020 22:21:53 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"naush@raspberrypi.com","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200210212153.GC2429426@oden.dyn.berto.se>","References":"<20200131095245.25906-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200131095245.25906-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] QCam: Swich default stream role to\n\tviewfinder.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Feb 2020 21:21:55 -0000"}}]