{"id":27612,"url":"https://patchwork.libcamera.org/api/patches/27612/?format=json","web_url":"https://patchwork.libcamera.org/patch/27612/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260804101949.353266-11-barnabas.pocze@ideasonboard.com>","date":"2026-08-04T10:19:49","name":"[RFC,v1,10/10] libcamera: software_isp: debayer_egl: Unmake EGL context","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e111ad61f1b5b8bea6956dd2d4b85584250979d8","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27612/mbox/","series":[{"id":6105,"url":"https://patchwork.libcamera.org/api/series/6105/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6105","date":"2026-08-04T10:19:39","name":"libcamera: software_isp: debayer_egl: Remove some leaks","version":1,"mbox":"https://patchwork.libcamera.org/series/6105/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27612/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27612/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80FE2C3338\n\tfor ;\n\tTue, 4 Aug 2026 10:20:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF05B680CB;\n\tTue, 4 Aug 2026 12:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5244068092\n\tfor ;\n\tTue, 4 Aug 2026 12:19:54 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC6811C76\n\tfor ;\n\tTue, 4 Aug 2026 12:18:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vyj8PQ8N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838724;\n\tbh=eKbs0dx0FOSTp6FPFSVQcaueeOppVZZBqA8/xDNN/KE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vyj8PQ8Ncsx8QLTP5EKujDC8vj3wf0zCKg7ur2S16g7EgULhb1sXoqd7hxytubPXj\n\tJ0aceyC4DJWFlJ4WBlWaFvka1seAl+LRWMux5WXs+7w/kpyMhSFjVKLe2LGRukMrzV\n\tQSpe1SWzdZPr8cykbf2zti3l09B+xsqS6yZdI03o=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 10/10] libcamera: software_isp: debayer_egl: Unmake\n\tEGL context","Date":"Tue, 4 Aug 2026 12:19:49 +0200","Message-ID":"<20260804101949.353266-11-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","References":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In `SoftwareIsp`, the worker thread is recreated each time it is started.\nIn order to avoid any potential leaks from the egl implementation, remove\nthe currently bound egl context in `DebayerEGL::stop()`.\n\nMesa does not seem to have any destructors for its egl thread data,\nso the context in those cases does not seem to be properly destroyed.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/software_isp/debayer_egl.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex afc6b02748..3405cdd56a 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -680,6 +680,7 @@ void DebayerEGL::stop()\n \tif (programId_)\n \t\tglDeleteProgram(programId_);\n \n+\tegl_.makeCurrent(false);\n \tegl_.resetEGLContext();\n }\n \n","prefixes":["RFC","v1","10/10"]}