{"id":27611,"url":"https://patchwork.libcamera.org/api/patches/27611/?format=json","web_url":"https://patchwork.libcamera.org/patch/27611/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260804101949.353266-10-barnabas.pocze@ideasonboard.com>","date":"2026-08-04T10:19:48","name":"[RFC,v1,09/10] libcamera: egl: Make it possible to unmake the context","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c988dd2273137fd80ec8f0be138b16877ec9d25b","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27611/mbox/","series":[{"id":6105,"url":"https://patchwork.libcamera.org/api/series/6105/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6105","date":"2026-08-04T10:19:39","name":"libcamera: software_isp: debayer_egl: Remove some leaks","version":1,"mbox":"https://patchwork.libcamera.org/series/6105/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27611/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27611/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7C64C3336\n\tfor ;\n\tTue, 4 Aug 2026 10:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48CE96808A;\n\tTue, 4 Aug 2026 12:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CCC267F9E\n\tfor ;\n\tTue, 4 Aug 2026 12:19:54 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D42FDA8\n\tfor ;\n\tTue, 4 Aug 2026 12:18:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L+rKbkEh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838724;\n\tbh=sm8eRvBcgM+v78i9vMsRX7Ix/YevzdQ9LiDLdV4PPyI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=L+rKbkEh63WR+m8YkIHcStMI+YVXHc/IH+QigRfkD4HIVKJO3FsfmKtqKqnneLSEI\n\t6Ggz4tfh/c5ao9GCZ3MD3M0bC7n6tA47YyrtxVVvuLSY46iWg84I++5bsBp5NRgluc\n\t9IuzFv78zHWd4E0RMSPCVjXdv4MrJLlxOE/BZznk=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 09/10] libcamera: egl: Make it possible to unmake the\n\tcontext","Date":"Tue, 4 Aug 2026 12:19:48 +0200","Message-ID":"<20260804101949.353266-10-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","References":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a parameter to `makeCurrent()` to make it possible to\nremove the currently bound context.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/egl.h | 2 +-\n src/libcamera/egl.cpp | 7 ++++---\n 2 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex e18bb91f4d..a3218af9ef 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -116,7 +116,7 @@ public:\n \tvoid activateBindTexture(eGLImage &eglImage);\n \n \tvoid pushEnv(std::vector &shaderEnv, const char *str);\n-\tvoid makeCurrent();\n+\tvoid makeCurrent(bool make);\n \n \tint compileVertexShader(GLuint &shaderId, Span shaderData,\n \t\t\t\tSpan shaderEnv);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 5e75c3a6d2..f351bcf52c 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -427,7 +427,7 @@ int eGL::initEGLContext()\n \ttid_ = Thread::currentId();\n \tvtable_ = vtable;\n \n-\tmakeCurrent();\n+\tmakeCurrent(true);\n \n \tLOG(eGL, Info) << \"EGL: GL_RENDERER: \" << glGetString(GL_RENDERER);\n \tLOG(eGL, Info) << \"EGL: GL_VERSION: \" << glGetString(GL_VERSION);\n@@ -454,16 +454,17 @@ void eGL::resetEGLContext()\n \n /**\n * \\brief Make the EGL context current for the calling thread\n+ * \\param[in] make Whether to make/unmake the EGL context\n *\n * Binds the EGL context to the current thread, allowing OpenGL ES\n * operations to be performed. Must be called from the thread that\n * will perform rendering operations.\n */\n-void eGL::makeCurrent()\n+void eGL::makeCurrent(bool make)\n {\n \tASSERT(tid_ == Thread::currentId());\n \n-\tif (eglMakeCurrent(display_, EGL_NO_SURFACE, EGL_NO_SURFACE, context_) != EGL_TRUE) {\n+\tif (eglMakeCurrent(display_, EGL_NO_SURFACE, EGL_NO_SURFACE, make ? context_ : EGL_NO_CONTEXT) != EGL_TRUE) {\n \t\tLOG(eGL, Error) << \"eglMakeCurrent fail\";\n \t}\n }\n","prefixes":["RFC","v1","09/10"]}