[{"id":3602,"web_url":"https://patchwork.libcamera.org/comment/3602/","msgid":"<20200130222010.GA4724@pendragon.ideasonboard.com>","date":"2020-01-30T22:20:10","subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jan 30, 2020 at 09:38:09PM +0000, Kieran Bingham wrote:\n> Provide a helper to print the FourCC string representation, and utilise\n> it to improve the readability of the StreamConfiguration.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> This changes the output of the line:\n> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d\n> \n> to read:\n> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d MJPG\n> \n> include/libcamera/pixelformats.h | 3 +++\n> src/libcamera/pixelformats.cpp | 20 ++++++++++++++++++++\n> src/libcamera/stream.cpp | 3 ++-\n> 3 files changed, 25 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixelformats.h\n> index 6e25b8d8b76e..32cff083cdf9 100644\n> --- a/include/libcamera/pixelformats.h\n> +++ b/include/libcamera/pixelformats.h\n> @@ -8,11 +8,14 @@\n> #define __LIBCAMERA_PIXEL_FORMATS_H__\n> \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> using PixelFormat = uint32_t;\n> \n> +std::string FourCC(const PixelFormat &p);\n> +\n\nI think we should turn PixelFormat into a struct or class, and add a\ntoString() method. Moving away from the uint32_t alias will also\ndisallow implicit conversions, which would have helped catch bugs in the\npast, and should help avoiding them in the future.\n\n> } /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_PIXEL_FORMATS_H__ */\n> diff --git a/src/libcamera/pixelformats.cpp b/src/libcamera/pixelformats.cpp\n> index c03335400b70..d6b2c6a3dba5 100644\n> --- a/src/libcamera/pixelformats.cpp\n> +++ b/src/libcamera/pixelformats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \n> \n> +#include \n> +\n> /**\n> * \\file pixelformats.h\n> * \\brief libcamera pixel formats\n> @@ -25,4 +27,22 @@ namespace libcamera {\n> * \\todo Add support for format modifiers\n> */\n> \n> +/**\n> + * \\brief Return a PixelFormat as a FourCC string representation\n> + */\n> +std::string FourCC(const PixelFormat &p)\n> +{\n> +\tstd::stringstream ss;\n> +\n> +\tss << static_cast(p & 0x7f)\n> +\t << static_cast((p >> 8) & 0x7f)\n> +\t << static_cast((p >> 16) & 0x7f)\n> +\t << static_cast((p >> 24) & 0x7f);\n> +\n> +\tif (p & (1 << 31))\n> +\t\tss << \"-BE\";\n> +\n> +\treturn ss.str();\n> +}\n> +\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 13789e9eb344..4efe4385326f 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -348,7 +348,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> std::string StreamConfiguration::toString() const\n> {\n> \tstd::stringstream ss;\n> -\tss << size.toString() << \"-\" << utils::hex(pixelFormat);\n> +\tss << size.toString() << \"-\" << utils::hex(pixelFormat)\n> +\t << \" \" << FourCC(pixelFormat);\n> \treturn ss.str();\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98756607F3\n\tfor ;\n\tThu, 30 Jan 2020 23:20:30 +0100 (CET)","from pendragon.ideasonboard.com (85-76-34-92-nat.elisa-mobile.fi\n\t[85.76.34.92])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64148B76;\n\tThu, 30 Jan 2020 23:20:29 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580422830;\n\tbh=2E3XdKG4Qpho6HgUzVuwX1SKIkCiAPqKh6UnqHJ9qQY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iEWNh4cEQu155vteckvX3bnAHCNaTrwEA33km70mCll6I3gMyU4fypCE1tHX7Alql\n\tyUjObCGFPCjRNR+r1+NJDQaQnOng93IWZ+YNu7Cae0mc5suu7dy47tcLpRHiQppY07\n\td0mPEreAhZvJREXuYypSBjx2xdvKookdgk36B6yA=","Date":"Fri, 31 Jan 2020 00:20:10 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200130222010.GA4724@pendragon.ideasonboard.com>","References":"<20200130213809.16564-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200130213809.16564-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 30 Jan 2020 22:20:30 -0000"}},{"id":3605,"web_url":"https://patchwork.libcamera.org/comment/3605/","msgid":"<501f291fb3338b07ffe8716874f7bbe0f14b07e1.camel@ndufresne.ca>","date":"2020-01-31T15:20:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le jeudi 30 janvier 2020 à 21:38 +0000, Kieran Bingham a écrit :\n> Provide a helper to print the FourCC string representation, and utilise\n> it to improve the readability of the StreamConfiguration.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> This changes the output of the line:\n> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d\n> \n> to read:\n> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d MJPG\n\nPerhaps we could drop the hex form ? Is it really useful ?\n\n> \n> include/libcamera/pixelformats.h | 3 +++\n> src/libcamera/pixelformats.cpp | 20 ++++++++++++++++++++\n> src/libcamera/stream.cpp | 3 ++-\n> 3 files changed, 25 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixelformats.h\n> index 6e25b8d8b76e..32cff083cdf9 100644\n> --- a/include/libcamera/pixelformats.h\n> +++ b/include/libcamera/pixelformats.h\n> @@ -8,11 +8,14 @@\n> #define __LIBCAMERA_PIXEL_FORMATS_H__\n> \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> using PixelFormat = uint32_t;\n> \n> +std::string FourCC(const PixelFormat &p);\n> +\n> } /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_PIXEL_FORMATS_H__ */\n> diff --git a/src/libcamera/pixelformats.cpp b/src/libcamera/pixelformats.cpp\n> index c03335400b70..d6b2c6a3dba5 100644\n> --- a/src/libcamera/pixelformats.cpp\n> +++ b/src/libcamera/pixelformats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \n> \n> +#include \n> +\n> /**\n> * \\file pixelformats.h\n> * \\brief libcamera pixel formats\n> @@ -25,4 +27,22 @@ namespace libcamera {\n> * \\todo Add support for format modifiers\n> */\n> \n> +/**\n> + * \\brief Return a PixelFormat as a FourCC string representation\n> + */\n> +std::string FourCC(const PixelFormat &p)\n> +{\n> +\tstd::stringstream ss;\n> +\n> +\tss << static_cast(p & 0x7f)\n> +\t << static_cast((p >> 8) & 0x7f)\n> +\t << static_cast((p >> 16) & 0x7f)\n> +\t << static_cast((p >> 24) & 0x7f);\n> +\n> +\tif (p & (1 << 31))\n> +\t\tss << \"-BE\";\n> +\n> +\treturn ss.str();\n> +}\n> +\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 13789e9eb344..4efe4385326f 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -348,7 +348,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> std::string StreamConfiguration::toString() const\n> {\n> \tstd::stringstream ss;\n> -\tss << size.toString() << \"-\" << utils::hex(pixelFormat);\n> +\tss << size.toString() << \"-\" << utils::hex(pixelFormat)\n> +\t << \" \" << FourCC(pixelFormat);\n> \treturn ss.str();\n> }\n>","headers":{"Return-Path":"","Received":["from mail-qk1-x742.google.com (mail-qk1-x742.google.com\n\t[IPv6:2607:f8b0:4864:20::742])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5443B608DA\n\tfor ;\n\tFri, 31 Jan 2020 16:20:38 +0100 (CET)","by mail-qk1-x742.google.com with SMTP id h23so6921451qkh.0\n\tfor ;\n\tFri, 31 Jan 2020 07:20:38 -0800 (PST)","from nicolas-tpx395.localdomain ([2610:98:8005::527])\n\tby smtp.gmail.com with ESMTPSA id\n\tx6sm4531205qkh.20.2020.01.31.07.20.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 31 Jan 2020 07:20:36 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=9ZCzZj2v09Q52SmNuKp9a12lTJGChDW4ty1LS7KiYLg=;\n\tb=ZbFMDRaF6ib9c7tLckttXIvyXIbrnVX4HxV0eqn/AA6neA14vRNJOftVkHFkAsNVR3\n\ttgOdDVRNrtZ+9n54aHfv5Dkjr2r3totvnPGGmUdkVx+CjPiTGqffWc+1QINUCNpRp+HZ\n\tZGCEYpoZ7FuWngzF4S/5KJPX3p+Iyo9wqIJIJLas5Owv4RWB14Tucl6TO4OyN7SIK1JT\n\twM7IwBQ1QvQTrrYeFlafDaYLrMc+a+06S5QKt33buhuWUOs2HyGjMsowYViJeBFtWfIb\n\t0oopeS0xbpCRpDeMSM9sXPBAamxpDT8k3LjR3WfvHF+w0sqxa++DpG4vhkHjglpyG0an\n\tjwYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=9ZCzZj2v09Q52SmNuKp9a12lTJGChDW4ty1LS7KiYLg=;\n\tb=QLSv6prRC0UubFrq+rJokNTUAkcs0N4Ysp6y23vQIGGeJkKclZWzKgNc6p3WbxfYsR\n\tyF/dKOTzShvdHfp2KV+9SUXV+n42cN2vvyx9SL0yECn9uIzav4ZKPguvbvVJn5KFxTVr\n\tl0+KrczbyMkRsW0pJ1wRoFfrvSBlVvrkvmfaEkMlhNGzF8RjfFxUR7ByM7uQ8IIYdCCs\n\tuH4o5pTGf4en6s3vh5PPeYbTb978z2dspfU8JUP10xreploFO2zPB+icp59aNKe0yHZI\n\tLicEWzyBtrD32GqjCPUduSzMJ8dlxaz+hTJS+6RY75CmMRpGglFYyUsh2MrlaRtQAW4E\n\tqoyw==","X-Gm-Message-State":"APjAAAUas1nuwRdAfTUkmQ1qoTD9m/JB97zCaesLZ29rjfUJbA9TYgDI\n\tOvvo8N2ApQ/LxxSSmeSqKpJEYw==","X-Google-Smtp-Source":"APXvYqwlkh4yWGAwNTnu97B+S59qW5jjzTEea4zJmCZ7fDqXW4DN5eOXTBMEVi2POB86rE0C32pyyg==","X-Received":"by 2002:ae9:f408:: with SMTP id y8mr10695689qkl.97.1580484037120;\n\tFri, 31 Jan 2020 07:20:37 -0800 (PST)","Message-ID":"<501f291fb3338b07ffe8716874f7bbe0f14b07e1.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Kieran Bingham , LibCamera Devel\n\t","Date":"Fri, 31 Jan 2020 10:20:35 -0500","In-Reply-To":"<20200130213809.16564-1-kieran.bingham@ideasonboard.com>","References":"<20200130213809.16564-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.3 (3.34.3-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 31 Jan 2020 15:20:38 -0000"}},{"id":3606,"web_url":"https://patchwork.libcamera.org/comment/3606/","msgid":"","date":"2020-01-31T15:22:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn 31/01/2020 15:20, Nicolas Dufresne wrote:\n> Le jeudi 30 janvier 2020 à 21:38 +0000, Kieran Bingham a écrit :\n>> Provide a helper to print the FourCC string representation, and utilise\n>> it to improve the readability of the StreamConfiguration.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> This changes the output of the line:\n>> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d\n>>\n>> to read:\n>> [159:34:26.262068766] [16497] INFO Camera camera.cpp:784 configuring streams: (0) 1920x1080-0x47504a4d MJPG\n> \n> Perhaps we could drop the hex form ? Is it really useful ?\n\nIndeed it probably isn't!\n\nI'll remove this as part of the respin to a class/struct as suggested by\nLaurent.\n\n--\nKieran\n\n\n>>\n>> include/libcamera/pixelformats.h | 3 +++\n>> src/libcamera/pixelformats.cpp | 20 ++++++++++++++++++++\n>> src/libcamera/stream.cpp | 3 ++-\n>> 3 files changed, 25 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixelformats.h\n>> index 6e25b8d8b76e..32cff083cdf9 100644\n>> --- a/include/libcamera/pixelformats.h\n>> +++ b/include/libcamera/pixelformats.h\n>> @@ -8,11 +8,14 @@\n>> #define __LIBCAMERA_PIXEL_FORMATS_H__\n>> \n>> #include \n>> +#include \n>> \n>> namespace libcamera {\n>> \n>> using PixelFormat = uint32_t;\n>> \n>> +std::string FourCC(const PixelFormat &p);\n>> +\n>> } /* namespace libcamera */\n>> \n>> #endif /* __LIBCAMERA_PIXEL_FORMATS_H__ */\n>> diff --git a/src/libcamera/pixelformats.cpp b/src/libcamera/pixelformats.cpp\n>> index c03335400b70..d6b2c6a3dba5 100644\n>> --- a/src/libcamera/pixelformats.cpp\n>> +++ b/src/libcamera/pixelformats.cpp\n>> @@ -7,6 +7,8 @@\n>> \n>> #include \n>> \n>> +#include \n>> +\n>> /**\n>> * \\file pixelformats.h\n>> * \\brief libcamera pixel formats\n>> @@ -25,4 +27,22 @@ namespace libcamera {\n>> * \\todo Add support for format modifiers\n>> */\n>> \n>> +/**\n>> + * \\brief Return a PixelFormat as a FourCC string representation\n>> + */\n>> +std::string FourCC(const PixelFormat &p)\n>> +{\n>> +\tstd::stringstream ss;\n>> +\n>> +\tss << static_cast(p & 0x7f)\n>> +\t << static_cast((p >> 8) & 0x7f)\n>> +\t << static_cast((p >> 16) & 0x7f)\n>> +\t << static_cast((p >> 24) & 0x7f);\n>> +\n>> +\tif (p & (1 << 31))\n>> +\t\tss << \"-BE\";\n>> +\n>> +\treturn ss.str();\n>> +}\n>> +\n>> } /* namespace libcamera */\n>> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n>> index 13789e9eb344..4efe4385326f 100644\n>> --- a/src/libcamera/stream.cpp\n>> +++ b/src/libcamera/stream.cpp\n>> @@ -348,7 +348,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n>> std::string StreamConfiguration::toString() const\n>> {\n>> \tstd::stringstream ss;\n>> -\tss << size.toString() << \"-\" << utils::hex(pixelFormat);\n>> +\tss << size.toString() << \"-\" << utils::hex(pixelFormat)\n>> +\t << \" \" << FourCC(pixelFormat);\n>> \treturn ss.str();\n>> }\n>> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92893608DA\n\tfor ;\n\tFri, 31 Jan 2020 16:22:32 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1727371D;\n\tFri, 31 Jan 2020 16:22:32 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580484152;\n\tbh=VCY2HKaFVuGGDhUJOv4Vu5eFve/X3yirofS1jR/30vA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=eeJuuLsNg6SaRj/0g8X7RJMF3CWIrbydrc2xZ7uely8TEm098xjOoR3CIkTu4hgdN\n\tPuuGiCqD8FhKRIN4IinPLYQ+eHaBxYQah4MBgBXO7u9IHtJ5wGEGUWXkY9sE2IWIsk\n\txOiwkJmg+lXLNnKEHE0iEdqXMTl2XpWqlWA1wdHo=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Nicolas Dufresne ,\n\tLibCamera Devel ","References":"<20200130213809.16564-1-kieran.bingham@ideasonboard.com>\n\t<501f291fb3338b07ffe8716874f7bbe0f14b07e1.camel@ndufresne.ca>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 31 Jan 2020 15:22:29 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<501f291fb3338b07ffe8716874f7bbe0f14b07e1.camel@ndufresne.ca>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: PixelFormat: Define a\n\tFourCC output helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 31 Jan 2020 15:22:32 -0000"}}]