{"id":27609,"url":"https://patchwork.libcamera.org/api/patches/27609/?format=json","web_url":"https://patchwork.libcamera.org/patch/27609/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260804101949.353266-8-barnabas.pocze@ideasonboard.com>","date":"2026-08-04T10:19:46","name":"[RFC,v1,07/10] libcamera: egl: initEGLContext(): Avoid double init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"772fd242b6a5815599feae1799386eba54848a25","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27609/mbox/","series":[{"id":6105,"url":"https://patchwork.libcamera.org/api/series/6105/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6105","date":"2026-08-04T10:19:39","name":"libcamera: software_isp: debayer_egl: Remove some leaks","version":1,"mbox":"https://patchwork.libcamera.org/series/6105/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27609/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27609/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D84D3C3333\n\tfor ;\n\tTue, 4 Aug 2026 10:20:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 463F8680B9;\n\tTue, 4 Aug 2026 12:20:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C21E368087\n\tfor ;\n\tTue, 4 Aug 2026 12:19:53 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4254FDA8\n\tfor ;\n\tTue, 4 Aug 2026 12:18:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BvKE62LW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838724;\n\tbh=g4jt54kXxvnWrcff0ensF6BIPmkQQbdUZ7xO/oY1Wb8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BvKE62LWFuSVsZFwF0tnFlxQXiSbzFSn6Ps7/cD9W9rya7Zff9IOSxbnK7yGQ4lrz\n\tx+Fdmo5ezf7LPe6LBE0s4aAXu4LERfIUdLLXIrrNtYPMEvGNoX/HC3tIyJXPRYWYEF\n\tUqhvFeZzqW1uVpICsqoZ6o7VV6BmI96PMvbBHPEk=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 07/10] libcamera: egl: initEGLContext(): Avoid double\n\tinit","Date":"Tue, 4 Aug 2026 12:19:46 +0200","Message-ID":"<20260804101949.353266-8-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","References":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the initialization is already done, reject further attempts,\notherwise resources would be leaked.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/egl.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 6b50e7bb77..5e75c3a6d2 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -359,7 +359,7 @@ void eGL::createOutputTexture2D(eGLImage &eglImage)\n * - eglCreateImageKHR / eglDestroyImageKHR\n * - glEGLImageTargetTexture2DOES\n *\n- * \\return 0 on success, or -ENODEV on failure\n+ * \\return 0 on success, or negative error code on failure\n */\n int eGL::initEGLContext()\n {\n@@ -382,6 +382,9 @@ int eGL::initEGLContext()\n \tEGLint numConfigs;\n \tEGLConfig config;\n \n+\tif (context_ != EGL_NO_CONTEXT)\n+\t\treturn -EEXIST;\n+\n \tif (!eglBindAPI(EGL_OPENGL_ES_API)) {\n \t\tLOG(eGL, Error) << \"API bind fail\";\n \t\tgoto fail;\n","prefixes":["RFC","v1","07/10"]}