{"id":27605,"url":"https://patchwork.libcamera.org/api/patches/27605/?format=json","web_url":"https://patchwork.libcamera.org/patch/27605/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260804101949.353266-4-barnabas.pocze@ideasonboard.com>","date":"2026-08-04T10:19:42","name":"[RFC,v1,03/10] libcamera: egl: Do not load `glGetString` dynamically","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3f0067d5b3a6feec2bb349b40c0cb6e6e9cd5a88","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27605/mbox/","series":[{"id":6105,"url":"https://patchwork.libcamera.org/api/series/6105/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6105","date":"2026-08-04T10:19:39","name":"libcamera: software_isp: debayer_egl: Remove some leaks","version":1,"mbox":"https://patchwork.libcamera.org/series/6105/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27605/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27605/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B325C3301\n\tfor ;\n\tTue, 4 Aug 2026 10:20:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CB4F680B3;\n\tTue, 4 Aug 2026 12:19:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DD4968083\n\tfor ;\n\tTue, 4 Aug 2026 12:19:53 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85754DA8\n\tfor ;\n\tTue, 4 Aug 2026 12:18:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PCkJA+iD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838723;\n\tbh=xUiaQZd5tzlL4fxEfKE3i0B6g9ntU+CSgwbX3/eG+E4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PCkJA+iDUltDUttSeFRihECa2EIvk261F0txCySx1mhCxn2oN1Hm24mYEpWOXNE9P\n\t4OhgJvXlmeQ1IuPudOIFjUG3idtvy1RjPl5/dQVMEGdUbuTHL5XbxohYyGflfeyCaG\n\tP3BMyyfDiGuTBn2ALiDALlRrQFZY6IQL84vx1rz0=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 03/10] libcamera: egl: Do not load `glGetString`\n\tdynamically","Date":"Tue, 4 Aug 2026 12:19:42 +0200","Message-ID":"<20260804101949.353266-4-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","References":"<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`glGetString()` should be available in all version of OpenGL and OpenGL ES,\nso there should be no need to load it with `eglGetProcAddress()` like it is\ndone for extension functions.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/egl.h | 1 -\n src/libcamera/egl.cpp | 6 ------\n 2 files changed, 7 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex f8ae486a8d..6abb02bf3b 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -142,6 +142,5 @@ private:\n \tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n \tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n \tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n-\tPFNGLGETSTRINGPROC glGetString;\n };\n } //namespace libcamera\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 900d2174df..0768a840e6 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -410,12 +410,6 @@ int eGL::initEGLContext()\n \t\tgoto fail;\n \t}\n \n-\tglGetString = (PFNGLGETSTRINGPROC)eglGetProcAddress(\"glGetString\");\n-\tif (!glGetString) {\n-\t\tLOG(eGL, Error) << \"glGetString not found\";\n-\t\tgoto fail;\n-\t}\n-\n \tif (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n \t\tLOG(eGL, Error) << \"eglChooseConfig fail\";\n \t\tgoto fail;\n","prefixes":["RFC","v1","03/10"]}