[{"id":3600,"web_url":"https://patchwork.libcamera.org/comment/3600/","msgid":"","date":"2020-01-29T21:37:40","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","submitter":{"id":33,"url":"https://patchwork.libcamera.org/api/people/33/","name":"Peter Griffin","email":"peter.griffin@linaro.org"},"content":"Hi Madhavan,\n\nThe patch is missing your Signed off by (need to use -s with\ngit commit command).\n\nPeter.\n\nOn Wed, 29 Jan 2020 at 11:16, Madhavan Krishnan <\nmadhavan.krishnan@linaro.org> wrote:\n\n> From: Madhavan Krishnan \n>\n> New argument dev_t devnum has been added in the registerCamera()\n> api and we are facing compilation issue in the musl environment\n> since dev_t is not declared, we addded sys/stat.h header file\n> ---\n> src/libcamera/include/pipeline_handler.h | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/include/pipeline_handler.h\n> b/src/libcamera/include/pipeline_handler.h\n> index a6c1e1f..c5f84aa 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -12,6 +12,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n>\n> --\n> 2.7.4\n>\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE4FB608C6\n\tfor ;\n\tWed, 29 Jan 2020 22:37:52 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id t23so748053lfk.6\n\tfor ;\n\tWed, 29 Jan 2020 13:37:52 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=mzWnNRmljhe2ZinFkHsDeYdkZ3jZ9sFqY+5Kw/mIB+4=;\n\tb=OriLO7GE8sDt+OaNq4MH+8r+JOO6nYcabVEvqKfwWD7dBOW8HZcTG9qoI5L1FaF7V5\n\tJJh02XVpY2xDOQOaO31cETCZbgqy4YXdZHnjAqnNlnu2xSxvAnR7vrhmcwGF+S6PfmSZ\n\tnV4ktAl2Dgalxx+cCpRn1b01b5Ug7ATwEI4RmWJMR1qQ/zF3gtVSIVnfxk86h17ZwZV1\n\tn7PU+iAsl8npLKbJtdyS70dPCNKgxrWhbr67QlZO03YFEkM5LPjkYHOEwSU/nZmnqtOL\n\tyobISMOV4QRmrP4A6EZtDLe/s5+NxtYd/kN5D/xKmMDglc6IQiU1dK4UuOulgGtRqqpR\n\tk02w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=mzWnNRmljhe2ZinFkHsDeYdkZ3jZ9sFqY+5Kw/mIB+4=;\n\tb=UxopKnIuomUHE9HpTd2effR1sA2LkhFZpYbmqeThZaE240SHx8lTySX3G7sfSESryA\n\tFBWiW17XyH5XnEwtTekKCOgTkMP4xW/CxMyXCQOha+wQAJejBGqv6nio/mjrjhS1UPy7\n\tf8QSTottmNwE+wLMUe9juAXig/5eh2xlVmryHsDXpb8uOq377Ps4epwYdAce60/HCk9L\n\tFGj2PRIBoURzi3TsEcG/3ng0+EJ7s7F18Mr52OxQsUgdH4p94X6CvxC2xEc+AALTHyr9\n\tSRm0yohbxXWGKsLVlM/xxcC+2gssu9AJLTcC6K5CUf0XxvwZEwCW7FVikq2m5zUkdkFd\n\tQOgg==","X-Gm-Message-State":"APjAAAWgswZmnyo6ajf4RYls0Opz8x8WziXldPk2nvt7vpFxevx0HyZs\n\tbv9wu7VeBRM1d3B8H09qLRJ5WDPelBXE0zgh2UWeXw==","X-Google-Smtp-Source":"APXvYqyhyNbHV6/fIuGAI9q9ec1R0lCBwO79K9OBzYF0YFGqkMZgH3GeI69iUzKY6cWYYDDVcFm7YjKzrX1tET0zQ9Q=","X-Received":"by 2002:a19:7515:: with SMTP id y21mr678193lfe.45.1580333872097; \n\tWed, 29 Jan 2020 13:37:52 -0800 (PST)","MIME-Version":"1.0","References":"<1580296587-12204-1-git-send-email-Riyaz_Khan@comcast.com>","In-Reply-To":"<1580296587-12204-1-git-send-email-Riyaz_Khan@comcast.com>","From":"Peter Griffin ","Date":"Wed, 29 Jan 2020 21:37:40 +0000","Message-ID":"","To":"Madhavan Krishnan ","Cc":"libcamera-devel@lists.libcamera.org, \n\tMoorthy Baskaravenkatraman Sambamoorthy\n\t","Content-Type":"multipart/alternative; boundary=\"00000000000012c2e1059d4e2749\"","X-Mailman-Approved-At":"Wed, 29 Jan 2020 22:41:14 +0100","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 21:37:53 -0000"}},{"id":3601,"web_url":"https://patchwork.libcamera.org/comment/3601/","msgid":"<20200129214936.GB5868@pendragon.ideasonboard.com>","date":"2020-01-29T21:49:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Madhavan,\n\nThank you for the patch.\n\nOn Wed, Jan 29, 2020 at 12:16:27PM +0100, Madhavan Krishnan wrote:\n> From: Madhavan Krishnan \n> \n> New argument dev_t devnum has been added in the registerCamera()\n> api and we are facing compilation issue in the musl environment\n> since dev_t is not declared, we addded sys/stat.h header file\n\nIn addition to your Signed-off-by line, this should also have a Fixes\nline pointing to the commit that introduced the issue. See for instance\ncommit 744fabcbb938d60cdbc0dfadc625bbd6798c2485 for a example.\n\n> ---\n> src/libcamera/include/pipeline_handler.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index a6c1e1f..c5f84aa 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -12,6 +12,7 @@\n> #include \n> #include \n> #include \n> +#include \n\nPOSIX mandates dev_t to be defined by sys/types.h, so I think that would\nbe a better header to include. sys/sysmacros.h should then be dropped as\nit wasn't the correct choice. You can explain this in the commit\nmessage, stating that sys/sysmacros.h was an incorrect choice, which\ndoesn't work with musl.\n\n> #include \n> #include \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15B56608C6\n\tfor ;\n\tWed, 29 Jan 2020 22:49:59 +0100 (CET)","from pendragon.ideasonboard.com (85-76-72-22-nat.elisa-mobile.fi\n\t[85.76.72.22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76AD8516;\n\tWed, 29 Jan 2020 22:49:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580334598;\n\tbh=BpEx4NJHMjbERImFRSrXoDLRWvqPh4L9kvREkvA051k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wMILXBtQGr0swL5LwZ3xfd00hOHn7ZQfZIiKc4d78g3XE2V50Z7EFnDbrrKLHgM/x\n\tU58AGVe7fyZEQhGf9ANnMAcwhw2uDJNLYq9RQ5+rhGsHX1U5GHYAnM2fgkvvZSWcXB\n\t66qyWNYWfdezr3zBBVXInx0eJEJz95ukw3sbzDbY=","Date":"Wed, 29 Jan 2020 23:49:36 +0200","From":"Laurent Pinchart ","To":"Madhavan Krishnan ","Cc":"libcamera-devel@lists.libcamera.org, peter.griffin@linaro.org,\n\tmoorthy.baskaravenkatraman-sambamoorthy@linaro.org","Message-ID":"<20200129214936.GB5868@pendragon.ideasonboard.com>","References":"\n\t<1580296587-12204-1-git-send-email-Riyaz_Khan@comcast.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1580296587-12204-1-git-send-email-Riyaz_Khan@comcast.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 21:49:59 -0000"}},{"id":3604,"web_url":"https://patchwork.libcamera.org/comment/3604/","msgid":"<7a02a182-3d93-4b1e-138c-39aaf35a7c4f@ideasonboard.com>","date":"2020-01-31T10:27:13","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent, Madhavan,\n\nAye aye aye,\n\nI've already submitted such a patch, and it's been reviewed - so I must\nnot have integrated it yet :-(\n\nhttps://lists.libcamera.org/pipermail/libcamera-devel/2020-January/006315.html\n\nI'll go check out why it's not yet upstream and make sure something gets\nup fast.\n\nNow that this has been reported directly as well I'll add:\n\"Reported-by: Madhavan Krishnan \" to my patch.\n\n\n\nOn 29/01/2020 21:49, Laurent Pinchart wrote:\n> Hi Madhavan,\n> \n> Thank you for the patch.\n> \n> On Wed, Jan 29, 2020 at 12:16:27PM +0100, Madhavan Krishnan wrote:\n>> From: Madhavan Krishnan \n>>\n>> New argument dev_t devnum has been added in the registerCamera()\n>> api and we are facing compilation issue in the musl environment\n>> since dev_t is not declared, we addded sys/stat.h header file\n> \n> In addition to your Signed-off-by line, this should also have a Fixes\n> line pointing to the commit that introduced the issue. See for instance\n> commit 744fabcbb938d60cdbc0dfadc625bbd6798c2485 for a example.\n> \n>> ---\n>> src/libcamera/include/pipeline_handler.h | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n>> index a6c1e1f..c5f84aa 100644\n>> --- a/src/libcamera/include/pipeline_handler.h\n>> +++ b/src/libcamera/include/pipeline_handler.h\n>> @@ -12,6 +12,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n> \n> POSIX mandates dev_t to be defined by sys/types.h, so I think that would\n> be a better header to include. sys/sysmacros.h should then be dropped as\n> it wasn't the correct choice. You can explain this in the commit\n> message, stating that sys/sysmacros.h was an incorrect choice, which\n> doesn't work with musl.\n\n\nMy previous patch doesn't remove sys/sysmacros. I'll update it to do so,\nretest, and repost before integrating.\n\n--\nKieran\n\n\n> \n>> #include \n>> #include \n>> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B03B4608D7\n\tfor ;\n\tFri, 31 Jan 2020 11:27:16 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2CD771D;\n\tFri, 31 Jan 2020 11:27:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580466436;\n\tbh=zMD9FjdksBzpf+PEUMwADvdbH6rK88jOBDeC0YwOtPA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=X9RTw8yh6eL5/IGpQh6PsJUzADgJO7Sw9IifpUhELs45ReshiLOwSpcbVmXfG/BR6\n\tPt49AwKOjgBMUDY7hi52TH8SXO6wlnichpqKRHnxF6h5zSo6Zx1YB19q9AaIE4i63U\n\thP04gGtxphjVV6zJVRjVpAjTCMEHuNN/Ymv9OLrc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tMadhavan Krishnan ","Cc":"peter.griffin@linaro.org, libcamera-devel@lists.libcamera.org,\n\tmoorthy.baskaravenkatraman-sambamoorthy@linaro.org","References":"\n\t<1580296587-12204-1-git-send-email-Riyaz_Khan@comcast.com>\n\t<20200129214936.GB5868@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7a02a182-3d93-4b1e-138c-39aaf35a7c4f@ideasonboard.com>","Date":"Fri, 31 Jan 2020 10:27:13 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200129214936.GB5868@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix compilation issue in\n\tmusl environment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 31 Jan 2020 10:27:16 -0000"}}]