{"id":27584,"url":"https://patchwork.libcamera.org/api/patches/27584/?format=json","web_url":"https://patchwork.libcamera.org/patch/27584/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260803131435.153927-35-barnabas.pocze@ideasonboard.com>","date":"2026-08-03T13:14:19","name":"[RFC,v3,34/50] ipa: libipa: histogram: total(): Use `back()`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"99ea65f1849af96f38ad552680a033846074d4f4","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27584/mbox/","series":[{"id":6103,"url":"https://patchwork.libcamera.org/api/series/6103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6103","date":"2026-08-03T13:13:45","name":"ipa: libipa: agc rework","version":3,"mbox":"https://patchwork.libcamera.org/series/6103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27584/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27584/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92CD1BDE4C\n\tfor ;\n\tMon, 3 Aug 2026 13:15:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87CAE68080;\n\tMon, 3 Aug 2026 15:15:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6CC56807A\n\tfor ;\n\tMon, 3 Aug 2026 15:14:46 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C704C512;\n\tMon, 3 Aug 2026 15:13:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZMi92USq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762817;\n\tbh=Tco1sySte1EpSQtv1XDJ2p8BUe1HTciWJVdURdyMVzI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZMi92USqHQudFwRPCvlCC8OLcvWHmvfBbUXQpbWffQlvzWJ0HmF14IdevkseAzZ7s\n\txeKI4QR029N3GKnT106L2QIjf60SIuHT+HNqVWhRxebOm+yzCqoFZQXEANfp7bAwgG\n\tdB5sMkxnoayYRbJw9XyVi1B9oksAIhkutblTPWnQ=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[RFC PATCH v3 34/50] ipa: libipa: histogram: total(): Use `back()`","Date":"Mon, 3 Aug 2026 15:14:19 +0200","Message-ID":"<20260803131435.153927-35-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","References":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the back method of `std::vector` to get the last element\ninstead of indexing; this is clearer.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \n---\n src/ipa/libipa/histogram.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex 8cf8bb6d16..0c02dda2ba 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -37,7 +37,7 @@ public:\n \n \tsize_t bins() const { return cumulative_.size() - 1; }\n \tSpan data() const { return cumulative_; }\n-\tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n+\tuint64_t total() const { return cumulative_.back(); }\n \tuint64_t cumulativeFrequency(double bin) const;\n \tdouble quantile(double q, uint32_t first = 0, uint32_t last = UINT_MAX) const;\n \tdouble interQuantileMean(double lowQuantile, double hiQuantile) const;\n","prefixes":["RFC","v3","34/50"]}