{"id":27578,"url":"https://patchwork.libcamera.org/api/patches/27578/?format=json","web_url":"https://patchwork.libcamera.org/patch/27578/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260803131435.153927-27-barnabas.pocze@ideasonboard.com>","date":"2026-08-03T13:14:11","name":"[RFC,v3,26/50] ipa: libipa: agc: Store digital gain","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ea9fed3b35597a62d5e4e0f816fa405f74181fe","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27578/mbox/","series":[{"id":6103,"url":"https://patchwork.libcamera.org/api/series/6103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6103","date":"2026-08-03T13:13:45","name":"ipa: libipa: agc rework","version":3,"mbox":"https://patchwork.libcamera.org/series/6103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27578/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27578/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 752FFC333F\n\tfor ;\n\tMon, 3 Aug 2026 13:15:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0F08680E5;\n\tMon, 3 Aug 2026 15:15:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC3D568099\n\tfor ;\n\tMon, 3 Aug 2026 15:14:44 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7AC6981\n\tfor ;\n\tMon, 3 Aug 2026 15:13:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"csZZQxbj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762816;\n\tbh=kz+5+wqwO0NDaVrSqKS/DXHRZS7pQug6lnSow8DYewM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=csZZQxbjPO5umjDlc1FPKg9OB7aGmJehDz22DYCtkfDqmsAjmqlIVEOz2nntZt8kP\n\tv5O1W2foNe58JMdBH1LhhBbTFJqhy0voxKYfbINz4+4PRjuepZpE+EZblec8kt85l6\n\trjbLcKsCty9TKKZT8pTcJsI5W5X4WDyPhbrvW+ao=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v3 26/50] ipa: libipa: agc: Store digital gain","Date":"Mon, 3 Aug 2026 15:14:11 +0200","Message-ID":"<20260803131435.153927-27-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","References":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While digital gain support is not implemented yet, start by storing\nthe suggested digital gain in the active state.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc.cpp | 7 ++++++-\n src/ipa/libipa/agc.h | 1 +\n 2 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex 5273c1f64b..e9055ddd7b 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -100,6 +100,9 @@ LOG_DEFINE_CATEGORY(Agc)\n * \\var agc::ActiveState::automatic.quantizationGain\n * \\brief Automatic quantization gain multiplier\n *\n+ * \\var agc::ActiveState::automatic.digitalGain\n+ * \\brief Automatic digital gain multiplier\n+ *\n * \\var agc::ActiveState::automatic.yTarget\n * \\brief Automatically determined luminance target\n *\n@@ -322,6 +325,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,\n \tstate.automatic.gain = session.minAnalogueGain;\n \tstate.automatic.exposure = defExposure;\n \tstate.automatic.quantizationGain = 1;\n+\tstate.automatic.digitalGain = 1;\n \tstate.automatic.yTarget = impl_.effectiveYTarget(0, 1);\n \tstate.manual.gain = state.automatic.gain;\n \tstate.manual.exposure = state.automatic.exposure;\n@@ -598,6 +602,7 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,\n \t\tstate.automatic.exposure = newEv.exposureTime / lineDuration;\n \t\tstate.automatic.gain = newEv.analogueGain;\n \t\tstate.automatic.quantizationGain = newEv.quantizationGain;\n+\t\tstate.automatic.digitalGain = newEv.digitalGain;\n \t\tstate.automatic.yTarget = newEv.yTarget;\n \n \t\tnewExposureTime = newEv.exposureTime;\n@@ -606,7 +611,7 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,\n \t\t\t<< \"exposure-time:\" << utils::Duration(state.automatic.exposure * lineDuration)\n \t\t\t<< \" analogue-gain:\" << state.automatic.gain\n \t\t\t<< \" quantization-gain:\" << state.automatic.quantizationGain\n-\t\t\t<< \" digital-gain:\" << newEv.digitalGain;\n+\t\t\t<< \" digital-gain:\" << state.automatic.digitalGain;\n \t}\n \n \t/*\ndiff --git a/src/ipa/libipa/agc.h b/src/ipa/libipa/agc.h\nindex ab85d9a3bd..b0f811e93d 100644\n--- a/src/ipa/libipa/agc.h\n+++ b/src/ipa/libipa/agc.h\n@@ -74,6 +74,7 @@ struct ActiveState {\n \t\tuint32_t exposure;\n \t\tdouble gain;\n \t\tdouble quantizationGain;\n+\t\tdouble digitalGain;\n \t\tdouble yTarget;\n \t} automatic;\n \n","prefixes":["RFC","v3","26/50"]}