{"id":27576,"url":"https://patchwork.libcamera.org/api/patches/27576/?format=json","web_url":"https://patchwork.libcamera.org/patch/27576/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260803131435.153927-29-barnabas.pocze@ideasonboard.com>","date":"2026-08-03T13:14:13","name":"[RFC,v3,28/50] ipa: libipa: agc: Fix multiplication type","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"683d29e59c578b54ba7c4f4534007386a74e42dd","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27576/mbox/","series":[{"id":6103,"url":"https://patchwork.libcamera.org/api/series/6103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6103","date":"2026-08-03T13:13:45","name":"ipa: libipa: agc rework","version":3,"mbox":"https://patchwork.libcamera.org/series/6103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27576/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27576/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2682DC333D\n\tfor ;\n\tMon, 3 Aug 2026 13:15:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48A06680EF;\n\tMon, 3 Aug 2026 15:15:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32CF96806F\n\tfor ;\n\tMon, 3 Aug 2026 15:14:45 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53200512\n\tfor ;\n\tMon, 3 Aug 2026 15:13:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vz4LbAh/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762816;\n\tbh=of4UYaR2YupW3cysmpKoxiRlZJ/ADr5ya8FRWarQAC0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vz4LbAh/QGl8YJy7Jy4VVdKf9UmXXLiUsOT1lsYDJmmm1barQroJYN95OGhfhDTsV\n\t6yr7WR1UIIUtwPf83T/gRmxljfaJrEIO3yJ4jBJv2pXK3b+iuti0cFKnAJKZ0OiDEN\n\tB9S3TLXYpTxpgHRf9rPRP7Rg69+AauSoDfchBrSw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v3 28/50] ipa: libipa: agc: Fix multiplication type","Date":"Mon, 3 Aug 2026 15:14:13 +0200","Message-ID":"<20260803131435.153927-29-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","References":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The type of `frameSize` is `uint64_t`, but it is assigned the result\nof a 32-bit multiplication. So make one of the terms a 64-bit integer\nso that the result will be actually 64-bit.\n\nFurthermore, also adjust the calculation to do the multiplication first\njust to be as accurate as possible. No wraparound will happen as long\nas the frame size is less than about 16.7 TiB.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex 0f787925cb..f420dfdce4 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -297,8 +297,8 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,\n \n \tstd::array frameDurations;\n \tfor (unsigned int i = 0; i < frameHeights.size(); ++i) {\n-\t\tuint64_t frameSize = lineLength * frameHeights[i];\n-\t\tframeDurations[i] = frameSize / (config.sensorInfo.pixelRate / 1000000U);\n+\t\tuint64_t frameSize = uint64_t(lineLength) * frameHeights[i];\n+\t\tframeDurations[i] = frameSize * 1000000U / config.sensorInfo.pixelRate;\n \t}\n \n \t/*\n","prefixes":["RFC","v3","28/50"]}