{"id":27571,"url":"https://patchwork.libcamera.org/api/patches/27571/?format=json","web_url":"https://patchwork.libcamera.org/patch/27571/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260803131435.153927-24-barnabas.pocze@ideasonboard.com>","date":"2026-08-03T13:14:08","name":"[RFC,v3,23/50] ipa: libipa: agc: Use default exposure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4f25b923e71bade5837edee63b9263ab1a2824c8","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27571/mbox/","series":[{"id":6103,"url":"https://patchwork.libcamera.org/api/series/6103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6103","date":"2026-08-03T13:13:45","name":"ipa: libipa: agc rework","version":3,"mbox":"https://patchwork.libcamera.org/series/6103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27571/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27571/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95582C3338\n\tfor ;\n\tMon, 3 Aug 2026 13:15:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FB8E680DF;\n\tMon, 3 Aug 2026 15:15:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3101068093\n\tfor ;\n\tMon, 3 Aug 2026 15:14:44 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45730512;\n\tMon, 3 Aug 2026 15:13:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NmGGoHfk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762815;\n\tbh=RClYYqGKmEfZhEKDUyMz44xdrd2SCDzCumwwFjJRFB0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NmGGoHfkK9Fl8ARogKIq6bPLEUQPQy0DY6VpFQ2hb5mJA8UxBo/8V5Ff2WL/B4tR7\n\tkfwAUUaCa6mrcQpsde7i1wdf+nsu3gUpeF8Fe0quzXNFzxLCGFMwD1lxzQB7fJwtat\n\t/TMgZOX1z/QEZ0BijLIk4EowTH3C6qHjDXRby+hA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[RFC PATCH v3 23/50] ipa: libipa: agc: Use default exposure","Date":"Mon, 3 Aug 2026 15:14:08 +0200","Message-ID":"<20260803131435.153927-24-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","References":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of hard-coding 10ms, just use the default exposure time\nas determined by the V4L2 control. This ensures that the advertised\ndefault in the `ControlInfo` matches what actually happens.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \n---\n src/ipa/libipa/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex d751a8b0b8..69debd8af7 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -318,7 +318,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,\n \t/* Configure the default exposure and gain. */\n \tstate = {};\n \tstate.automatic.gain = session.minAnalogueGain;\n-\tstate.automatic.exposure = 10ms / session.lineDuration;\n+\tstate.automatic.exposure = defExposure;\n \tstate.automatic.quantizationGain = 1;\n \tstate.automatic.yTarget = impl_.effectiveYTarget(0, 1);\n \tstate.manual.gain = state.automatic.gain;\n","prefixes":["RFC","v3","23/50"]}