{"id":27564,"url":"https://patchwork.libcamera.org/api/patches/27564/?format=json","web_url":"https://patchwork.libcamera.org/patch/27564/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260803131435.153927-16-barnabas.pocze@ideasonboard.com>","date":"2026-08-03T13:14:00","name":"[RFC,v3,15/50] ipa: libipa: agc_mean_luminance: constraintClampGain(): Mark `const`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0350dbf8ee6419bd2efd7bc852d27e42b38d7dc3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27564/mbox/","series":[{"id":6103,"url":"https://patchwork.libcamera.org/api/series/6103/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6103","date":"2026-08-03T13:13:45","name":"ipa: libipa: agc rework","version":3,"mbox":"https://patchwork.libcamera.org/series/6103/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27564/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DF32C3308\n\tfor ;\n\tMon, 3 Aug 2026 13:15:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9603D680CF;\n\tMon, 3 Aug 2026 15:14:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65B1768089\n\tfor ;\n\tMon, 3 Aug 2026 15:14:42 +0200 (CEST)","from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DEBA8D4;\n\tMon, 3 Aug 2026 15:13:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"unt+fmDt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762813;\n\tbh=tKb6tEzEF6yvv6s4kVkzvZX6ALH2umnJsxQh52QMicI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=unt+fmDtESzU1WCeCyRRYR0W1Ds+3FUwTJL5lR7y+772Sxj9EAKCs7MaV1KBD2hzt\n\tzZJ6r4izj/NvOROphHWL75RFcFDC0z+FvjPmmWR58+ZTIJx2tktUSnMeqeYVNbPamZ\n\t0GFaTea8dRuNcz+l8mnG4WivbOnAZVRSJhYYZzgA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[RFC PATCH v3 15/50] ipa: libipa: agc_mean_luminance:\n\tconstraintClampGain(): Mark `const`","Date":"Mon, 3 Aug 2026 15:14:00 +0200","Message-ID":"<20260803131435.153927-16-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","References":"<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason not to have this member function as `const`. Change the\nmap lookup to use `at()` just like it is done for `calculateNewEv()`, with\nthe same requirement that validation is the job of the caller.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n src/ipa/libipa/agc_mean_luminance.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex bf7d164346..3a14d778a3 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -538,7 +538,7 @@ double AgcMeanLuminance::estimateInitialGain(const Traits &traits) const\n */\n double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t\t const Histogram &hist,\n-\t\t\t\t\t double gain)\n+\t\t\t\t\t double gain) const\n {\n \tauto applyConstraint = [this, &gain, &hist](const AgcConstraint &constraint) {\n \t\tdouble lux = lux_;\n@@ -568,7 +568,7 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t}\n \t};\n \n-\tstd::vector &constraints = constraintModes_[constraintModeIndex];\n+\tconst std::vector &constraints = constraintModes_.at(constraintModeIndex);\n \tstd::for_each(constraints.begin(), constraints.end(), applyConstraint);\n \n \tstd::for_each(additionalConstraints_.begin(), additionalConstraints_.end(), applyConstraint);\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex eb9d6fec2b..9b82d97ab6 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -105,7 +105,7 @@ private:\n \tdouble estimateInitialGain(const Traits &traits) const;\n \tdouble constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t const Histogram &hist,\n-\t\t\t\t double gain);\n+\t\t\t\t double gain) const;\n \tutils::Duration filterExposure(utils::Duration exposureValue);\n \n \tutils::Duration filteredExposure_;\n","prefixes":["RFC","v3","15/50"]}