[{"id":39933,"web_url":"https://patchwork.libcamera.org/comment/39933/","msgid":"","date":"2026-07-31T15:37:50","subject":"Re: [PATCH v4 2/2] libcamera: camera_sensor_properties: Add imx471","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi John\n\nOn Fri, Jul 31, 2026 at 08:15:35AM -0700, John Cronin wrote:\n> Register static properties for Sony IMX471 so soft-ISP no longer warns\n> about missing sensor properties.\n>\n> Unit cell size is ~1.4 µm (kernel active array 4656x3496). Test pattern\n> modes match imx471_test_pattern_menu[] in drivers/media/i2c/imx471.c.\n> Sensor control delays are left empty so libcamera uses its defaults\n> until measured.\n>\n> Signed-off-by: John Cronin \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n>\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp\n> b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index fc9e184..4823462 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -297,6 +297,20 @@ const CameraSensorProperties\n> *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t.hblankDelay = 2\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"imx471\", {\n> +\t\t\t/* ~1.4 µm pixels (nm); active array 4656x3496 in kernel. */\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t\t/* Matches imx471_test_pattern_menu[] in drivers/media/i2c/imx471.c */\n\neheh no need to re-state it. I can drop the comment when applying the\npatch.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 1 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> +\t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> +\t\t\t},\n> +\t\t\t/* Control delays not measured; use libcamera defaults. */\n> +\t\t\t.sensorDelays = { },\n> +\t\t} },\n> \t\t{ \"imx477\", {\n> \t\t\t.unitCellSize = { 1550, 1550 },\n> \t\t\t.testPatternModes = {},\n> --\n> 2.55.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6916EBE080\n\tfor ;\n\tFri, 31 Jul 2026 15:37:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CD2E65F9F;\n\tFri, 31 Jul 2026 17:37:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6525665F9F\n\tfor ;\n\tFri, 31 Jul 2026 17:37:53 +0200 (CEST)","from ideasonboard.com (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78DE6BE;\n\tFri, 31 Jul 2026 17:36:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sBFh9Do3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785512206;\n\tbh=5D1rrQQwoycSzUuk2JnXIQVG1nTlWeFtpYbkmyummt8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sBFh9Do32wyLbgz5Rm2fJ8Hrpz0FIzCs0NK8ZVb1RQMIDlj1wX5GBEpmea+KbqpHX\n\tvds0lvE61EyQGN6QuDNKc9ByQrany4rWrVaxM71UosUK7rP6xVargm479nH+3MPJ37\n\tGqRp/p+8QzFAZ1vSxNm65Dz8qnzCNW27OLAY3Crc=","Date":"Fri, 31 Jul 2026 17:37:50 +0200","From":"Jacopo Mondi ","To":"John Cronin ","Cc":"libcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com, \n\tkieran.bingham@ideasonboard.com","Subject":"Re: [PATCH v4 2/2] libcamera: camera_sensor_properties: Add imx471","Message-ID":"","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39936,"web_url":"https://patchwork.libcamera.org/comment/39936/","msgid":"","date":"2026-07-31T15:44:37","subject":"Re: [PATCH v4 2/2] libcamera: camera_sensor_properties: Add imx471","submitter":{"id":476,"url":"https://patchwork.libcamera.org/api/people/476/","name":"John Cronin","email":"john@stromback.com"},"content":"Hi Jacopo,\n\nThanks for the R-b. Please drop the test-pattern comment when applying\nas you suggested.\n\nJohn","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 021BCBE080\n\tfor ;\n\tFri, 31 Jul 2026 15:44:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABFCC67FE9;\n\tFri, 31 Jul 2026 17:44:41 +0200 (CEST)","from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com\n\t[IPv6:2607:f8b0:4864:20::112a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF22667FDC\n\tfor ;\n\tFri, 31 Jul 2026 17:44:39 +0200 (CEST)","by mail-yw1-x112a.google.com with SMTP id\n\t00721157ae682-81ed2a00f12so16693437b3.2\n\tfor ;\n\tFri, 31 Jul 2026 08:44:39 -0700 (PDT)","from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 08:44:37 -0700","from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 08:44:37 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=stromback-com.20251104.gappssmtp.com\n\theader.i=@stromback-com.20251104.gappssmtp.com\n\theader.b=\"vtJKTyRZ\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1785512679; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=NAQN2RKwQNl0z3e/UI+jP16gE8zD1Ke1SoX0F17Wn7cm6yfBi55pRT2FzocBkX8V9v\n\tNoQjn6ZsBEP/rm+MshiddecQ3NEATKoBrqvOk7hEzBJkq6eSY3zmbENTorQodDQ4xJWn\n\tgNnMgetAmxOagTTj6G536juFlxUkbhRSi3dOU0ySvx28uE4k1WywypxTJKrvWrKjgi0w\n\t6cGdwU46R5tewnrNwnhhb28VGDcVxCTCyIwQWFY1bAx/qacaRIwBcbcVMofexVyX6btq\n\tb4IHa2zwfVwV7pBHcRltL5J8K/oUTpJTZYCosYuuBvSlSa2/OSF6CcS0Ia2DapFWLlj0\n\tuBpQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=cc:to:subject:message-id:date:from:references:in-reply-to\n\t:mime-version:dkim-signature;\n\tbh=mqNou2iI9OhFirHxw3aiTeEk4yGSIYnFPpbQxUoniOQ=;\n\tfh=4ABwDVbi3TEfhgDpP3olu+HotWul1r8ABwbXyPI0LTA=;\n\tb=W7XyhtmwfgVAemff0RRWycI5ZgAV6SPR9it7D2rk+bPLYzNLXWEWgsRImxgXGncjrS\n\tGOiJ1AfJ9bV88cbrm7vhKvLWANSnSKye1iNPOBYjgJdhIkbvQxDhXs2UAEa0/5IWB4V2\n\tzb/y4RpMEpQ30YBSygbRy79FUQygmRqjZySQ7xaaqbe4Y+VclRF7S2Iy/9xHdYz/l4gM\n\t0t0mBMiqNs7PfSY2+8rAgZoFIbgL7EaAv/qpzEjBkUN6V1EKM9GcOMDmzjF+7/GIdUxS\n\tOkjz8QzwYAddTBLWCHngwQ7UzTz0/d8DjzzsurGGn/pR8hs26s32XncIhCa1qf26kAyY\n\th10Q==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=stromback-com.20251104.gappssmtp.com; s=20251104; t=1785512679;\n\tx=1786117479; darn=lists.libcamera.org; \n\th=content-type:cc:to:subject:message-id:date:from:references\n\t:in-reply-to:mime-version:from:to:cc:subject:date:message-id\n\t:reply-to:content-type;\n\tbh=mqNou2iI9OhFirHxw3aiTeEk4yGSIYnFPpbQxUoniOQ=;\n\tb=vtJKTyRZXxQZQhwyvhmUS89q37ItVDEWjEqJQ9fv6iRavmeGaEmEG59kP9i0RUG0Vp\n\t3JeihjjtAzMfJwdKc0nDjnbFwMjT054liQPFMbMZfPdOaY1ffTIcOxRBbazlLYdyqGTE\n\tmrj4TYsukyywJ34l8l4EZcF2ioceBT4HK/rK/L62IXMWQfHHcEmCCF+zfT63fJHQkKCe\n\t64x1RqjD7L4+qSer9VqDUgYXr5vLYROW8Rvgh3a89MlPm0jPo5RYd/ziN/xyj3QAWmJB\n\tS3cYkPcaWVtPHsinlG4+RWXg38lY9qyNJuP1MtT9JvFNYE8wIp8n1exrQ2GUckXiOL9B\n\tGbaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1785512679; x=1786117479;\n\th=content-type:cc:to:subject:message-id:date:from:references\n\t:in-reply-to:mime-version:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to:content-type;\n\tbh=mqNou2iI9OhFirHxw3aiTeEk4yGSIYnFPpbQxUoniOQ=;\n\tb=TGA64Aney4H6pgFmAz058cPEdQP4C/S8ZPBKJ+A07v3hWOFKGfCCw2fJeHZAgGVjSX\n\tR6392j/VXkpMV6XVkyvZFUjmIsNUPbAbEeMVmOUsKwsMhMen7imd+DD2DwxTp1Ow8HJm\n\tbKsvbO1HlVLmv8TyPc/cpoBZY6WUB/R0/gtUhbTpL2yzNLX5Wl4m4Cuw7vIlF+CcSR0g\n\tzReMQ70zXJ2whxHmyW9w954/K1l+mFymIEdxFeQCliwlrXcH/IaqPeMwhWg2k+UoRzBA\n\towq4MAFpfeQK77NyPlTJV0iEtlOh14vLyfSz0UIFkaf7AXuS3VcfSokSnOPUX6IUxTbC\n\txi/Q==","X-Gm-Message-State":"AOJu0Yx/vNYNfgsuFogGf+nN2V1fErcxMo7nUi3mdwUlH+loiJlXIZ2T\n\t+Kjejfm1g+jewVlY3RiGMu9s2b2jwsEN81aO0NNINVIIkcjOPFJ4hR3Mhprl/6uAFrbLjkq5328\n\toATEZ0TWjOba+bqPJQXlUzbtHYw9RSt/ETGZEU+XYhQ==","X-Gm-Gg":"AR+sD11Vr5CUV86FDKjWXHBWvvTc+YG7pST+/1m7TOOnE7FtCdtuQX40RBouQOTbrW8\n\tytpcQL85Av55ZxLTJ9/YkQJ1bdZp+PBBzUhE3stF5ZZefjtii5CDocbU++IxtalOtYhpUUD6GRW\n\tLgqo9FKhZkk50vi1YJfyr0CSvROGRgQ2lGX0aFisatwE2rERc3JGXUJAu/BmUX270/5pMBN0+IO\n\tqB5Ch8iVDtfiEiuIgzUHA12pvVo7tz2cU7iuLFEG0HmxxAU45fNTWvqH+zNDcNRQE49Ix1AaMnJ\n\t8+oX14uWpui2e+qjt43RRbwF5gVQwv6B5g+V+gS6UyAVIcSiPjQ1WXzpYiUVF7seZBET5JWnq2M\n\t69G3KIKdu3mi2ShsD0QASKGnTHgBG7JprGhlvdx4GElXKxzFDy8Lsxcf3IWndYqgUSX+dMCCsGC\n\tbtb3MVEcIxNb69C9tiC5JoshtfUCA71J8IvOa2mHGFxRW+zKcCLKm5Y81PJu8xqE87n9Jl/CWkK\n\tonApDKn0Uugj58/jQ3EClDb7oVuFWxWAyLGbByHdg==","X-Received":"by 2002:a05:690c:6d07:b0:81f:27f8:2de4 with SMTP id\n\t00721157ae682-81fd4a04799mr4341847b3.8.1785512678702; Fri, 31 Jul 2026\n\t08:44:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"John Cronin ","Date":"Fri, 31 Jul 2026 08:44:37 -0700","X-Gm-Features":"AUfX_mwSeW8mRezvt6vPZd4QnguYQTUT58CVHX25H6jgSKy4YZvGWv2SFkW_pK8","Message-ID":"","Subject":"Re: [PATCH v4 2/2] libcamera: camera_sensor_properties: Add imx471","To":"jacopo.mondi@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org, kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]