[{"id":39855,"web_url":"https://patchwork.libcamera.org/comment/39855/","msgid":"<20260724215143.GC1059400@killaraus.ideasonboard.com>","date":"2026-07-24T21:51:43","subject":"Re: [RFC PATCH 1/1] pipeline: Add NVIDIA Tegra VI pipeline handler","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jul 24, 2026 at 07:47:01PM +0200, Magdum wrote:\n> Introduce a new pipeline handler targeting upstream tegra-video\n> V4L2/Media Controller drivers for Jetson platforms (Nano, TX2,\n> Xavier, Orin).\n> \n> - Route raw Bayer frames from the VI engine through SoftwareISP\n> - Wire up automatic SoftISP dependencies inside meson.build\n> - Handle multi-frame synchronization using DelayedControls\n> - Add platform matching support for \"tegra-vi\" and \"tegra234-vi\"\n> \n> Signed-off-by: Magdum \n> ---\n> include/libcamera/ipa/meson.build | 1 +\n> meson_options.txt | 1 +\n> src/libcamera/pipeline/tegra/meson.build | 5 +\n> src/libcamera/pipeline/tegra/tegra.cpp | 1102 ++++++++++++++++++++++\n> src/libcamera/software_isp/meson.build | 2 +-\n> 5 files changed, 1110 insertions(+), 1 deletion(-)\n> create mode 100644 src/libcamera/pipeline/tegra/meson.build\n> create mode 100644 src/libcamera/pipeline/tegra/tegra.cpp\n\n[snip]\n\n> diff --git a/src/libcamera/pipeline/tegra/tegra.cpp b/src/libcamera/pipeline/tegra/tegra.cpp\n> new file mode 100644\n> index 000000000..6d84dd718\n> --- /dev/null\n> +++ b/src/libcamera/pipeline/tegra/tegra.cpp\n> @@ -0,0 +1,1102 @@\n\n[snip]\n\n> +bool PipelineHandlerTegra::match(DeviceEnumerator *enumerator)\n> +{\n> +\t/*\n> +\t * Try both known Tegra VI driver names.\n> +\t * \"tegra-vi\" – Tegra 210 / 186 / 194 (Nano / TX2 / Xavier)\n> +\t * \"tegra234-vi\" – Tegra 234 (Orin)\n\nWhere is the tegra234-vi driver ? Grepping for that string in the\nmainline kernel sources doesn't produce any hit, and searches on\nlore.kernel.org are not successful either.\n\nAs a rule, libcamera requires kernel drivers to be upstream. We can\nfast-track merging changes when the drivers are reasonably close to\nbeing merged (i.e. when we are confident they will be merged in a not\ntoo distant future). We don't support drivers from downstream kernels\nwith no upstreaming effort.\n\n> +\t */\n> +\tstatic const char *const kDriverNames[] = {\n> +\t\t\"tegra-vi\",\n> +\t\t\"tegra234-vi\",\n> +\t};\n> +\n> +\tbool matched = false;\n> +\n> +\tfor (const char *driverName : kDriverNames) {\n> +\t\tDeviceMatch dm(driverName);\n> +\t\tstd::shared_ptr media =\n> +\t\t\tacquireMediaDevice(enumerator, dm);\n> +\t\tif (!media)\n> +\t\t\tcontinue;\n> +\n> +\t\tLOG(TegraPipeline, Debug)\n> +\t\t\t<< \"Found Tegra VI media device (\"\n> +\t\t\t<< driverName << \")\";\n> +\n> +\t\t/*\n> +\t\t * Enumerate all camera sensor entities and attempt to build a\n> +\t\t * camera for each one.\n> +\t\t */\n> +\t\tfor (MediaEntity *entity : media->entities()) {\n> +\t\t\tif (entity->function() != MEDIA_ENT_F_CAM_SENSOR)\n> +\t\t\t\tcontinue;\n> +\n> +\t\t\tif (createCamera(media, entity))\n> +\t\t\t\tmatched = true;\n> +\t\t}\n> +\t}\n> +\n> +\treturn matched;\n> +}\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 659C8BE080\n\tfor ;\n\tFri, 24 Jul 2026 21:51:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95AA267F48;\n\tFri, 24 Jul 2026 23:51:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B15167F22\n\tfor ;\n\tFri, 24 Jul 2026 23:51:45 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5421273B;\n\tFri, 24 Jul 2026 23:50:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KC9T9wvO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784929843;\n\tbh=hPriNrIQNe5rFPBuq3gFi5MlfQ3fj3cu6CcCN1P2wOQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KC9T9wvOlQ8LGu2bkhYIbVbfznxOwZOn0jTzs+prW0HrFgYNWc+SwE0SG7Wl81fZo\n\tiC8vOfnvWCwXeXjWuJosCtzDEZPjF1ilHQwlUrP0nj5TW7rhqo+52KWRMtpzvBhZ3B\n\tSlcRPTh7jPFtnvNjn+i1cJaBYxsNJ953HpBzzR24=","Date":"Sat, 25 Jul 2026 00:51:43 +0300","From":"Laurent Pinchart ","To":"Magdum ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH 1/1] pipeline: Add NVIDIA Tegra VI pipeline handler","Message-ID":"<20260724215143.GC1059400@killaraus.ideasonboard.com>","References":"<20260724174705.9411-1-magdum.foss@gmail.com>\n\t<20260724174705.9411-2-magdum.foss@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260724174705.9411-2-magdum.foss@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]