[{"id":39848,"web_url":"https://patchwork.libcamera.org/comment/39848/","msgid":"<178490883868.1671930.6504694108675948202@ping.linuxembedded.co.uk>","date":"2026-07-24T16:00:38","subject":"Re: [PATCH v2 5/5] libcamera: sensor: Add Mira220 sensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-07-24 16:47:44)\n> Add sensor properties for the AMS-OSRAM Mira220 camera sensor.\n> \n> The sensor has a 1 frame delay for exposure.\n> The vblank delay is not characterized in the datasheet.\n> \n> Hblank and analogue gain are fixed and not programmable, so fix their\n> delays to 1.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 28043150e2cb..30755608870c 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -335,6 +335,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .hblankDelay = 3\n> },\n> } },\n> + { \"mira220\", {\n> + .unitCellSize = { 2790, 2790 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1 },\n> + },\n> + .sensorDelays = {\n> + .exposureDelay = 1,\n> + .vblankDelay = 1,\n> + /* Gain and hblank are read-only. */\n> + .gainDelay = 1,\n> + .hblankDelay = 1\n> + },\n> + } },\n> { \"ov2685\", {\n> .unitCellSize = { 1750, 1750 },\n> .testPatternModes = {\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EFDCBDE17\n\tfor ;\n\tFri, 24 Jul 2026 16:00:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9D6967F3F;\n\tFri, 24 Jul 2026 18:00:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6414E67F22\n\tfor ;\n\tFri, 24 Jul 2026 18:00:41 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60E54524;\n\tFri, 24 Jul 2026 17:59:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YVmEUWhH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784908779;\n\tbh=5NQT97koFWEzGyftCAjnm8Rq4A+istHSdK15NqHHzpo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YVmEUWhHErLk7F8KPcRqFvvudowFFQNsyUqpXIy6TLXO9mFicCkGlqD6eNMTZB1nf\n\tRHY6/nQOB9tMQ6fhvrfvzUFqgVqsKNubnqc0tEsJHAVm7Wz+A5yHo+aDBaearepZkb\n\tk2j8KHGhH84sztAarEdme2gw+8Cp89J7hRSQw9l0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260724-mira220-v2-5-240003749dd0@ideasonboard.com>","References":"<20260724-mira220-v2-0-240003749dd0@ideasonboard.com>\n\t<20260724-mira220-v2-5-240003749dd0@ideasonboard.com>","Subject":"Re: [PATCH v2 5/5] libcamera: sensor: Add Mira220 sensor properties","From":"Kieran Bingham ","Cc":"Philippe Baetens ,\n\tJacopo Mondi ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jul 2026 17:00:38 +0100","Message-ID":"<178490883868.1671930.6504694108675948202@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]