[{"id":39847,"web_url":"https://patchwork.libcamera.org/comment/39847/","msgid":"<178490840275.1159743.12331919921700814783@ping.linuxembedded.co.uk>","date":"2026-07-24T15:53:22","subject":"Re: [PATCH v2 4/5] libipa: camera_sensor_helper: Add Mira220","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-07-24 16:47:43)\n> Add a camera sensor helper for the AMS-OSRAM Mira220 sensor.\n> \n> The black level and gain model have been extracted from the\n> corresponding helpers for the RaspberryPi IPA.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 9ab7a52f2644..a9877935cb2a 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -665,6 +665,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n> \n> +class CameraSensorHelperMira220 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperMira220()\n> + {\n> + blackLevel_ = 2050;\n\nI think this should be 2500 based on the pi tuning files:\n\nWith that\n\nReviewed-by: Kieran Bingham \n\n> + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"mira220\", CameraSensorHelperMira220)\n> +\n> class CameraSensorHelperOv2685 : public CameraSensorHelper\n> {\n> public:\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 995EBBDE17\n\tfor ;\n\tFri, 24 Jul 2026 15:53:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F70D67F3D;\n\tFri, 24 Jul 2026 17:53:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5A5A67F22\n\tfor ;\n\tFri, 24 Jul 2026 17:53:25 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE86F524;\n\tFri, 24 Jul 2026 17:52:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p3Zcx+/T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784908344;\n\tbh=lMoS8Es5uEYMSgAjTdLJ5xorXWsWvHoUKy8XhbazY74=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=p3Zcx+/T8IFLzqtUgvQ0fQYJ8E0xJkrjJkxKO+6SgAeWAOnAtAHbS0KZ/wLKI9EgC\n\tFb5g4unJKmAwB5U9zoTAvkDgeKqrt1nD935WAdAqlNuphHBuaAjUB0gq6UyYqgoONb\n\tQ1rkctS//joHZ8WwDGnmYIvHdq5xy/ikwCLpUiSk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260724-mira220-v2-4-240003749dd0@ideasonboard.com>","References":"<20260724-mira220-v2-0-240003749dd0@ideasonboard.com>\n\t<20260724-mira220-v2-4-240003749dd0@ideasonboard.com>","Subject":"Re: [PATCH v2 4/5] libipa: camera_sensor_helper: Add Mira220","From":"Kieran Bingham ","Cc":"Philippe Baetens ,\n\tJacopo Mondi ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jul 2026 16:53:22 +0100","Message-ID":"<178490840275.1159743.12331919921700814783@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]