[{"id":3682,"web_url":"https://patchwork.libcamera.org/comment/3682/","msgid":"<20200211234834.GP20823@pendragon.ideasonboard.com>","date":"2020-02-11T23:48:34","subject":"Re: [libcamera-devel] [PATCH v1 16/23] gst: libcamerasrc: Push\n\tsegment event","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nOn Tue, Jan 28, 2020 at 10:32:03PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> \n> Now that we have stream-start and caps, we can now push a segment event to\n> announce what time will our buffer correlate to. For live sources this is just\n> an open segment in time format.\n> \n> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/gstreamer/gstlibcamerasrc.cpp | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 7b478fa..0df71c6 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -191,6 +191,11 @@ gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n>  \t\t\tflow_ret = GST_FLOW_NOT_NEGOTIATED;\n>  \t\t\tbreak;\n>  \t\t}\n> +\n> +\t\t/* Send an open segment event with time format */\n> +\t\tGstSegment segment;\n> +\t\tgst_segment_init(&segment, GST_FORMAT_TIME);\n> +\t\tgst_pad_push_event(srcpad, gst_event_new_segment(&segment));\n>  \t}\n>  \n>  \tret = state->cam->configure(state->config.get());","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8958261020\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Feb 2020 00:48:50 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 168B29DA;\n\tWed, 12 Feb 2020 00:48:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581464930;\n\tbh=vhI3U7ZDHfL+Uz2ztnZ2FWXV+zIVLuxHO5pnI5OHcOs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SKefclNp6bIh+E05XkDDjfB0x0kUfvpCi9rIZNyiiJhoJ7hODC3TIag3pMuP8lC41\n\tbs273oc/kcNE7eS5aHR4egb5eJw3bKs+T3lfIqEu+0wx7hWgb1HSfs+mNVtpfQqUU4\n\tBeThnhZpJHusrlM10w8SSBVP5zNrB8tms4GBCAS4=","Date":"Wed, 12 Feb 2020 01:48:34 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Nicolas Dufresne <nicolas@ndufresne.ca>","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne <nicolas.dufresne@collabora.com>","Message-ID":"<20200211234834.GP20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-17-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-17-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 16/23] gst: libcamerasrc: Push\n\tsegment event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 11 Feb 2020 23:48:50 -0000"}}]