{"id":27488,"url":"https://patchwork.libcamera.org/api/patches/27488/?format=json","web_url":"https://patchwork.libcamera.org/patch/27488/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-40-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:43:22","name":"[RFC,v2,39/43] ipa: libipa: agc_msv: Handle min gain > 1.0 case","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e4bd22d38313b21f277b2cd277c1dae0b8af9cb6","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27488/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27488/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27488/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39C31C3306\n\tfor ;\n\tThu, 23 Jul 2026 15:44:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E338F67F21;\n\tThu, 23 Jul 2026 17:44:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BD9067EEE\n\tfor ;\n\tThu, 23 Jul 2026 17:43:40 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B0F723B9\n\tfor ;\n\tThu, 23 Jul 2026 17:42:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uUS+67AD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821359;\n\tbh=us5b72jVS9CEihNUNUbHeWP3SVXlyNl+8YqisAEAHEU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=uUS+67ADB6btGh+NjRKBurdluGvYT0awqoi3uR/ewyc0gjdZKduFq10W3mbplUY+l\n\tgpBhCTmXuKtEvkwVk+yZYT1yD0DfjkX0PRAmOO7zfaOwUtMCwcf0TvIGHNfXKX83nE\n\tREgFjyhPKFkHKydPYzN1WFhogX0+4/1AoVga8Jfs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 39/43] ipa: libipa: agc_msv: Handle min gain > 1.0\n\tcase","Date":"Thu, 23 Jul 2026 17:43:22 +0200","Message-ID":"<20260723154327.1357866-40-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When manual gain control is enabled in `AgcAlgorithm`, the limits will\nbe set to that particular value. This is very likely larger than 1.0.\nIn this case, however, the algorithm should still adjust the exposure\ntime if it can. So compare the gain with the minimum of 1.0 and the\nconfigured min gain, in order to ensure that the exposure will be\nadjusted if the lower boundary of the allowed analogue gains is reached.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc_msv.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/agc_msv.cpp b/src/ipa/libipa/agc_msv.cpp\nindex 956551685c..9fec2ba48a 100644\n--- a/src/ipa/libipa/agc_msv.cpp\n+++ b/src/ipa/libipa/agc_msv.cpp\n@@ -206,7 +206,7 @@ AgcMSV::Result AgcMSV::updateExposure(uint32_t exposure, double again, float exp\n \t\t\t}\n \t\t} else {\n \t\t\t/* Scene too bright: decrease gain first, then exposure. */\n-\t\t\tif (again > limits_.gain1) {\n+\t\t\tif (again > std::max(limits_.gain1, limits_.gain[0])) {\n \t\t\t\tdouble next = again * factor;\n \t\t\t\tagain = std::min(next, again - limits_.gainMinStep);\n \t\t\t} else {\n","prefixes":["RFC","v2","39/43"]}